New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 669264 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add Cronet tests of different Cronet impl packaging

Project Member Reported by kapishnikov@chromium.org, Nov 28 2016

Issue description

Cronet provides two engine implementations, the native one and Java-based one. Depending on needs, an embedder can choose to package the native implementation, Java implementation or both. We need to add tests to test these different Cronet packagings. The tests should include the verification of proguard specs.

The tests can also help in solving  Issue 637972 . By having two APKs (i.e. one that packages native engine and another that packages  Java impl only), we can cleanly run the tests with both implementations.
 
Owner: kapishnikov@chromium.org
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Opened  Issue 672604  to add the new tests to the cronet bot.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a4cba9f6d608b3347984e3aaa6f7dfd1d9f63b3

commit 7a4cba9f6d608b3347984e3aaa6f7dfd1d9f63b3
Author: kapishnikov <kapishnikov@chromium.org>
Date: Tue Dec 27 17:44:48 2016

Cronet smoke tests

1. Added test support classes that allow running the smoke tests in
   different environments against different servers. There is one
   support class for Java-only tests and one that requires H2 & QUIC.
   The concrete implementation of support classes is determined at
   runtime by reading the value of |TestSupportImplClass| from the
   Android string resource file.
2. Added two test APKs one for Java only deployment and one to test
   behavior when the native “.so” file is absent.
3. Enabled proguarding for the existing unit tests. The new APKS also
   run proguard in order to check the correctness of proguard configs
   for different deployments.
4. Added new HttpServer for Java-only scenario that does not depend on
   Chromium “base” and “net” modules.
5. Added two additional smoke QUIC & H2 tests to the existing test APK.

To run all smoke tests, execute:

ninja -C out/Debug cronet_smoketests_platform_only_instrumentation_apk \
cronet_smoketests_missing_native_library_instrumentation_apk \
cronet_test_instrumentation_apk -j 240 && \
./out/Debug/bin/run_cronet_smoketests_platform_only_instrumentation_apk && \
./out/Debug/bin/run_cronet_smoketests_missing_native_library_instrumentation_apk && \
./out/Debug/bin/run_cronet_test_instrumentation_apk \
--test-filter=org.chromium.net.smoke.*

The output jars that contain the smoke tests:
./out/Debug/lib.java/components/cronet/android/cronet_smoketests_missing_native_library_java.jar
./out/Debug/lib.java/components/cronet/android/cronet_smoketests_native_java.jar
./out/Debug/lib.java/components/cronet/android/cronet_smoketests_platform_only_java.jar

BUG= 669264 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2561803002
Cr-Commit-Position: refs/heads/master@{#440760}

[modify] https://crrev.com/7a4cba9f6d608b3347984e3aaa6f7dfd1d9f63b3/components/cronet/android/BUILD.gn
[modify] https://crrev.com/7a4cba9f6d608b3347984e3aaa6f7dfd1d9f63b3/components/cronet/android/cronet_impl_common_proguard.cfg
[modify] https://crrev.com/7a4cba9f6d608b3347984e3aaa6f7dfd1d9f63b3/components/cronet/android/cronet_impl_native_proguard.cfg
[delete] https://crrev.com/9273ccb313e40ed1cf5fd6e049e7b63a6aeed933/components/cronet/android/test/javaperftests/proguard.cfg
[add] https://crrev.com/7a4cba9f6d608b3347984e3aaa6f7dfd1d9f63b3/components/cronet/android/test/proguard.cfg
[add] https://crrev.com/7a4cba9f6d608b3347984e3aaa6f7dfd1d9f63b3/components/cronet/android/test/smoketests/res/native/values/strings.xml
[add] https://crrev.com/7a4cba9f6d608b3347984e3aaa6f7dfd1d9f63b3/components/cronet/android/test/smoketests/res/native/xml/network_security_config.xml
[add] https://crrev.com/7a4cba9f6d608b3347984e3aaa6f7dfd1d9f63b3/components/cronet/android/test/smoketests/res/platform_only/values/strings.xml
[add] https://crrev.com/7a4cba9f6d608b3347984e3aaa6f7dfd1d9f63b3/components/cronet/android/test/smoketests/res/platform_only/xml/network_security_config.xml
[add] https://crrev.com/7a4cba9f6d608b3347984e3aaa6f7dfd1d9f63b3/components/cronet/android/test/smoketests/src/org/chromium/net/smoke/ChromiumNativeTestSupport.java
[add] https://crrev.com/7a4cba9f6d608b3347984e3aaa6f7dfd1d9f63b3/components/cronet/android/test/smoketests/src/org/chromium/net/smoke/ChromiumPlatformOnlyTestSupport.java
[add] https://crrev.com/7a4cba9f6d608b3347984e3aaa6f7dfd1d9f63b3/components/cronet/android/test/smoketests/src/org/chromium/net/smoke/CronetSmokeTestCase.java
[add] https://crrev.com/7a4cba9f6d608b3347984e3aaa6f7dfd1d9f63b3/components/cronet/android/test/smoketests/src/org/chromium/net/smoke/Http2Test.java
[add] https://crrev.com/7a4cba9f6d608b3347984e3aaa6f7dfd1d9f63b3/components/cronet/android/test/smoketests/src/org/chromium/net/smoke/HttpTestServer.java
[add] https://crrev.com/7a4cba9f6d608b3347984e3aaa6f7dfd1d9f63b3/components/cronet/android/test/smoketests/src/org/chromium/net/smoke/MissingNativeLibraryTest.java
[add] https://crrev.com/7a4cba9f6d608b3347984e3aaa6f7dfd1d9f63b3/components/cronet/android/test/smoketests/src/org/chromium/net/smoke/NativeCronetTestCase.java
[add] https://crrev.com/7a4cba9f6d608b3347984e3aaa6f7dfd1d9f63b3/components/cronet/android/test/smoketests/src/org/chromium/net/smoke/PlatformOnlyEngineTest.java
[add] https://crrev.com/7a4cba9f6d608b3347984e3aaa6f7dfd1d9f63b3/components/cronet/android/test/smoketests/src/org/chromium/net/smoke/QuicTest.java
[add] https://crrev.com/7a4cba9f6d608b3347984e3aaa6f7dfd1d9f63b3/components/cronet/android/test/smoketests/src/org/chromium/net/smoke/SmokeTestRequestCallback.java
[add] https://crrev.com/7a4cba9f6d608b3347984e3aaa6f7dfd1d9f63b3/components/cronet/android/test/smoketests/src/org/chromium/net/smoke/TestSupport.java

Status: Fixed (was: Started)

Sign in to add a comment