New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 669254 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Move bug queue to the bottom of the page.

Project Member Reported by zhangtiff@chromium.org, Nov 28 2016

Issue description

Bug queues are lower priority for sheriffs than alerts, so we should move them to the bottom of the page. 

Keep them at the top for the trooper tab though. Perhaps eventually a tree-based option to configure the order of major sections.  
 
Owner: zhangtiff@chromium.org

Comment 2 by benhenry@google.com, Dec 19 2016

Status: Assigned (was: Untriaged)
There is an owner on this bug, but the status was not "Assigned" or "Started". Fixing. If you do not own this bug, please remove yourself as the owner and make the status "Available".
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/8f84797d9922a3d6f2253f4c1bc36993847d39f1

commit 8f84797d9922a3d6f2253f4c1bc36993847d39f1
Author: Tiff Zhang <zhangtiff@google.com>
Date: Fri Jan 27 22:17:41 2017

SoM: Add bug priority category headers + more whitespace adjustments.

BUG= 637006 
BUG= 669254 

Change-Id: Ie9ec0a48fc4a3c973c908dc0f36e18dd7fcd36f5
Reviewed-on: https://chromium-review.googlesource.com/433819
Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org>
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>

[modify] https://crrev.com/8f84797d9922a3d6f2253f4c1bc36993847d39f1/go/src/infra/appengine/sheriff-o-matic/elements/som-alert-item/som-alert-item.html
[modify] https://crrev.com/8f84797d9922a3d6f2253f4c1bc36993847d39f1/go/src/infra/appengine/sheriff-o-matic/elements/som-app/som-app.html
[modify] https://crrev.com/8f84797d9922a3d6f2253f4c1bc36993847d39f1/go/src/infra/appengine/sheriff-o-matic/elements/som-bug-queue/som-bug-queue.html
[modify] https://crrev.com/8f84797d9922a3d6f2253f4c1bc36993847d39f1/go/src/infra/appengine/sheriff-o-matic/elements/som-bug-queue/som-bug-queue.js
[modify] https://crrev.com/8f84797d9922a3d6f2253f4c1bc36993847d39f1/go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure/som-extension-build-failure.html
[modify] https://crrev.com/8f84797d9922a3d6f2253f4c1bc36993847d39f1/go/src/infra/appengine/sheriff-o-matic/elements/som-swarming-bots/som-swarming-bots.html
[modify] https://crrev.com/8f84797d9922a3d6f2253f4c1bc36993847d39f1/go/src/infra/appengine/sheriff-o-matic/test/som-bug-queue-test.html

My hope is that collapsing the bugs by priority will help with making the bug queue feel less like it's getting in the way of what a sheriff should be doing.

I will keep this open though because "Start at the top and try to clear all the alerts" doesn't work as well when the top is not the highest priority. :) 
I do want to note that this is trivial to do with Polymer if statements. But I think I'd prefer to do some sort of solution that assigned priorities to the top level sections (ie: Bug Queue, Alerts, Dead Swarming Bots) and reordered them based on per-tree config. 
Cc: jparent@chromium.org
I don't know if we actually want the bug queue at the bottom of the page. It could lead to less prioritization of bug issues (like flaky) tests, which might be bad.

Have particular sheriffs asked for this? What do current sheriffs think about this idea?
This was mentioned in one of the older feedback writeups we had. This one: https://docs.google.com/document/d/1rs4GeM-BxEyoj5L1nyEJPATTdPWVoXUjqUth71AKYSo/edit# 

"Chromium bug queue
Contains bugs that I just filed from issues in SOM. I already know about these, they are linked to my SOM issues. Don’t show bugs here if they are linked to a SOM issue.
This section should be the last priority, not first. (First should be fixing the tree.)
"

So this has been requested by a sheriff before, but it's unclear if sheriffs in general would find this better. 
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/ba122b28213ba81587c7bcda24b4469b99b5887f

commit ba122b28213ba81587c7bcda24b4469b99b5887f
Author: Tiff Zhang <zhangtiff@google.com>
Date: Fri Feb 10 21:11:02 2017

SoM: Move bug queue to bottom except for troopers + CSS/HTML cleanup

BUG= 669254 

Change-Id: I68bcdbb688e7adaa96aecb3d05a52e5b48be051f
Reviewed-on: https://chromium-review.googlesource.com/439429
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org>

[modify] https://crrev.com/ba122b28213ba81587c7bcda24b4469b99b5887f/go/src/infra/appengine/sheriff-o-matic/elements/som-alert-item/som-alert-item.html
[modify] https://crrev.com/ba122b28213ba81587c7bcda24b4469b99b5887f/go/src/infra/appengine/sheriff-o-matic/elements/som-bug-queue/som-bug-queue.js
[modify] https://crrev.com/ba122b28213ba81587c7bcda24b4469b99b5887f/go/src/infra/appengine/sheriff-o-matic/elements/som-app/som-app.html
[modify] https://crrev.com/ba122b28213ba81587c7bcda24b4469b99b5887f/go/src/infra/appengine/sheriff-o-matic/elements/pages/som-rotation-calendar.html
[modify] https://crrev.com/ba122b28213ba81587c7bcda24b4469b99b5887f/go/src/infra/appengine/sheriff-o-matic/elements/som-app/som-app.js
[modify] https://crrev.com/ba122b28213ba81587c7bcda24b4469b99b5887f/go/src/infra/appengine/sheriff-o-matic/elements/som-alert-item/som-alert-item.js
[modify] https://crrev.com/ba122b28213ba81587c7bcda24b4469b99b5887f/go/src/infra/appengine/sheriff-o-matic/elements/pages/som-help.html
[modify] https://crrev.com/ba122b28213ba81587c7bcda24b4469b99b5887f/go/src/infra/appengine/sheriff-o-matic/elements/som-bug-queue/som-bug-queue.html

Status: Fixed (was: Assigned)
This was done then undone and now changed to: https://bugs.chromium.org/p/chromium/issues/detail?id=701470 
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/8f84797d9922a3d6f2253f4c1bc36993847d39f1

commit 8f84797d9922a3d6f2253f4c1bc36993847d39f1
Author: Tiff Zhang <zhangtiff@google.com>
Date: Fri Jan 27 22:29:45 2017

SoM: Add bug priority category headers + more whitespace adjustments.

BUG= 637006 
BUG= 669254 

Change-Id: Ie9ec0a48fc4a3c973c908dc0f36e18dd7fcd36f5
Reviewed-on: https://chromium-review.googlesource.com/433819
Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org>
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>

[modify] https://crrev.com/8f84797d9922a3d6f2253f4c1bc36993847d39f1/go/src/infra/appengine/sheriff-o-matic/elements/som-alert-item/som-alert-item.html
[modify] https://crrev.com/8f84797d9922a3d6f2253f4c1bc36993847d39f1/go/src/infra/appengine/sheriff-o-matic/elements/som-bug-queue/som-bug-queue.js
[modify] https://crrev.com/8f84797d9922a3d6f2253f4c1bc36993847d39f1/go/src/infra/appengine/sheriff-o-matic/elements/som-app/som-app.html
[modify] https://crrev.com/8f84797d9922a3d6f2253f4c1bc36993847d39f1/go/src/infra/appengine/sheriff-o-matic/elements/som-extension-build-failure/som-extension-build-failure.html
[modify] https://crrev.com/8f84797d9922a3d6f2253f4c1bc36993847d39f1/go/src/infra/appengine/sheriff-o-matic/elements/som-swarming-bots/som-swarming-bots.html
[modify] https://crrev.com/8f84797d9922a3d6f2253f4c1bc36993847d39f1/go/src/infra/appengine/sheriff-o-matic/test/som-bug-queue-test.html
[modify] https://crrev.com/8f84797d9922a3d6f2253f4c1bc36993847d39f1/go/src/infra/appengine/sheriff-o-matic/elements/som-bug-queue/som-bug-queue.html

Sign in to add a comment