New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 669227 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 855293



Sign in to add a comment

MaterialHistoryListTest.All fails more often than not

Project Member Reported by mek@chromium.org, Nov 28 2016

Issue description

As can be seen at https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=MaterialHistoryListTest.All&testType=browser_tests this test fails more often than that it passes, random failure case:

[ RUN      ] MaterialHistoryListTest.All
Xlib:  extension "RANDR" missing on display ":9".
Xlib:  extension "RANDR" missing on display ":9".
[9838:9838:1128/134313:WARNING:audio_manager.cc(317)] Multiple instances of AudioManager detected
[9838:9838:1128/134313:WARNING:audio_manager.cc(278)] Multiple instances of AudioManager detected
[9838:9838:1128/134313:WARNING:password_store_factory.cc(248)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[9838:9838:1128/134314:INFO:CONSOLE(1209)] "Running TestCase MaterialHistoryListTest.All", source: test_api.js (1209)
[9838:9838:1128/134316:ERROR:CONSOLE(48)] "Mocha test failed: <history-list> focus and keyboard nav
Error: Uncaught AssertionError: expected undefined to equal <a id="title" class="website-title" title="https://www.google.com" href="https://www.google.com" focus-type="title" tabindex="-1">
            <history-searched-label>https://www.google.com</history-searched-label>
          </a> (chai.js:206)
", source: mocha_adapter.js (48)
[9838:9838:1128/134316:ERROR:CONSOLE(206)] "Uncaught AssertionError: expected undefined to equal <a id="title" class="website-title" title="https://www.google.com" href="https://www.google.com" focus-type="title" tabindex="-1">
            <history-searched-label>https://www.google.com</history-searched-label>
          </a>", source: chai.js (206)
[9838:9838:1128/134316:INFO:CONSOLE(125)] "Page load time: 57 ms", source: polymer_browser_test_base.js (125)
[9838:9838:1128/134316:INFO:CONSOLE(127)] "Test run time: 2561 ms", source: polymer_browser_test_base.js (127)
[9838:9838:1128/134316:INFO:CONSOLE(129)] "Total time: 2618 ms", source: polymer_browser_test_base.js (129)
[9838:9838:1128/134316:ERROR:web_ui_test_handler.cc(76)] Test Errors: 1/17 tests had failed assertions.
[9838:9838:1128/134316:ERROR:web_ui_browser_test.cc(473)] CONDITION FAILURE: encountered javascript console error(s):
[9838:9838:1128/134316:ERROR:web_ui_browser_test.cc(475)] JS ERROR: '[9838:9838:1128/134316:ERROR:CONSOLE(48)] "Mocha test failed: <history-list> focus and keyboard nav
Error: Uncaught AssertionError: expected undefined to equal <a id="title" class="website-title" title="https://www.google.com" href="https://www.google.com" focus-type="title" tabindex="-1">
            <history-searched-label>https://www.google.com</history-searched-label>
          </a> (chai.js:206)
", source: mocha_adapter.js (48)
'
[9838:9838:1128/134316:ERROR:web_ui_browser_test.cc(475)] JS ERROR: '[9838:9838:1128/134316:ERROR:CONSOLE(206)] "Uncaught AssertionError: expected undefined to equal <a id="title" class="website-title" title="https://www.google.com" href="https://www.google.com" focus-type="title" tabindex="-1">
            <history-searched-label>https://www.google.com</history-searched-label>
          </a>", source: chai.js (206)
'
[9838:9838:1128/134316:ERROR:web_ui_browser_test.cc(477)] JS call assumed failed, because JS console error(s) found.
gen/chrome/test/data/webui/md_history/md_history_browsertest-gen.cc:188: Failure
Value of: RunJavascriptTestF( true, "MaterialHistoryListTest", "All")
  Actual: false
Expected: true
[  FAILED  ] MaterialHistoryListTest.All, where TypeParam =  and GetParam() =  (3132 ms)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b779bfb4d6ecc6285e4fe1dc11c0aaf3bc8c4de

commit 3b779bfb4d6ecc6285e4fe1dc11c0aaf3bc8c4de
Author: mek <mek@chromium.org>
Date: Tue Nov 29 00:48:27 2016

Disable MatrialHistoryListTest.All as it is very flaky.

BUG= 669227 
TBR=tsergeant@chromium.org

Review-Url: https://codereview.chromium.org/2533103002
Cr-Commit-Position: refs/heads/master@{#434803}

[modify] https://crrev.com/3b779bfb4d6ecc6285e4fe1dc11c0aaf3bc8c4de/chrome/test/data/webui/md_history/md_history_browsertest.js

Cc: tsergeant@chromium.org
Components: Tests>Flaky
Owner: calamity@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1cc4784734dfff40f1f053c696b32acea7f6304

commit f1cc4784734dfff40f1f053c696b32acea7f6304
Author: tsergeant <tsergeant@chromium.org>
Date: Thu Dec 01 04:28:31 2016

MD History: Disable individual failing List test rather than entire suite

This disables the 'focus and keyboard nav' test and re-enables
the rest of HistoryListTest.

BUG= 669227 

Review-Url: https://codereview.chromium.org/2545603003
Cr-Commit-Position: refs/heads/master@{#435552}

[modify] https://crrev.com/f1cc4784734dfff40f1f053c696b32acea7f6304/chrome/test/data/webui/md_history/history_list_test.js
[modify] https://crrev.com/f1cc4784734dfff40f1f053c696b32acea7f6304/chrome/test/data/webui/md_history/md_history_browsertest.js

This should be fixed. Please reopen if flakes happen again.
Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db29d83db00f668138848dd1ada9be02983690db

commit db29d83db00f668138848dd1ada9be02983690db
Author: calamity <calamity@chromium.org>
Date: Mon Feb 27 02:43:23 2017

[MD History] Disable slow test on Debug/ASAN.

This CL turns off MaterialHistoryListTest.All on Debug and ASAN builds
which were timing out.

BUG= 669227 

Review-Url: https://codereview.chromium.org/2716593005
Cr-Commit-Position: refs/heads/master@{#453139}

[modify] https://crrev.com/db29d83db00f668138848dd1ada9be02983690db/chrome/test/data/webui/md_history/md_history_browsertest.js

Status: Fixed (was: Assigned)

Comment 9 by kbr@chromium.org, Jun 22 2018

Blocking: 855293
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64934441ebd7cee1a240768765c4bcf07048a58c

commit 64934441ebd7cee1a240768765c4bcf07048a58c
Author: Xida Chen <xidachen@chromium.org>
Date: Wed Aug 15 17:32:18 2018

Disable MaterialHistoryItemTest.All on Mac

See failure here:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14935

TBR=wjmaclean@chromium.org

Bug:  669227 
Change-Id: I75f036c0c4bf3cb883a094ed4f60741b53f3338b
Reviewed-on: https://chromium-review.googlesource.com/1175843
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583302}
[modify] https://crrev.com/64934441ebd7cee1a240768765c4bcf07048a58c/chrome/test/data/webui/md_history/md_history_browsertest.js

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/858c0de5ad1cc3086efb0aa4a7ab082eb857753b

commit 858c0de5ad1cc3086efb0aa4a7ab082eb857753b
Author: Xida Chen <xidachen@chromium.org>
Date: Wed Aug 15 17:42:28 2018

Disable MaterialHistoryItemTest.All on chrome os

Failure here:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/11980

TBR=wjmaclean@chromium.org
NOTRY=true

Bug:  669227 
Change-Id: I4836948e52e9b1b2a1cbb5d6dde6b9707c27fdbc
Reviewed-on: https://chromium-review.googlesource.com/1176123
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583305}
[modify] https://crrev.com/858c0de5ad1cc3086efb0aa4a7ab082eb857753b/chrome/test/data/webui/md_history/md_history_browsertest.js

Sign in to add a comment