New issue
Advanced search Search tips

Issue 669201 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

bad swarming_task_template.json shouldn't cause global 500s

Project Member Reported by estaab@chromium.org, Nov 28 2016

Issue description

A bad swarming_task_template.json was committed (revert 
https://chrome-internal-review.googlesource.com/c/307263/) and caused global 500s in buildbucket. We should have a presubmit check or tryjob to prevent something so avoidable.
 

Comment 1 by estaab@chromium.org, Nov 28 2016

As others have mentioned, this should be implemented as a validation endpoint in cr-buildbucket.

Comment 2 by estaab@chromium.org, Jan 27 2017

Components: Infra>Platform>Buildbucket

Comment 3 by estaab@chromium.org, Jan 27 2017

Components: -Infra>Platform>Buildbucket>Swarmbucket
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 16 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by estaab@chromium.org, Feb 16 2018

Owner: no...@chromium.org
Status: Assigned (was: Untriaged)
Nodir, has validation been added for this already?

Comment 6 by no...@chromium.org, Feb 24 2018

Owner: ----
Status: Available (was: Assigned)
for this particular case (https://chrome-internal-review.googlesource.com/c/infradata/config/+/304482), yes
luci-config rejects *.json files that are not valid JSON.

A bad config file can still cause 500s though, e.g. if someone makes it {}. This kind of validation is not done.

Comment 7 by no...@chromium.org, Apr 30 2018

Labels: buildbucket-go

Comment 8 by no...@chromium.org, Jun 16 2018

Status: WontFix (was: Available)

Sign in to add a comment