bad swarming_task_template.json shouldn't cause global 500s |
||||||||
Issue descriptionA bad swarming_task_template.json was committed (revert https://chrome-internal-review.googlesource.com/c/307263/) and caused global 500s in buildbucket. We should have a presubmit check or tryjob to prevent something so avoidable.
,
Jan 27 2017
,
Jan 27 2017
,
Feb 16 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 16 2018
Nodir, has validation been added for this already?
,
Feb 24 2018
for this particular case (https://chrome-internal-review.googlesource.com/c/infradata/config/+/304482), yes luci-config rejects *.json files that are not valid JSON. A bad config file can still cause 500s though, e.g. if someone makes it {}. This kind of validation is not done.
,
Apr 30 2018
,
Jun 16 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by estaab@chromium.org
, Nov 28 2016