New issue
Advanced search Search tips

Issue 669196 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Don't automatically retry tests for angle tests

Project Member Reported by jmad...@chromium.org, Nov 28 2016

Issue description

Retrying tests can mask new flaky test failures introduced in buggy CLs. This is a Very Bad Thing and we Should Not Do This.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/51f75c5d0dab8147c172adb923d2e9f53f79c8ed

commit 51f75c5d0dab8147c172adb923d2e9f53f79c8ed
Author: Jamie Madill <jmadill@chromium.org>
Date: Mon Nov 28 23:35:50 2016

Suppress flaky Win/AMD/GL end2end tests.

These tests became flaky when google test retries are turned off.

BUG= chromium:669196 
BUG=angleproject:1643
BUG=angleproject:1541

Change-Id: I7cc10f532662928e5436a4e88a42fc109c00bfe8
Reviewed-on: https://chromium-review.googlesource.com/414216
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/51f75c5d0dab8147c172adb923d2e9f53f79c8ed/src/tests/gl_tests/PointSpritesTest.cpp
[modify] https://crrev.com/51f75c5d0dab8147c172adb923d2e9f53f79c8ed/src/tests/gl_tests/TimerQueriesTest.cpp

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/452cbcae2a8dca4d2ebe95678b7163c03abb2308

commit 452cbcae2a8dca4d2ebe95678b7163c03abb2308
Author: geofflang <geofflang@chromium.org>
Date: Wed Nov 30 01:59:28 2016

Roll ANGLE f1a2aef..e157e5a

https://chromium.googlesource.com/angle/angle.git/+log/f1a2aef..e157e5a

BUG= chromium:669196 

TBR=jmadill@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2537273002
Cr-Commit-Position: refs/heads/master@{#435122}

[modify] https://crrev.com/452cbcae2a8dca4d2ebe95678b7163c03abb2308/DEPS

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2027cd96349b99a5382364261a7c1386c1da3057

commit 2027cd96349b99a5382364261a7c1386c1da3057
Author: jmadill <jmadill@chromium.org>
Date: Wed Nov 30 18:31:19 2016

Disable automatic retries of failing ANGLE tests.

This should prevent us from introducing flaky CLs, which is very bad.

BUG= 669196 
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2535753003
Cr-Commit-Position: refs/heads/master@{#435348}

[modify] https://crrev.com/2027cd96349b99a5382364261a7c1386c1da3057/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/2027cd96349b99a5382364261a7c1386c1da3057/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/2027cd96349b99a5382364261a7c1386c1da3057/testing/buildbot/chromium.gpu.json

Status: Fixed (was: Started)

Sign in to add a comment