New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 669190 link

Starred by 1 user
Status: Fixed
Owner:
█ bshe@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR

Blocking:
issue 641401



Sign in to add a comment

VrShellDelegate's ListeningForWebVrActivate not updated when switching tabs.

Project Member Reported by mthiesse@chromium.org, Nov 28 2016 
ListeningForWebVrActivate doesn't update when switching tabs, so when we switch tabs, then enter VR (through headset DON or otherwise), we get put into webVR mode, but with the wrong active tab, kicking us out of VR when the fullscreen timeout fires.

Comment 1 by mthiesse@chromium.org, Nov 28 2016

Blocking: 641401

Comment 2 by bshe@chromium.org, Nov 29 2016

Owner: bshe@chromium.org
Status: Started (was: Available)
I will take a look

Comment 3 by ddorwin@chromium.org, Nov 30 2016

Labels: Proj-VR-Daydream

Comment 4 by ddorwin@chromium.org, Nov 30 2016

Labels: -Proj-VR-Daydream Proj-VR-Shell

Comment 6 by bshe@chromium.org, Dec 1 2016

Labels: Merge-Request-56

Comment 7 by dimu@chromium.org, Dec 1 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 1 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d33ff01c14f51fe6325f8033e002bd4b7e3a9a7

commit 4d33ff01c14f51fe6325f8033e002bd4b7e3a9a7
Author: bshe <bshe@chromium.org>
Date: Thu Dec 01 20:06:00 2016

Don't dispatch vrdisplayactivate event if the page that listens for it is invisible

BUG= 669190 

Review-Url: https://codereview.chromium.org/2539763004
Cr-Commit-Position: refs/heads/master@{#435500}
(cherry picked from commit af675fa58d6a3557a6704a9faeac8012dc360209)

Review URL: https://codereview.chromium.org/2540233005 .

Cr-Commit-Position: refs/branch-heads/2924@{#258}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/4d33ff01c14f51fe6325f8033e002bd4b7e3a9a7/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApi.java
[modify] https://crrev.com/4d33ff01c14f51fe6325f8033e002bd4b7e3a9a7/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java
[modify] https://crrev.com/4d33ff01c14f51fe6325f8033e002bd4b7e3a9a7/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/4d33ff01c14f51fe6325f8033e002bd4b7e3a9a7/third_party/WebKit/Source/modules/vr/NavigatorVR.cpp
[modify] https://crrev.com/4d33ff01c14f51fe6325f8033e002bd4b7e3a9a7/third_party/WebKit/Source/modules/vr/NavigatorVR.h

Comment 9 by sko...@chromium.org, Dec 1 2016

Status: Fixed (was: Started)
Biao please re-open if needed but it seems like this is now fixed.
►

Sign in to add a comment