Omnibox Suggestion dropdown obscured by nav bar
Reported by
xachinsh...@gmail.com,
Nov 28 2016
|
|||||||
Issue descriptionDevice name: Nexus 6P, Pixel XL From "Settings > About Chrome" Application version: 54.0.2840.85 Operating system: Android 7.1.0 URLs (if applicable): m.facebook.com Steps to reproduce: (1) Open Chrome, go to facebook.com and wait for page to load (2) Rotate the device 180deg clockwise (nav bar should be on the left) (3) Tap the omnibar to get a Suggestions dropdown. You may have to type something. Expected result: The Suggestions dropdown should not be obscured by the nav bar Actual result: The Suggestions dropdown *is* obscured by the nav bar. Please see screenshot attached.
,
Nov 28 2016
Correction in Steps to reproduce: (2) Rotate the device 90deg clockwise (nav bar should be on the left)
,
Dec 14 2016
,
Dec 16 2016
Can someone on test verify this issue with this hardware and/or Android version? I don't have an appropriate device. (It does not reproduce on my Nexus 7 running Android 6.0.1.)
,
Jan 6 2017
mpearson@ Can reproduce this issue on latest 55.0.2883.91 Tested on Pixel and Pixel XL on N Build.
,
Jan 6 2017
Over to Ted for triage of this Android N + omnibox (with theme) + landscape issue.
,
May 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0fd363129a9a01abe8954eb9b23beadaf6ea984 commit c0fd363129a9a01abe8954eb9b23beadaf6ea984 Author: tedchoc <tedchoc@chromium.org> Date: Mon May 01 22:47:25 2017 Fix omnibox suggestions being overdrawn with the nav bar. getLocationInWindow adjusts for the Android nav bar, while the positioning of the parent is exclusive of the nav bar. This causes the suggestions be too bar left aligned and cut off. Only visible if you have the nav bar aligned with the start of the text (i.e. on the left with LTR text). BUG= 669150 Review-Url: https://codereview.chromium.org/2849283002 Cr-Commit-Position: refs/heads/master@{#468466} [modify] https://crrev.com/c0fd363129a9a01abe8954eb9b23beadaf6ea984/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java
,
May 2 2017
,
May 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50e675c553115af32441ed00149935ff604fa71e commit 50e675c553115af32441ed00149935ff604fa71e Author: dfalcantara <dfalcantara@chromium.org> Date: Tue May 02 05:30:01 2017 Revert of Fix omnibox suggestions being overdrawn with the nav bar. (patchset #1 id:1 of https://codereview.chromium.org/2849283002/ ) Reason for revert: Caused https://bugs.chromium.org/p/chromium/issues/detail?id=717395 Got the go ahead to revert over email. Will continue investigating what's going on in the bug as a follow up. Original issue's description: > Fix omnibox suggestions being overdrawn with the nav bar. > > getLocationInWindow adjusts for the Android nav bar, while the > positioning of the parent is exclusive of the nav bar. This causes > the suggestions be too bar left aligned and cut off. > > Only visible if you have the nav bar aligned with the start of > the text (i.e. on the left with LTR text). > > BUG= 669150 > > Review-Url: https://codereview.chromium.org/2849283002 > Cr-Commit-Position: refs/heads/master@{#468466} > Committed: https://chromium.googlesource.com/chromium/src/+/c0fd363129a9a01abe8954eb9b23beadaf6ea984 TBR=mdjones@chromium.org,tedchoc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 669150 Review-Url: https://codereview.chromium.org/2853993002 Cr-Commit-Position: refs/heads/master@{#468567} [modify] https://crrev.com/50e675c553115af32441ed00149935ff604fa71e/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java
,
May 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d7778bec90aef27109d62a3455fd004fd1d7592 commit 3d7778bec90aef27109d62a3455fd004fd1d7592 Author: tedchoc <tedchoc@chromium.org> Date: Wed May 03 23:09:25 2017 Revert "Revert of Fix omnibox suggestions being overdrawn with the nav bar. (patchset #1 id:1 of https://codereview.chromium.org/2849283002/ )" This reverts commit 50e675c553115af32441ed00149935ff604fa71e. findViewById(android.R.id.content) can return null if called early enough. BUG= 669150 Review-Url: https://codereview.chromium.org/2856943002 Cr-Commit-Position: refs/heads/master@{#469186} [modify] https://crrev.com/3d7778bec90aef27109d62a3455fd004fd1d7592/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java [modify] https://crrev.com/3d7778bec90aef27109d62a3455fd004fd1d7592/chrome/android/java/src/org/chromium/chrome/browser/util/ViewUtils.java
,
May 11 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by xachinsh...@gmail.com
, Nov 28 2016