New issue
Advanced search Search tips

Issue 669134 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Deprecate line breaks attribute

Project Member Reported by dtseng@chromium.org, Nov 28 2016

Issue description

This bug tracks deprecation of the line breaks attribute.
 

Comment 1 by dtseng@chromium.org, Nov 29 2016

Labels: M-56 Merge-Request-56

Comment 2 by dimu@chromium.org, Nov 29 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 30 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f80b428935374e97a06c9ffb53616ffa1054bc5

commit 0f80b428935374e97a06c9ffb53616ffa1054bc5
Author: David Tseng <dtseng@chromium.org>
Date: Wed Nov 30 23:00:12 2016

Merge to m56: Re-add the line break attribute

This cl restores the line break attribute as it was calculated in the past. Once we implement something based on the AX-tree that covers all bases, this can be safely removed.

TEST=chromevox_tests; manually over various examples
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2526073003
Cr-Commit-Position: refs/heads/master@{#434747}
(cherry picked from commit 7823f3cdcb5cdc467d8362673e205bac71953320)

BUG= 669134 
TBR=dtseng@chromium.org

Review URL: https://codereview.chromium.org/2532953010 .

Cr-Commit-Position: refs/branch-heads/2924@{#220}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/0f80b428935374e97a06c9ffb53616ffa1054bc5/chrome/browser/resources/chromeos/chromevox/common/chrome_extension_externs.js
[modify] https://crrev.com/0f80b428935374e97a06c9ffb53616ffa1054bc5/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js
[modify] https://crrev.com/0f80b428935374e97a06c9ffb53616ffa1054bc5/chrome/renderer/resources/extensions/automation/automation_node.js
[modify] https://crrev.com/0f80b428935374e97a06c9ffb53616ffa1054bc5/content/renderer/accessibility/blink_ax_tree_source.cc
[modify] https://crrev.com/0f80b428935374e97a06c9ffb53616ffa1054bc5/ui/accessibility/ax_enums.idl
[modify] https://crrev.com/0f80b428935374e97a06c9ffb53616ffa1054bc5/ui/accessibility/ax_node_data.cc
[modify] https://crrev.com/0f80b428935374e97a06c9ffb53616ffa1054bc5/ui/accessibility/ax_tree_combiner.cc

Labels: NewComponent-Accessibility-ChromeVox NewComponent-Accessibility
Components: UI>Accessibility>ChromeVox
Labels: -newcomponent-accessibility -newcomponent-accessibility-chromevox
Components: -UI>Accessibility
Owner: ----
Status: available (was: Assigned)
Project Member

Comment 8 by sheriffbot@chromium.org, Aug 8

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: OS-Chrome
Labels: -M-56
NextAction: ----
Status: Available (was: Untriaged)
Status: Fixed (was: Available)

Sign in to add a comment