Issue metadata
Sign in to add a comment
|
Deprecate line breaks attribute |
||||||||||||||||||||||||
Issue descriptionThis bug tracks deprecation of the line breaks attribute.
,
Nov 29 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Nov 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f80b428935374e97a06c9ffb53616ffa1054bc5 commit 0f80b428935374e97a06c9ffb53616ffa1054bc5 Author: David Tseng <dtseng@chromium.org> Date: Wed Nov 30 23:00:12 2016 Merge to m56: Re-add the line break attribute This cl restores the line break attribute as it was calculated in the past. Once we implement something based on the AX-tree that covers all bases, this can be safely removed. TEST=chromevox_tests; manually over various examples CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2526073003 Cr-Commit-Position: refs/heads/master@{#434747} (cherry picked from commit 7823f3cdcb5cdc467d8362673e205bac71953320) BUG= 669134 TBR=dtseng@chromium.org Review URL: https://codereview.chromium.org/2532953010 . Cr-Commit-Position: refs/branch-heads/2924@{#220} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/0f80b428935374e97a06c9ffb53616ffa1054bc5/chrome/browser/resources/chromeos/chromevox/common/chrome_extension_externs.js [modify] https://crrev.com/0f80b428935374e97a06c9ffb53616ffa1054bc5/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js [modify] https://crrev.com/0f80b428935374e97a06c9ffb53616ffa1054bc5/chrome/renderer/resources/extensions/automation/automation_node.js [modify] https://crrev.com/0f80b428935374e97a06c9ffb53616ffa1054bc5/content/renderer/accessibility/blink_ax_tree_source.cc [modify] https://crrev.com/0f80b428935374e97a06c9ffb53616ffa1054bc5/ui/accessibility/ax_enums.idl [modify] https://crrev.com/0f80b428935374e97a06c9ffb53616ffa1054bc5/ui/accessibility/ax_node_data.cc [modify] https://crrev.com/0f80b428935374e97a06c9ffb53616ffa1054bc5/ui/accessibility/ax_tree_combiner.cc
,
Mar 27 2017
,
Apr 21 2017
,
Apr 21 2017
,
Aug 7 2017
,
Aug 8
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 30
,
Sep 7
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b35eaaf25eec1212bdd8ba5432ae01414c1720c commit 0b35eaaf25eec1212bdd8ba5432ae01414c1720c Author: David Tseng <dtseng@chromium.org> Date: Fri Sep 07 22:31:54 2018 Remove unused lineBreaks attribute TBR=dcheng@chromium.org Bug: 669134 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I91a10a1f39a1a353ace08d54611f6daec35ea1de Reviewed-on: https://chromium-review.googlesource.com/1213879 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#589691} [modify] https://crrev.com/0b35eaaf25eec1212bdd8ba5432ae01414c1720c/chrome/common/extensions/api/automation.idl [modify] https://crrev.com/0b35eaaf25eec1212bdd8ba5432ae01414c1720c/third_party/closure_compiler/externs/automation.js [modify] https://crrev.com/0b35eaaf25eec1212bdd8ba5432ae01414c1720c/ui/accessibility/ax_enum_util.cc [modify] https://crrev.com/0b35eaaf25eec1212bdd8ba5432ae01414c1720c/ui/accessibility/ax_enums.mojom [modify] https://crrev.com/0b35eaaf25eec1212bdd8ba5432ae01414c1720c/ui/accessibility/ax_node_data.cc
,
Sep 7
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dtseng@chromium.org
, Nov 29 2016