OfflinePageUtils::EqualsIgnoringFormat always returns true |
||||||||||
Issue descriptionOfflinePageUtils::EqualsIgnoringFormat always returns true This is implementation bug supported by lack of testing.
,
Nov 29 2016
,
Nov 29 2016
,
Nov 29 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Nov 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/592f55d1bede6776541f664bfe3298ece1bf380a commit 592f55d1bede6776541f664bfe3298ece1bf380a Author: Filip Gorski <fgorski@chromium.org> Date: Tue Nov 29 22:27:08 2016 [Offline pages] Fixing OfflinePageUtis::EqualsIgnoringFragment * Adding a test and fixing the issue BUG= 669126 Review-Url: https://codereview.chromium.org/2535023002 Cr-Commit-Position: refs/heads/master@{#434811} (cherry picked from commit 1acc2c4283c64636eb2a120f3e1e51267f74a427) Review URL: https://codereview.chromium.org/2537763003 . Cr-Commit-Position: refs/branch-heads/2924@{#169} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/592f55d1bede6776541f664bfe3298ece1bf380a/chrome/browser/android/offline_pages/offline_page_utils.cc [modify] https://crrev.com/592f55d1bede6776541f664bfe3298ece1bf380a/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc [modify] https://crrev.com/592f55d1bede6776541f664bfe3298ece1bf380a/chrome/browser/previews/previews_infobar_tab_helper_unittest.cc
,
Nov 29 2016
Unfortunately I just discovered that his affects M55. Change is small and well tested and low risk therefore requesting a merge.
,
Nov 29 2016
[Automated comment] Less than 2 weeks to go before stable on M55, manual review required.
,
Nov 29 2016
Pri 1 as this can lead to the wrong content being saved. Merge approved for M55 branch 2883.
,
Nov 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98729734658f98e96eb03d83452e088e9e2d8bd8 commit 98729734658f98e96eb03d83452e088e9e2d8bd8 Author: Jian Li <jianli@chromium.org> Date: Wed Nov 30 00:24:11 2016 [Offline pages] Fixing OfflinePageUtis::EqualsIgnoringFragment * Adding a test and fixing the issue BUG= 669126 Review-Url: https://codereview.chromium.org/2535023002 Cr-Commit-Position: refs/heads/master@{#434811} (cherry picked from commit 1acc2c4283c64636eb2a120f3e1e51267f74a427) Review URL: https://codereview.chromium.org/2542503002 . Cr-Commit-Position: refs/branch-heads/2883@{#686} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/98729734658f98e96eb03d83452e088e9e2d8bd8/chrome/browser/android/offline_pages/offline_page_utils.cc [modify] https://crrev.com/98729734658f98e96eb03d83452e088e9e2d8bd8/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc [modify] https://crrev.com/98729734658f98e96eb03d83452e088e9e2d8bd8/chrome/browser/previews/previews_infobar_tab_helper_unittest.cc
,
Nov 30 2016
Merged to M55 and M56, so marking as fixed. Please reopen if more work remains. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by bugdroid1@chromium.org
, Nov 29 2016