When using WebRTC protocol chromoting host always sends at 600kbps |
|
Issue descriptionWebrtcTransport passes min/max bitrate parameters to WebRTC by modifying remote session description, see https://codesearch.chromium.org/chromium/src/remoting/protocol/webrtc_transport.cc?rcl=0&l=367 . Problem is that it assumes that VP8 always gets payload type 100. This is an invalid assumption and it was broken in recent builds. As result the host no longer sets max-bitrate, and the default value is being used. The default is 600kbps, which is way to low for usable connection.
,
Nov 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ac2609ef72f7cdc66b76e9ad1ba351e25393623 commit 1ac2609ef72f7cdc66b76e9ad1ba351e25393623 Author: sergeyu <sergeyu@chromium.org> Date: Tue Nov 29 01:08:12 2016 Add SdpMessage for more reliable codec configuration in WebrtcTransport. Previously codec configuration was done in WebrtcTransport by string substitutions. It worked properly only as long as rtp payload type values do not change. Added SdpHelper that allows to implement this logic more reliably, without dependency on payload type values. BUG= 669121 Review-Url: https://codereview.chromium.org/2536623003 Cr-Commit-Position: refs/heads/master@{#434809} [modify] https://crrev.com/1ac2609ef72f7cdc66b76e9ad1ba351e25393623/remoting/protocol/BUILD.gn [add] https://crrev.com/1ac2609ef72f7cdc66b76e9ad1ba351e25393623/remoting/protocol/sdp_message.cc [add] https://crrev.com/1ac2609ef72f7cdc66b76e9ad1ba351e25393623/remoting/protocol/sdp_message.h [add] https://crrev.com/1ac2609ef72f7cdc66b76e9ad1ba351e25393623/remoting/protocol/sdp_message_unittest.cc [modify] https://crrev.com/1ac2609ef72f7cdc66b76e9ad1ba351e25393623/remoting/protocol/webrtc_transport.cc |
|
►
Sign in to add a comment |
|
Comment 1 by sergeyu@chromium.org
, Nov 29 2016