Fix Android mouse-click that relies on ACTION_DOWN/UP |
||||
Issue descriptionWe recently changed the plumbing of mouse events in Android ( Issue 468806 ) in which, among other things, we hooked up mousedown/up firing to MotionEvents with action=ACTION_BUTTON_PRESS/RELEASE (used to be ACTION_DOWN/UP). This caused a test failure (Issue 665182) recently because the test was simulating a mouse click though ACTION_DOWN/UP. Other mouse-click related things may need to be fixed. A quick look into code-search result suggested these, need to dig into them to confirm: SimulatedTouchInputStrategy.onMotionEvent() OverlayPanelEventFilter TextViewWithClickableSpans OverlayPanelEventFilterTest.simulateActionUpEvent() LayoutManager
,
Feb 1 2017
,
Feb 22 2017
,
Feb 22 2017
The test failure (Issue 665182) was shown unrelated. Upon further investigation into this bug, it turns out that the suspected code blocks (mentioned above) are on the Java side Chrome event path but the mouse event change affects only the C++ side of Chrome. So no worries on the Java side. On the C++ side, only mouse events are affected and in this case, ACTION_BUTTON_PRESS/RELEASE are "translated" ACTION_DOWN/UP so the change should be transparent to the C++ side. Closing this bug, will reopen if we see some problem with ACTION_UP vs ACTION_BUTTON_RELEASE etc. |
||||
►
Sign in to add a comment |
||||
Comment 1 by dtapu...@chromium.org
, Jan 6 2017