New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 669108 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature


Sign in to add a comment

Instrument Memory Usage in net/

Project Member Reported by xunji...@chromium.org, Nov 28 2016

Issue description

Instrument memory usage in net/ and expose usage data via MemoryDumpProvider.

Design doc:
https://docs.google.com/document/d/1zBX27tvkc8ZJHp9yvm6EQJrMDIhDCU92YlahaGFwsyc/edit


 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96ab36a707e8e8633ec92185bd3f41a5157af83b

commit 96ab36a707e8e8633ec92185bd3f41a5157af83b
Author: xunjieli <xunjieli@chromium.org>
Date: Mon Dec 05 21:36:05 2016

Make net::URLRequestContext a MemoryDumpProvider

This CL makes net::URLRequestContext a MemoryDumpProvider.
The design doc is linked in the crbug.

BUG= 669108 

Review-Url: https://codereview.chromium.org/2536723009
Cr-Commit-Position: refs/heads/master@{#436417}

[modify] https://crrev.com/96ab36a707e8e8633ec92185bd3f41a5157af83b/chrome/browser/io_thread.cc
[modify] https://crrev.com/96ab36a707e8e8633ec92185bd3f41a5157af83b/chrome/browser/profiles/off_the_record_profile_io_data.cc
[modify] https://crrev.com/96ab36a707e8e8633ec92185bd3f41a5157af83b/chrome/browser/profiles/off_the_record_profile_io_data.h
[modify] https://crrev.com/96ab36a707e8e8633ec92185bd3f41a5157af83b/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/96ab36a707e8e8633ec92185bd3f41a5157af83b/chrome/browser/profiles/profile_impl_io_data.h
[modify] https://crrev.com/96ab36a707e8e8633ec92185bd3f41a5157af83b/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/96ab36a707e8e8633ec92185bd3f41a5157af83b/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/96ab36a707e8e8633ec92185bd3f41a5157af83b/chrome/browser/safe_browsing/safe_browsing_service.cc
[modify] https://crrev.com/96ab36a707e8e8633ec92185bd3f41a5157af83b/chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc
[modify] https://crrev.com/96ab36a707e8e8633ec92185bd3f41a5157af83b/content/browser/appcache/appcache_request_handler_unittest.cc
[modify] https://crrev.com/96ab36a707e8e8633ec92185bd3f41a5157af83b/net/net.gypi
[modify] https://crrev.com/96ab36a707e8e8633ec92185bd3f41a5157af83b/net/url_request/url_request_context.cc
[modify] https://crrev.com/96ab36a707e8e8633ec92185bd3f41a5157af83b/net/url_request/url_request_context.h
[add] https://crrev.com/96ab36a707e8e8633ec92185bd3f41a5157af83b/net/url_request/url_request_context_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f8c5fb56da88f719d36423e58e8f9f89b32d542

commit 9f8c5fb56da88f719d36423e58e8f9f89b32d542
Author: xunjieli <xunjieli@chromium.org>
Date: Wed Dec 07 22:59:33 2016

Instrument SSL sockets using MemoryDumpProvider

This CL instruments SSL sockets and SSL session cache using
MemoryDumpProvider. Design doc is linked in the crbug.

BUG= 669108 

Review-Url: https://codereview.chromium.org/2541093003
Cr-Commit-Position: refs/heads/master@{#437097}

[modify] https://crrev.com/9f8c5fb56da88f719d36423e58e8f9f89b32d542/net/http/http_network_session.cc
[modify] https://crrev.com/9f8c5fb56da88f719d36423e58e8f9f89b32d542/net/http/http_network_session.h
[modify] https://crrev.com/9f8c5fb56da88f719d36423e58e8f9f89b32d542/net/socket/client_socket_pool_base.cc
[modify] https://crrev.com/9f8c5fb56da88f719d36423e58e8f9f89b32d542/net/socket/client_socket_pool_base.h
[modify] https://crrev.com/9f8c5fb56da88f719d36423e58e8f9f89b32d542/net/socket/client_socket_pool_manager.cc
[modify] https://crrev.com/9f8c5fb56da88f719d36423e58e8f9f89b32d542/net/socket/client_socket_pool_manager.h
[modify] https://crrev.com/9f8c5fb56da88f719d36423e58e8f9f89b32d542/net/socket/client_socket_pool_manager_impl.cc
[modify] https://crrev.com/9f8c5fb56da88f719d36423e58e8f9f89b32d542/net/socket/client_socket_pool_manager_impl.h
[modify] https://crrev.com/9f8c5fb56da88f719d36423e58e8f9f89b32d542/net/socket/mock_client_socket_pool_manager.cc
[modify] https://crrev.com/9f8c5fb56da88f719d36423e58e8f9f89b32d542/net/socket/mock_client_socket_pool_manager.h
[modify] https://crrev.com/9f8c5fb56da88f719d36423e58e8f9f89b32d542/net/socket/socket_bio_adapter.cc
[modify] https://crrev.com/9f8c5fb56da88f719d36423e58e8f9f89b32d542/net/socket/socket_bio_adapter.h
[modify] https://crrev.com/9f8c5fb56da88f719d36423e58e8f9f89b32d542/net/socket/ssl_client_socket_impl.cc
[modify] https://crrev.com/9f8c5fb56da88f719d36423e58e8f9f89b32d542/net/socket/ssl_client_socket_impl.h
[modify] https://crrev.com/9f8c5fb56da88f719d36423e58e8f9f89b32d542/net/socket/ssl_client_socket_pool.cc
[modify] https://crrev.com/9f8c5fb56da88f719d36423e58e8f9f89b32d542/net/socket/ssl_client_socket_pool.h
[modify] https://crrev.com/9f8c5fb56da88f719d36423e58e8f9f89b32d542/net/socket/ssl_client_socket_unittest.cc
[modify] https://crrev.com/9f8c5fb56da88f719d36423e58e8f9f89b32d542/net/socket/stream_socket.h
[modify] https://crrev.com/9f8c5fb56da88f719d36423e58e8f9f89b32d542/net/ssl/ssl_client_session_cache.cc
[modify] https://crrev.com/9f8c5fb56da88f719d36423e58e8f9f89b32d542/net/ssl/ssl_client_session_cache.h
[modify] https://crrev.com/9f8c5fb56da88f719d36423e58e8f9f89b32d542/net/ssl/ssl_client_session_cache_unittest.cc
[modify] https://crrev.com/9f8c5fb56da88f719d36423e58e8f9f89b32d542/net/url_request/url_request_context.cc
[modify] https://crrev.com/9f8c5fb56da88f719d36423e58e8f9f89b32d542/net/url_request/url_request_context_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1ad361c2c8bbbec167005dd074959658b889ed2

commit e1ad361c2c8bbbec167005dd074959658b889ed2
Author: xunjieli <xunjieli@chromium.org>
Date: Thu Dec 08 17:52:09 2016

Fix a typo in SSLClientSocketTest.DumpMemoryStats

Fix a typo in SSLClientSocketTest.DumpMemoryStats

DumpMemoryStats test is returning early when it should continue.

TBR=davidben@chromium.org

BUG= 669108 

Review-Url: https://codereview.chromium.org/2558963004
Cr-Commit-Position: refs/heads/master@{#437279}

[modify] https://crrev.com/e1ad361c2c8bbbec167005dd074959658b889ed2/net/socket/ssl_client_socket_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c8373a83964c182d3cab8ca42a22d8493d3931c

commit 3c8373a83964c182d3cab8ca42a22d8493d3931c
Author: xunjieli <xunjieli@chromium.org>
Date: Tue Dec 13 01:49:37 2016

Do not create sub MemoryAllocatorDumps in SSLClientSessionCache

SSLClientSessionCache::DumpMemoryStats() creates one
MemoryAllocatorDump for each cache entry. To make the memory dump lighter,
this CL dumps the total size and count and does not create sub dumps.

BUG= 669108 

Review-Url: https://codereview.chromium.org/2574513002
Cr-Commit-Position: refs/heads/master@{#437981}

[modify] https://crrev.com/3c8373a83964c182d3cab8ca42a22d8493d3931c/net/ssl/ssl_client_session_cache.cc
[modify] https://crrev.com/3c8373a83964c182d3cab8ca42a22d8493d3931c/net/ssl/ssl_client_session_cache_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a2468bdec640adaa6a08f9ca1cfe465e56e7600

commit 2a2468bdec640adaa6a08f9ca1cfe465e56e7600
Author: xunjieli <xunjieli@chromium.org>
Date: Wed Jan 04 21:17:33 2017

This CL creates an empty MemoryAllocatorDump under URLRequestContext
so AddOwnershipEdge can attribute memory correctly between
URLRequestContexts. See the following doc for more details on why it
is needed.

https://docs.google.com/document/d/1-dmr_dVgO090Y5_3K9itjsE0MsBTmbqwovu6lup1i14/edit

BUG= 669108 

Review-Url: https://codereview.chromium.org/2560593002
Cr-Commit-Position: refs/heads/master@{#441466}

[modify] https://crrev.com/2a2468bdec640adaa6a08f9ca1cfe465e56e7600/net/http/http_network_session.cc
[modify] https://crrev.com/2a2468bdec640adaa6a08f9ca1cfe465e56e7600/net/url_request/url_request_context_unittest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d701b6e5acd6f6f5c01224ebb1c42844773d7be2

commit d701b6e5acd6f6f5c01224ebb1c42844773d7be2
Author: xunjieli <xunjieli@chromium.org>
Date: Wed Jan 04 22:17:42 2017

Instrument SdchManager using MemoryDumpProvider

This CL instruments SdchManager using MemoryDumpProvider.
Even though SDCH might be unshipped (see blink-dev),
it is useful to get an idea of how much memory dictionaries
cost.

BUG= 669108 

Review-Url: https://codereview.chromium.org/2541073003
Cr-Commit-Position: refs/heads/master@{#441485}

[modify] https://crrev.com/d701b6e5acd6f6f5c01224ebb1c42844773d7be2/net/base/sdch_manager.cc
[modify] https://crrev.com/d701b6e5acd6f6f5c01224ebb1c42844773d7be2/net/base/sdch_manager.h
[modify] https://crrev.com/d701b6e5acd6f6f5c01224ebb1c42844773d7be2/net/base/sdch_manager_unittest.cc
[modify] https://crrev.com/d701b6e5acd6f6f5c01224ebb1c42844773d7be2/net/url_request/url_request_context.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/998d24774d5062f8d032fedbe8870b23ad16c519

commit 998d24774d5062f8d032fedbe8870b23ad16c519
Author: xunjieli <xunjieli@chromium.org>
Date: Thu Jan 12 01:12:28 2017

Avoid creating MemoryAllocatorDump for individual sockets

This CL creates a StreamSocket::SocketMemoryStats to hold relevant
socket information so that we can avoid creating individual
MemoryAllocatorDump for each socket. MemoryAllocatorDump is expensive
to create. This CL makes net/ MemoryDumpProvider create fewer
MemoryAllocatorDump so that it can be enabled in Slow Reports.

BUG= 669108 

Review-Url: https://codereview.chromium.org/2623803002
Cr-Commit-Position: refs/heads/master@{#443103}

[modify] https://crrev.com/998d24774d5062f8d032fedbe8870b23ad16c519/net/socket/client_socket_handle.cc
[modify] https://crrev.com/998d24774d5062f8d032fedbe8870b23ad16c519/net/socket/client_socket_handle.h
[modify] https://crrev.com/998d24774d5062f8d032fedbe8870b23ad16c519/net/socket/client_socket_pool_base.cc
[modify] https://crrev.com/998d24774d5062f8d032fedbe8870b23ad16c519/net/socket/ssl_client_socket_impl.cc
[modify] https://crrev.com/998d24774d5062f8d032fedbe8870b23ad16c519/net/socket/ssl_client_socket_impl.h
[modify] https://crrev.com/998d24774d5062f8d032fedbe8870b23ad16c519/net/socket/ssl_client_socket_unittest.cc
[modify] https://crrev.com/998d24774d5062f8d032fedbe8870b23ad16c519/net/socket/stream_socket.cc
[modify] https://crrev.com/998d24774d5062f8d032fedbe8870b23ad16c519/net/socket/stream_socket.h
[modify] https://crrev.com/998d24774d5062f8d032fedbe8870b23ad16c519/net/spdy/spdy_session.cc
[modify] https://crrev.com/998d24774d5062f8d032fedbe8870b23ad16c519/net/spdy/spdy_session.h
[modify] https://crrev.com/998d24774d5062f8d032fedbe8870b23ad16c519/net/spdy/spdy_session_pool.cc
[modify] https://crrev.com/998d24774d5062f8d032fedbe8870b23ad16c519/net/spdy/spdy_session_pool_unittest.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5267debb22eacffc2287fba55832299ef640bbb

commit f5267debb22eacffc2287fba55832299ef640bbb
Author: xunjieli <xunjieli@chromium.org>
Date: Fri Jan 20 21:18:57 2017

Log states of JobController in Net MemoryDumpProvider

This CL logs states of JobController in network stack's
MemoryDumpProvider.
This will allow us to see how many pending Jobs there are at a given
time, and whether there's anything out of ordinary.

The following information will be reported to MDP.

(0) Estimated size of all JobControllers in
    HttpStreamFactoryImpl::job_controller_set_.
(1) How many JobControllers there are.
(2) How many preconnect JobControllers there are.
(3) How many non-preconnect JobControllers exist because of a pending Alt Job.
(4) How many non-preconnect JobControllers exist because of a pending Main Job.

[Union of 3 and 4] and [2] are disjoint. Together they sum up to [1].

BUG= 669108 

Review-Url: https://codereview.chromium.org/2623383005
Cr-Commit-Position: refs/heads/master@{#445165}

[modify] https://crrev.com/f5267debb22eacffc2287fba55832299ef640bbb/net/http/http_network_session.cc
[modify] https://crrev.com/f5267debb22eacffc2287fba55832299ef640bbb/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/f5267debb22eacffc2287fba55832299ef640bbb/net/http/http_stream_factory.h
[modify] https://crrev.com/f5267debb22eacffc2287fba55832299ef640bbb/net/http/http_stream_factory_impl.cc
[modify] https://crrev.com/f5267debb22eacffc2287fba55832299ef640bbb/net/http/http_stream_factory_impl.h
[modify] https://crrev.com/f5267debb22eacffc2287fba55832299ef640bbb/net/http/http_stream_factory_impl_job.cc
[modify] https://crrev.com/f5267debb22eacffc2287fba55832299ef640bbb/net/http/http_stream_factory_impl_job.h
[modify] https://crrev.com/f5267debb22eacffc2287fba55832299ef640bbb/net/http/http_stream_factory_impl_job_controller.cc
[modify] https://crrev.com/f5267debb22eacffc2287fba55832299ef640bbb/net/http/http_stream_factory_impl_job_controller.h
[modify] https://crrev.com/f5267debb22eacffc2287fba55832299ef640bbb/net/socket/client_socket_handle.cc

Comment 10 by ssid@chromium.org, Jan 20 2017

Cc: ssid@chromium.org
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8397c08b01935f854e527ba42c9563ba852f1981

commit 8397c08b01935f854e527ba42c9563ba852f1981
Author: xunjieli <xunjieli@chromium.org>
Date: Fri Jan 20 23:13:59 2017

Skip creating spdy_session_pool dump if pool is empty in MemoryDumpProvider

This CL skips creating a MemoryAllocatorDump for spdy_session_pool if the
pool is empty.

R=ssid@chromium.org

BUG=677346, 669108 

Review-Url: https://codereview.chromium.org/2639403005
Cr-Commit-Position: refs/heads/master@{#445203}

[modify] https://crrev.com/8397c08b01935f854e527ba42c9563ba852f1981/net/spdy/spdy_session_pool.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Jan 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69720dd78be79fe965b684ef4a753e3947d20317

commit 69720dd78be79fe965b684ef4a753e3947d20317
Author: xunjieli <xunjieli@chromium.org>
Date: Mon Jan 30 15:36:29 2017

Track QuicChromiumClientSession in net/ MemoryDumpProvider

This CL tracks the number of QuicChromiumClientSession in net/
MemoryDumpProvider. Follow-up CLs will improve the coverage of the memory
usage estimate.

BUG= 669108 

Review-Url: https://codereview.chromium.org/2650943007
Cr-Commit-Position: refs/heads/master@{#446986}

[modify] https://crrev.com/69720dd78be79fe965b684ef4a753e3947d20317/net/base/host_port_pair.cc
[modify] https://crrev.com/69720dd78be79fe965b684ef4a753e3947d20317/net/base/host_port_pair.h
[modify] https://crrev.com/69720dd78be79fe965b684ef4a753e3947d20317/net/http/http_network_session.cc
[modify] https://crrev.com/69720dd78be79fe965b684ef4a753e3947d20317/net/quic/chromium/quic_chromium_client_session.cc
[modify] https://crrev.com/69720dd78be79fe965b684ef4a753e3947d20317/net/quic/chromium/quic_chromium_client_session.h
[modify] https://crrev.com/69720dd78be79fe965b684ef4a753e3947d20317/net/quic/chromium/quic_chromium_packet_reader.cc
[modify] https://crrev.com/69720dd78be79fe965b684ef4a753e3947d20317/net/quic/chromium/quic_chromium_packet_reader.h
[modify] https://crrev.com/69720dd78be79fe965b684ef4a753e3947d20317/net/quic/chromium/quic_stream_factory.cc
[modify] https://crrev.com/69720dd78be79fe965b684ef4a753e3947d20317/net/quic/chromium/quic_stream_factory.h

Labels: -M-57 M-58
Blockedon: 688139
Blockedon: 688142
Blockedon: 688143
Blockedon: 688144
Blockedon: 688145
Project Member

Comment 19 by bugdroid1@chromium.org, Feb 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d7f2c60c1decab6a6dd8a1a4dfaf70d9a5e3e24

commit 3d7f2c60c1decab6a6dd8a1a4dfaf70d9a5e3e24
Author: dskiba <dskiba@chromium.org>
Date: Sat Feb 04 06:33:05 2017

[memory-infra] Add EstimateMemoryUsage() for deque and friends.

This CL implements EstimateMemoryUsage() for std::deque, std::queue,
std::priority_queue and std::stack (because it's a container adapter
similar to std::queue).

BUG= 669108 

Review-Url: https://codereview.chromium.org/2676043002
Cr-Commit-Position: refs/heads/master@{#448156}

[modify] https://crrev.com/3d7f2c60c1decab6a6dd8a1a4dfaf70d9a5e3e24/base/trace_event/memory_usage_estimator.h
[modify] https://crrev.com/3d7f2c60c1decab6a6dd8a1a4dfaf70d9a5e3e24/base/trace_event/memory_usage_estimator_unittest.cc

Blockedon: 690015
Project Member

Comment 21 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec84e4ea604deb4d6cca4b72ce6f97babf99878b

commit ec84e4ea604deb4d6cca4b72ce6f97babf99878b
Author: xunjieli <xunjieli@chromium.org>
Date: Thu Feb 09 22:04:15 2017

Improve memory estimate of SpdySessionPool in net/ MemoryDumpProvider.

This CL instruments other objects (e.g. buffers, queues, strings)
referenced from SpdySessionPool and SpdySession. The goal is
to make the memory estimate reported by
SpdySessionPool::DumpMemoryStats() cover more parts of the code.

However, there are still a couple of TODOs because
base/trace_event/memory_usage_estimator.h doesn't yet support
linked_hash_map, scoped_refptr and WeakPtr.

BUG= 669108 

Review-Url: https://codereview.chromium.org/2665283003
Cr-Commit-Position: refs/heads/master@{#449431}

[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/base/host_port_pair.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/base/host_port_pair.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/http2/hpack/decoder/hpack_decoder_string_buffer.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/http2/hpack/decoder/hpack_decoder_string_buffer.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/http2/hpack/decoder/hpack_whole_entry_buffer.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/http2/hpack/decoder/hpack_whole_entry_buffer.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/http2/hpack/decoder/http2_hpack_decoder.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/http2/hpack/decoder/http2_hpack_decoder.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/proxy/proxy_server.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/proxy/proxy_server.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/quic/chromium/quic_stream_factory.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/buffered_spdy_framer.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/buffered_spdy_framer.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/header_coalescer.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/header_coalescer.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/hpack/hpack_decoder.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/hpack/hpack_decoder.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/hpack/hpack_decoder2.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/hpack/hpack_decoder2.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/hpack/hpack_decoder3.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/hpack/hpack_decoder3.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/hpack/hpack_decoder_interface.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/hpack/hpack_encoder.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/hpack/hpack_encoder.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/hpack/hpack_huffman_table.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/hpack/hpack_huffman_table.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/hpack/hpack_output_stream.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/hpack/hpack_output_stream.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/hpack/hpack_static_table.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/hpack/hpack_static_table.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/http2_frame_decoder_adapter.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/http2_priority_dependencies.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/http2_priority_dependencies.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_buffer.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_buffer.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_buffer_producer.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_buffer_producer.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_framer.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_framer.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_framer_decoder_adapter.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_framer_decoder_adapter.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_header_block.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_header_block.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_protocol.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_session.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_session.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_session_key.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_session_key.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_session_pool.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_stream.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_stream.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_write_queue.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_write_queue.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_write_queue_unittest.cc

Project Member

Comment 22 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec84e4ea604deb4d6cca4b72ce6f97babf99878b

commit ec84e4ea604deb4d6cca4b72ce6f97babf99878b
Author: xunjieli <xunjieli@chromium.org>
Date: Thu Feb 09 22:04:15 2017

Improve memory estimate of SpdySessionPool in net/ MemoryDumpProvider.

This CL instruments other objects (e.g. buffers, queues, strings)
referenced from SpdySessionPool and SpdySession. The goal is
to make the memory estimate reported by
SpdySessionPool::DumpMemoryStats() cover more parts of the code.

However, there are still a couple of TODOs because
base/trace_event/memory_usage_estimator.h doesn't yet support
linked_hash_map, scoped_refptr and WeakPtr.

BUG= 669108 

Review-Url: https://codereview.chromium.org/2665283003
Cr-Commit-Position: refs/heads/master@{#449431}

[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/base/host_port_pair.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/base/host_port_pair.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/http2/hpack/decoder/hpack_decoder_string_buffer.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/http2/hpack/decoder/hpack_decoder_string_buffer.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/http2/hpack/decoder/hpack_whole_entry_buffer.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/http2/hpack/decoder/hpack_whole_entry_buffer.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/http2/hpack/decoder/http2_hpack_decoder.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/http2/hpack/decoder/http2_hpack_decoder.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/proxy/proxy_server.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/proxy/proxy_server.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/quic/chromium/quic_stream_factory.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/buffered_spdy_framer.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/buffered_spdy_framer.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/header_coalescer.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/header_coalescer.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/hpack/hpack_decoder.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/hpack/hpack_decoder.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/hpack/hpack_decoder2.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/hpack/hpack_decoder2.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/hpack/hpack_decoder3.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/hpack/hpack_decoder3.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/hpack/hpack_decoder_interface.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/hpack/hpack_encoder.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/hpack/hpack_encoder.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/hpack/hpack_huffman_table.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/hpack/hpack_huffman_table.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/hpack/hpack_output_stream.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/hpack/hpack_output_stream.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/hpack/hpack_static_table.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/hpack/hpack_static_table.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/http2_frame_decoder_adapter.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/http2_priority_dependencies.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/http2_priority_dependencies.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_buffer.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_buffer.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_buffer_producer.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_buffer_producer.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_framer.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_framer.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_framer_decoder_adapter.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_framer_decoder_adapter.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_header_block.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_header_block.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_protocol.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_session.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_session.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_session_key.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_session_key.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_session_pool.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_stream.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_stream.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_write_queue.cc
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_write_queue.h
[modify] https://crrev.com/ec84e4ea604deb4d6cca4b72ce6f97babf99878b/net/spdy/spdy_write_queue_unittest.cc

Project Member

Comment 24 by bugdroid1@chromium.org, Feb 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0166f483ff1baccd7e2b0a3e8f2956c9ab1b3b6

commit a0166f483ff1baccd7e2b0a3e8f2956c9ab1b3b6
Author: xunjieli <xunjieli@chromium.org>
Date: Thu Feb 23 17:44:57 2017

Track SimpleCache memory usage in net/ MemoryDumpProvider

This CL includes SimpleCache in net/ MemoryDumpProvider.
BlockFile and In-memory cache will be implemented in a
follow-up.

BUG= 669108 

Review-Url: https://codereview.chromium.org/2661333002
Cr-Commit-Position: refs/heads/master@{#452541}

[modify] https://crrev.com/a0166f483ff1baccd7e2b0a3e8f2956c9ab1b3b6/content/browser/cache_storage/cache_storage_cache_unittest.cc
[modify] https://crrev.com/a0166f483ff1baccd7e2b0a3e8f2956c9ab1b3b6/net/disk_cache/backend_unittest.cc
[modify] https://crrev.com/a0166f483ff1baccd7e2b0a3e8f2956c9ab1b3b6/net/disk_cache/blockfile/backend_impl.cc
[modify] https://crrev.com/a0166f483ff1baccd7e2b0a3e8f2956c9ab1b3b6/net/disk_cache/blockfile/backend_impl.h
[modify] https://crrev.com/a0166f483ff1baccd7e2b0a3e8f2956c9ab1b3b6/net/disk_cache/disk_cache.h
[modify] https://crrev.com/a0166f483ff1baccd7e2b0a3e8f2956c9ab1b3b6/net/disk_cache/memory/mem_backend_impl.cc
[modify] https://crrev.com/a0166f483ff1baccd7e2b0a3e8f2956c9ab1b3b6/net/disk_cache/memory/mem_backend_impl.h
[modify] https://crrev.com/a0166f483ff1baccd7e2b0a3e8f2956c9ab1b3b6/net/disk_cache/simple/simple_backend_impl.cc
[modify] https://crrev.com/a0166f483ff1baccd7e2b0a3e8f2956c9ab1b3b6/net/disk_cache/simple/simple_backend_impl.h
[modify] https://crrev.com/a0166f483ff1baccd7e2b0a3e8f2956c9ab1b3b6/net/disk_cache/simple/simple_entry_impl.cc
[modify] https://crrev.com/a0166f483ff1baccd7e2b0a3e8f2956c9ab1b3b6/net/disk_cache/simple/simple_entry_impl.h
[modify] https://crrev.com/a0166f483ff1baccd7e2b0a3e8f2956c9ab1b3b6/net/disk_cache/simple/simple_index.cc
[modify] https://crrev.com/a0166f483ff1baccd7e2b0a3e8f2956c9ab1b3b6/net/disk_cache/simple/simple_index.h
[modify] https://crrev.com/a0166f483ff1baccd7e2b0a3e8f2956c9ab1b3b6/net/http/http_cache.cc
[modify] https://crrev.com/a0166f483ff1baccd7e2b0a3e8f2956c9ab1b3b6/net/http/http_cache.h
[modify] https://crrev.com/a0166f483ff1baccd7e2b0a3e8f2956c9ab1b3b6/net/http/http_cache_transaction.cc
[modify] https://crrev.com/a0166f483ff1baccd7e2b0a3e8f2956c9ab1b3b6/net/http/http_cache_transaction.h
[modify] https://crrev.com/a0166f483ff1baccd7e2b0a3e8f2956c9ab1b3b6/net/http/http_cache_unittest.cc
[modify] https://crrev.com/a0166f483ff1baccd7e2b0a3e8f2956c9ab1b3b6/net/http/mock_http_cache.cc
[modify] https://crrev.com/a0166f483ff1baccd7e2b0a3e8f2956c9ab1b3b6/net/http/mock_http_cache.h
[modify] https://crrev.com/a0166f483ff1baccd7e2b0a3e8f2956c9ab1b3b6/net/url_request/url_request_context.cc

Project Member

Comment 25 by bugdroid1@chromium.org, Feb 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffe62df6448a031aa6449908076d057dd110d562

commit ffe62df6448a031aa6449908076d057dd110d562
Author: xunjieli <xunjieli@chromium.org>
Date: Thu Feb 23 18:22:41 2017

Add a multiplier in tracking certificate memory allocation size

net/ tracks the serialized sizes of a certificates, but the in-memory
representation is much less efficient than that.  crbug.com/671420  is
being worked on to resolve this. Until that is done, estimate the cost
of the in-memory representation with a 4x multiplier.

Note that this CL ignores deduplication/ref-countedness of X509* in
ssl_client_socket_impl.cc. This will overcount memory usage if sockets
share the same certs. Since we allow 6 sockets to the same host, port,
scheme triplet, we can have a fair amount of sharing of certs among
sockets. Therefore, these metrics ("cert_count", "cert_size" and
"undeduped_cert_size") should not be used to make decisions on changing
socket pool behavior.

BUG= 669108 , 671420 

Review-Url: https://codereview.chromium.org/2696403007
Cr-Commit-Position: refs/heads/master@{#452555}

[modify] https://crrev.com/ffe62df6448a031aa6449908076d057dd110d562/net/socket/client_socket_pool_base.cc
[modify] https://crrev.com/ffe62df6448a031aa6449908076d057dd110d562/net/socket/ssl_client_socket_impl.cc
[modify] https://crrev.com/ffe62df6448a031aa6449908076d057dd110d562/net/socket/ssl_client_socket_unittest.cc
[modify] https://crrev.com/ffe62df6448a031aa6449908076d057dd110d562/net/socket/stream_socket.cc
[modify] https://crrev.com/ffe62df6448a031aa6449908076d057dd110d562/net/socket/stream_socket.h
[modify] https://crrev.com/ffe62df6448a031aa6449908076d057dd110d562/net/spdy/spdy_session_pool.cc
[modify] https://crrev.com/ffe62df6448a031aa6449908076d057dd110d562/net/ssl/ssl_client_session_cache.cc
[modify] https://crrev.com/ffe62df6448a031aa6449908076d057dd110d562/net/ssl/ssl_client_session_cache_unittest.cc

Project Member

Comment 26 by bugdroid1@chromium.org, Feb 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5debfcf471cb88798a6043f28f6631c497ae4de

commit d5debfcf471cb88798a6043f28f6631c497ae4de
Author: xunjieli <xunjieli@chromium.org>
Date: Fri Feb 24 15:55:49 2017

Whitelist net/ MemoryDumpProvider

(1) Whitelist net/ MemoryDumpProvider.
(2) Run net/ MemoryDumpProvider unittests in background mode.
(3) Use PRIxPTR when printing pointer address in MemoryDumpProvider.
(4) Annotate the "origin" of a URLRequestContext in a string attribute
rather than in the name of the allocator dump. This is to facilitate the
regex matching of the whitelist.

BUG= 669108 

Review-Url: https://codereview.chromium.org/2699163002
Cr-Commit-Position: refs/heads/master@{#452836}

[modify] https://crrev.com/d5debfcf471cb88798a6043f28f6631c497ae4de/base/trace_event/memory_infra_background_whitelist.cc
[modify] https://crrev.com/d5debfcf471cb88798a6043f28f6631c497ae4de/net/base/sdch_manager.cc
[modify] https://crrev.com/d5debfcf471cb88798a6043f28f6631c497ae4de/net/base/sdch_manager_unittest.cc
[modify] https://crrev.com/d5debfcf471cb88798a6043f28f6631c497ae4de/net/http/http_cache_unittest.cc
[modify] https://crrev.com/d5debfcf471cb88798a6043f28f6631c497ae4de/net/http/http_network_session.cc
[modify] https://crrev.com/d5debfcf471cb88798a6043f28f6631c497ae4de/net/spdy/spdy_session_pool_unittest.cc
[modify] https://crrev.com/d5debfcf471cb88798a6043f28f6631c497ae4de/net/ssl/ssl_client_session_cache_unittest.cc
[modify] https://crrev.com/d5debfcf471cb88798a6043f28f6631c497ae4de/net/url_request/url_request_context.cc
[modify] https://crrev.com/d5debfcf471cb88798a6043f28f6631c497ae4de/net/url_request/url_request_context_unittest.cc

Blockedon: 704953
Blockedon: 705721
Project Member

Comment 29 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4da1de6f90c7149e7b2e6db4ee66a84b355988a

commit c4da1de6f90c7149e7b2e6db4ee66a84b355988a
Author: xunjieli <xunjieli@chromium.org>
Date: Tue Mar 28 16:19:50 2017

Make url_request_context dumps include context names

Background dumps do not include URLRequestContext's names because
string attributes are not allowed. SlowReports only has background
dumps. Without the name of the context, we don't know where the contexts
come from.

This CL includes the context names in the names for the allocator dumps.

BUG= 705053 , 669108 

Review-Url: https://codereview.chromium.org/2772283003
Cr-Commit-Position: refs/heads/master@{#460116}

[modify] https://crrev.com/c4da1de6f90c7149e7b2e6db4ee66a84b355988a/base/trace_event/memory_infra_background_whitelist.cc
[modify] https://crrev.com/c4da1de6f90c7149e7b2e6db4ee66a84b355988a/chrome/browser/profiles/off_the_record_profile_io_data.cc
[modify] https://crrev.com/c4da1de6f90c7149e7b2e6db4ee66a84b355988a/chrome/browser/profiles/off_the_record_profile_io_data.h
[modify] https://crrev.com/c4da1de6f90c7149e7b2e6db4ee66a84b355988a/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/c4da1de6f90c7149e7b2e6db4ee66a84b355988a/chrome/browser/profiles/profile_impl_io_data.h
[modify] https://crrev.com/c4da1de6f90c7149e7b2e6db4ee66a84b355988a/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/c4da1de6f90c7149e7b2e6db4ee66a84b355988a/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/c4da1de6f90c7149e7b2e6db4ee66a84b355988a/net/base/sdch_manager_unittest.cc
[modify] https://crrev.com/c4da1de6f90c7149e7b2e6db4ee66a84b355988a/net/http/http_cache_unittest.cc
[modify] https://crrev.com/c4da1de6f90c7149e7b2e6db4ee66a84b355988a/net/url_request/url_request_context.cc
[modify] https://crrev.com/c4da1de6f90c7149e7b2e6db4ee66a84b355988a/net/url_request/url_request_context.h

Project Member

Comment 30 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04bec3956c7f19339e9fb1ff04b348922331753d

commit 04bec3956c7f19339e9fb1ff04b348922331753d
Author: xunjieli <xunjieli@chromium.org>
Date: Thu Apr 06 23:19:07 2017

One minor cleanup for JobController::EstimateMemoryUsage()

BUG= 669108 

Review-Url: https://codereview.chromium.org/2802113002
Cr-Commit-Position: refs/heads/master@{#462673}

[modify] https://crrev.com/04bec3956c7f19339e9fb1ff04b348922331753d/net/http/http_stream_factory_impl_job_controller.cc

Project Member

Comment 31 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/629230d36ade0d832af100a11306580600404d76

commit 629230d36ade0d832af100a11306580600404d76
Author: xunjieli <xunjieli@chromium.org>
Date: Wed Jun 21 19:14:14 2017

Add documentation for //net MemoryDumpProvider

This CL adds docs/memory/probe-net.md as a documentation for the "net" column
in memory infra.

TBR=primiano@chromium.org

BUG= 669108 

Review-Url: https://codereview.chromium.org/2949063002
Cr-Commit-Position: refs/heads/master@{#481269}

[add] https://crrev.com/629230d36ade0d832af100a11306580600404d76/docs/memory-infra/probe-net.md

Status: Fixed (was: Started)
Let's close this one. We instrumented only the larger chunks of memory allocations in //net because (1) MemoryDumpProvider and SlowReports require MemoryDumpProvider::OnMemoryDump to be fast so the cost of enabling MDP is at a minimum (2) The tool for a detailed and accurate breakdown is heap profiler. It's not a goal for this bug to replicate a mini-heap-profiler specialized for //net.

There are still a bunch of TODOs associated with this bug.

Sign in to add a comment