New issue
Advanced search Search tips

Issue 669106 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

codec-tests/aac/m4a-short-duration-44khz.html layout test fails

Project Member Reported by rtoy@chromium.org, Nov 28 2016

Issue description

WebAudio test codec-tests/aac/m4a-short-duration-44khz.html fails no with ToT Chromium from today.  

I suspect that an ffmpeg roll done a couple of weeks ago caused the change.

The actual file appears to have the pre-roll priming frames removed.

Probably just need to update the expected file for the new result.
 

Comment 1 by rtoy@chromium.org, Nov 28 2016

A closer examination shows that the actual file is the same as the expected, except the first 2048 samples (of zeroes) from the expected file has been removed.

Comment 2 by rtoy@chromium.org, Nov 28 2016

Cc: dalecur...@chromium.org
+dalecurtis: FYI
Cc: wolenetz@chromium.org
Oooh, aac priming cleanup is fixed.

Comment 4 by rtoy@chromium.org, Nov 28 2016

Owner: rtoy@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/190a8431df79a1729cb36558de46a742af3c4fa8

commit 190a8431df79a1729cb36558de46a742af3c4fa8
Author: rtoy <rtoy@chromium.org>
Date: Tue Nov 29 00:37:23 2016

Update aac/m4a test result

An ffmpeg roll seems to updated the handling of the pre-roll for the
aac test.  The difference between the new and old results is that the
new has the initial 2048 samples (of zero) removed.

BUG= 669106 
TEST=m4a-short-duration-44khz.html now passes

Review-Url: https://codereview.chromium.org/2536843002
Cr-Commit-Position: refs/heads/master@{#434798}

[modify] https://crrev.com/190a8431df79a1729cb36558de46a742af3c4fa8/third_party/WebKit/LayoutTests/webaudio/codec-tests/aac/m4a-short-duration-44khz-expected.wav

Comment 6 by rtoy@chromium.org, Nov 29 2016

Status: Verified (was: Started)

Sign in to add a comment