New issue
Advanced search Search tips

Issue 669093 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Freshness limit for offline previews should be field trial configurable

Project Member Reported by ryansturm@chromium.org, Nov 28 2016

Issue description

The number of days since download that an offline page is eligible to be shown as a preview should be field trial configurable. Currently, the number of days is set to 1.

The default should be set back to 7 (this was changed by mistake in a refactor of the offline code  codereview.chromium.org/2245733004).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e42c5acc8c61a87e6a72352d2428b3f477bd73c1

commit e42c5acc8c61a87e6a72352d2428b3f477bd73c1
Author: ryansturm <ryansturm@chromium.org>
Date: Wed Nov 30 14:10:22 2016

Making offline previews freshness configurable

This makes the freshness (e.g. the amount of time since download that
the page may be shown as a preview) of offline previews controllable
as a field trial param.

This also sets the default back to 7 days, which was changed during the
offline page refactor that moved the code from the UI thread to the IO
thread.

BUG= 669093 

Review-Url: https://codereview.chromium.org/2537563002
Cr-Commit-Position: refs/heads/master@{#435251}

[modify] https://crrev.com/e42c5acc8c61a87e6a72352d2428b3f477bd73c1/chrome/browser/android/offline_pages/offline_page_request_job.cc
[modify] https://crrev.com/e42c5acc8c61a87e6a72352d2428b3f477bd73c1/components/previews/core/previews_experiments.cc
[modify] https://crrev.com/e42c5acc8c61a87e6a72352d2428b3f477bd73c1/components/previews/core/previews_experiments.h

Labels: Merge-Request-56

Comment 3 by dimu@chromium.org, Dec 1 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 2 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/426a071edcb4b14719869f95bd533ea6081c1d0d

commit 426a071edcb4b14719869f95bd533ea6081c1d0d
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Fri Dec 02 21:11:19 2016

Making offline previews freshness configurable

This makes the freshness (e.g. the amount of time since download that
the page may be shown as a preview) of offline previews controllable
as a field trial param.

This also sets the default back to 7 days, which was changed during the
offline page refactor that moved the code from the UI thread to the IO
thread.

BUG= 669093 

Review-Url: https://codereview.chromium.org/2537563002
Cr-Commit-Position: refs/heads/master@{#435251}
(cherry picked from commit e42c5acc8c61a87e6a72352d2428b3f477bd73c1)

Review URL: https://codereview.chromium.org/2541353006 .

Cr-Commit-Position: refs/branch-heads/2924@{#300}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/426a071edcb4b14719869f95bd533ea6081c1d0d/chrome/browser/android/offline_pages/offline_page_request_job.cc
[modify] https://crrev.com/426a071edcb4b14719869f95bd533ea6081c1d0d/components/previews/core/previews_experiments.cc
[modify] https://crrev.com/426a071edcb4b14719869f95bd533ea6081c1d0d/components/previews/core/previews_experiments.h

Status: Fixed (was: Started)

Sign in to add a comment