Freshness limit for offline previews should be field trial configurable |
|||||
Issue descriptionThe number of days since download that an offline page is eligible to be shown as a preview should be field trial configurable. Currently, the number of days is set to 1. The default should be set back to 7 (this was changed by mistake in a refactor of the offline code codereview.chromium.org/2245733004).
,
Nov 30 2016
,
Dec 1 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/426a071edcb4b14719869f95bd533ea6081c1d0d commit 426a071edcb4b14719869f95bd533ea6081c1d0d Author: Ryan Sturm <ryansturm@chromium.org> Date: Fri Dec 02 21:11:19 2016 Making offline previews freshness configurable This makes the freshness (e.g. the amount of time since download that the page may be shown as a preview) of offline previews controllable as a field trial param. This also sets the default back to 7 days, which was changed during the offline page refactor that moved the code from the UI thread to the IO thread. BUG= 669093 Review-Url: https://codereview.chromium.org/2537563002 Cr-Commit-Position: refs/heads/master@{#435251} (cherry picked from commit e42c5acc8c61a87e6a72352d2428b3f477bd73c1) Review URL: https://codereview.chromium.org/2541353006 . Cr-Commit-Position: refs/branch-heads/2924@{#300} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/426a071edcb4b14719869f95bd533ea6081c1d0d/chrome/browser/android/offline_pages/offline_page_request_job.cc [modify] https://crrev.com/426a071edcb4b14719869f95bd533ea6081c1d0d/components/previews/core/previews_experiments.cc [modify] https://crrev.com/426a071edcb4b14719869f95bd533ea6081c1d0d/components/previews/core/previews_experiments.h
,
Dec 2 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Nov 30 2016