New issue
Advanced search Search tips

Issue 669092 link

Starred by 1 user
Status: Fixed
Owner:
lanwei@chromium.org
Closed: Aug 2017
Cc:
nzolghadr@chromium.org
tdres...@chromium.org
Components:
EstimatedDays: ----
NextAction: 2016-12-12
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

SyntheticWebTouchEvent's point ID would not reset when it exceeds touch length cap

Project Member Reported by lanwei@chromium.org, Nov 28 2016 
In SyntheticWebTouchEvent::PressPoint, the touch pointer ID will keep increase until it reaches the touch length cap, then it will return false. 
https://cs.chromium.org/chromium/src/content/common/input/synthetic_web_input_event_builders.cc?dr=CSs&q=content/common/input/synthetic_web_input_event_builders.cc&sq=package:chromium&l=191

We should reset the point ID to 0 when it exceeds the maximum touch length.

Comment 1 by tdres...@chromium.org, Nov 28 2016

Labels: -Pri-3 Pri-2
The main thing we should do here is to recycle previous IDs.

In the case where one finger is held down, while a second finger is repeatedly pressed and released, the second finger should always get the same ID.

We can probably use https://cs.chromium.org/chromium/src/ui/gfx/sequential_id_generator.h?l=20&cl=GROK&gsn=SequentialIDGenerator.

Comment 2 by lanwei@chromium.org, Aug 1 2017

Status: Fixed (was: Available)
►

Sign in to add a comment