New issue
Advanced search Search tips

Issue 669091 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Jan 2018
Cc:
tandrii@chromium.org
aga...@chromium.org
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Gerrit: git cl upload -s --send-mail fails on uploading 2nd patchset with reviewers already set

Project Member Reported by tandrii@chromium.org, Nov 28 2016 
if I upload the first CL and set reviewers after that using UI, I shouldn't need to specify reviewers the second time when I upload the second patchset.

$ git cl upload -s

should thus get reviewers list from Gerrit directly and happily do git push without &notify=NONE.

Comment 1 by aga...@chromium.org, Nov 29 2016

Labels: Milestone-Dogfood

Comment 2 by andyb...@chromium.org, Dec 5 2016

Status: Available (was: Untriaged)

Comment 3 by andyb...@chromium.org, Jan 12 2017

Owner: aga...@chromium.org
Status: Assigned (was: Available)

Comment 4 by aga...@chromium.org, Mar 27 2017

Cc: aga...@chromium.org
Labels: -Milestone-Dogfood Milestone-Afterglow
Owner: ----
Status: Available (was: Assigned)
This is not a regression -- "git cl upload -s" on the second or later patchset on Rietveld does not do anything either. Marking this afterglow.

Comment 5 by aga...@chromium.org, Jan 3 2018

Labels: -Milestone-Afterglow
Removing Milestone-Afterglow, as it has ceased to have meaning. More refined milestones may be added back in the near future.

Comment 6 by aga...@chromium.org, Jan 5 2018

Status: Fixed (was: Available)
The WIP workflow has totally changed the way reviewers are notified, and this now works intuitively.
►

Sign in to add a comment