headless_lib target is always out of date |
|||
Issue description$ cr build headless_lib ... [17446/17446] LINK ./headless_lib $ cr build headless_lib ... [3/73] CXX obj/headless/headless_lib/types_network.o
,
Nov 28 2016
Right, looks like headless:gen_devtools_client_api is always rebuilt.
,
Nov 28 2016
Found le bug.
,
Nov 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa434b649b61214ed73ed6a7b4354984ea81a2c2 commit fa434b649b61214ed73ed6a7b4354984ea81a2c2 Author: skyostil <skyostil@chromium.org> Date: Mon Nov 28 18:28:21 2016 headless: Fix inconsistent header naming Because of a missing 's' the generated client API was always considered out of date. BUG= 669077 Review-Url: https://codereview.chromium.org/2531363002 Cr-Commit-Position: refs/heads/master@{#434699} [modify] https://crrev.com/fa434b649b61214ed73ed6a7b4354984ea81a2c2/headless/BUILD.gn [modify] https://crrev.com/fa434b649b61214ed73ed6a7b4354984ea81a2c2/headless/lib/browser/devtools_api/client_api_generator.py [rename] https://crrev.com/fa434b649b61214ed73ed6a7b4354984ea81a2c2/headless/lib/browser/devtools_api/domain_types_forward_declarations_h.template [modify] https://crrev.com/fa434b649b61214ed73ed6a7b4354984ea81a2c2/headless/lib/browser/devtools_api/domain_types_h.template
,
Nov 28 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by altimin@chromium.org
, Nov 28 2016