Enable -Werror for links in chromecast builds |
||
Issue descriptionhttps://codereview.chromium.org/2521913005/ enabled warnings-as-errors for warnings emitted by the compiler driver during links. I had to disable this for is_chromecast builds because FAILED: libcast_media_1.0_android.so libcast_media_1.0_android.so.TOC lib.unstripped/libcast_media_1.0_android.so python "/b/c/b/cast_shell_android/src/build/toolchain/gcc_solink_wrapper.py" --readelf="../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-readelf" --nm="../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-nm" --strip=../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-strip --sofile="./lib.unstripped/libcast_media_1.0_android.so" --tocfile="./libcast_media_1.0_android.so.TOC" --output="./libcast_media_1.0_android.so" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed --gcc-toolchain=../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64 -fuse-ld=gold -Wl,--icf=all -Wl,--build-id=sha1 -Wl,--no-undefined -Wl,--exclude-libs=libgcc.a -Wl,--exclude-libs=libc++_static.a -Wl,--exclude-libs=libvpx_assembly_arm.a --target=arm-linux-androideabi -Werror -nostdlib -Wl,--warn-shared-textrel --sysroot=../../third_party/android_tools/ndk/platforms/android-16/arch-arm -Wl,-rpath=/oem_cast_shlib -Wl,-rpath=\$ORIGIN/lib -Wl,-rpath=\$ORIGIN -static-libstdc++ -static-libgcc -Wl,--exclude-libs=libffmpeg.a -Wl,--version-script=/b/c/b/cast_shell_android/src/build/android/android_no_jni_exports.lst -Wl,-wrap,calloc -Wl,-wrap,free -Wl,-wrap,malloc -Wl,-wrap,memalign -Wl,-wrap,posix_memalign -Wl,-wrap,pvalloc -Wl,-wrap,realloc -Wl,-wrap,valloc -L../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libs/armeabi-v7a -o "./lib.unstripped/libcast_media_1.0_android.so" -Wl,-soname="libcast_media_1.0_android.so" @"./libcast_media_1.0_android.so.rsp" clang: error: argument unused during compilation: '-static-libstdc++' [-Werror,-Wunused-command-line-argument] clang: error: argument unused during compilation: '-static-libgcc' [-Werror,-Wunused-command-line-argument] https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/168815/steps/compile%20%28with%20patch%29/logs/stdio (also see bug 669072 ) Not sure why these flags are getting ignored. Can someone take a look?
,
Nov 28 2016
,
Nov 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21b2e5f86e4ac1ecd5bcc3da195cf2f7fd427eff commit 21b2e5f86e4ac1ecd5bcc3da195cf2f7fd427eff Author: thakis <thakis@chromium.org> Date: Mon Nov 28 22:51:53 2016 Enable -Werror for links in chromecast builds. BUG= 669076 Review-Url: https://codereview.chromium.org/2532193002 Cr-Commit-Position: refs/heads/master@{#434755} [modify] https://crrev.com/21b2e5f86e4ac1ecd5bcc3da195cf2f7fd427eff/build/config/chromecast/BUILD.gn [modify] https://crrev.com/21b2e5f86e4ac1ecd5bcc3da195cf2f7fd427eff/build/config/compiler/BUILD.gn
,
Nov 28 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by thakis@chromium.org
, Nov 28 2016