New issue
Advanced search Search tips

Issue 669072 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Enable -Werror on links for asan builds

Project Member Reported by thakis@chromium.org, Nov 28 2016

Issue description

Tracking bug for one of the two TODOs added in https://codereview.chromium.org/2521913005/
 

Comment 2 by thakis@chromium.org, Nov 28 2016

Summary: Enable -Werror on links for asan builds (was: Enable -Werror on linux for asan builds)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b58fafbaa929d521e638c16ff638a433ae63f2f

commit 5b58fafbaa929d521e638c16ff638a433ae63f2f
Author: thakis <thakis@chromium.org>
Date: Wed Nov 30 14:23:56 2016

Move pthread flags out compiler config.

That way, buildtools/third_party/libc++/BUILD.gn can opt out of it,
fixing a TODO and a link-time warning when linking libc++.  Once that's
done, we can enable warnings-as-errors for links in asan builds.
(Currently, warnings-as-errors-for-links is enabled everywhere except
asan and chromecast builds.)

No intended behavior change.

BUG= 669072 
TBR=brettw

Review-Url: https://codereview.chromium.org/2537493002
Cr-Commit-Position: refs/heads/master@{#435255}

[modify] https://crrev.com/5b58fafbaa929d521e638c16ff638a433ae63f2f/build/config/BUILDCONFIG.gn
[modify] https://crrev.com/5b58fafbaa929d521e638c16ff638a433ae63f2f/build/config/compiler/BUILD.gn
[modify] https://crrev.com/5b58fafbaa929d521e638c16ff638a433ae63f2f/build/config/linux/BUILD.gn

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5144ca400abd436c2f332ac438a58e3d6e63460

commit e5144ca400abd436c2f332ac438a58e3d6e63460
Author: thakis <thakis@chromium.org>
Date: Wed Nov 30 16:30:54 2016

Enable -Werror for links in asan builds.

Rolls buildtools by one to pick up https://codereview.chromium.org/2531333002/

BUG= 669072 

Review-Url: https://codereview.chromium.org/2541493004
Cr-Commit-Position: refs/heads/master@{#435286}

[modify] https://crrev.com/e5144ca400abd436c2f332ac438a58e3d6e63460/DEPS
[modify] https://crrev.com/e5144ca400abd436c2f332ac438a58e3d6e63460/build/config/compiler/BUILD.gn

Comment 6 by thakis@chromium.org, Nov 30 2016

Status: Fixed (was: Started)

Sign in to add a comment