New issue
Advanced search Search tips

Issue 669065 link

Starred by 1 user
Status: Fixed
Owner:
mthiesse@chromium.org
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR Shell UI shows up multiple times in chrome://inspect, leads to crashes.

Project Member Reported by mthiesse@chromium.org, Nov 28 2016 
Each time you re-enter VR, another "VR Shell UI" entry shows up in chrome://inspect. Trying to use all but the most recent leads to a crash.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9da88a2254c9cde59bc7f266f420391a1ba9f3ec

commit 9da88a2254c9cde59bc7f266f420391a1ba9f3ec
Author: mthiesse <mthiesse@chromium.org>
Date: Mon Nov 28 17:22:35 2016

Clean up UI WebContents when destroying VR Shell.

Note that now our re-entry performance is worse than before, because we weren't recreating our WebContents before. We should look into either caching, pre-loading, or otherwise, to improve startup time.

BUG= 669065 

Review-Url: https://codereview.chromium.org/2535853002
Cr-Commit-Position: refs/heads/master@{#434672}

[modify] https://crrev.com/9da88a2254c9cde59bc7f266f420391a1ba9f3ec/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

Comment 2 by mthiesse@chromium.org, Nov 28 2016

Labels: Merge-Request-56

Comment 3 by dimu@chromium.org, Nov 28 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 30 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6c58d88dd4c48bd622b2e3aa55e6d46e5912ea2

commit b6c58d88dd4c48bd622b2e3aa55e6d46e5912ea2
Author: bshe <bshe@chromium.org>
Date: Wed Nov 30 23:02:30 2016

Clean up UI WebContents when destroying VR Shell.

Note that now our re-entry performance is worse than before, because we weren't recreating our WebContents before. We should look into either caching, pre-loading, or otherwise, to improve startup time.

BUG= 669065 

Review-Url: https://codereview.chromium.org/2535853002
Cr-Commit-Position: refs/heads/master@{#434672}
(cherry picked from commit 9da88a2254c9cde59bc7f266f420391a1ba9f3ec)

Review URL: https://codereview.chromium.org/2540233003 .

Cr-Commit-Position: refs/branch-heads/2924@{#221}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/b6c58d88dd4c48bd622b2e3aa55e6d46e5912ea2/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

Comment 5 by mthiesse@chromium.org, Nov 30 2016

Status: Fixed (was: Assigned)

Comment 6 by ddorwin@chromium.org, Nov 30 2016

Labels: Proj-VR-Daydream
►

Sign in to add a comment