New issue
Advanced search Search tips

Issue 669038 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2% regression in v8.browsing_mobile_ignition at 432237:432387

Project Member Reported by mythria@chromium.org, Nov 28 2016

Issue description

See the link to graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Nov 28 2016

Cc: jgruber@chromium.org
Owner: jgruber@chromium.org

=== Auto-CCing suspected CL author jgruber@chromium.org ===

Hi jgruber@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : [regexp] Move RegExp.prototype[@@search] to TF
Author  : jgruber
Commit description:
  
Implements upcoming changes to @@search according to
https://github.com/tc39/ecma262/pull/627.

This also adds SameValue to CodeStubAssembler and extracts a part of
CSA::TruncateTaggedToFloat64.

BUG= v8:5339 

Review-Url: https://codereview.chromium.org/2438683005
Cr-Commit-Position: refs/heads/master@{#41000}
Commit  : e29fcbee9cebada7423eee79a77bc91a320588be
Date    : Tue Nov 15 16:06:20 2016


===== TESTED REVISIONS =====
Revision                       Mean     Std Dev  N  Good?
chromium@432236                1989098  19125.4  8  good
chromium@432274                1991865  26798.3  8  good
chromium@432279                1994046  27592.5  8  good
chromium@432282                1987059  17323.3  7  good
chromium@432282,v8@054e17796d  1989902  27125.6  8  good
chromium@432282,v8@e29fcbee9c  2032071  17094.9  5  bad    <--
chromium@432282,v8@bb6a626b76  2033714  20243.4  5  bad
chromium@432282,v8@32077e01fb  2032174  16717.7  5  bad
chromium@432283                2034707  23491.1  5  bad
chromium@432284                2025979  6077.39  5  bad
chromium@432293                2036714  27777.9  5  bad
chromium@432312                2041906  32581.6  5  bad
chromium@432387                2032037  31528.7  5  bad

Bisect job ran on: android_nexus5_perf_bisect
Bug ID: 669038

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.news.washingtonpost v8.browsing_mobile_ignition
Test Metric: memory:chrome:renderer_processes:reported_by_chrome:code_and_metadata_size_max/browse_news/browse_news_washingtonpost
Relative Change: 2.16%

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5_perf_bisect/builds/4382
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8994742492841705168


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5846331485061120

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Status: Assigned (was: Untriaged)
Looks like an additional 80k on code_and_metadata_size_max. I guess this can be closed, opinions?
Cc: rmcilroy@chromium.org
I think we can close this. Also ccing rmcilroy@
Status: WontFix (was: Assigned)
Yup, let's close it.

Sign in to add a comment