New issue
Advanced search Search tips

Issue 669028 link

Starred by 3 users
Status: Fixed
Owner:
gambard@chromium.org
Closed: Dec 2016
Cc:
mard...@chromium.org
rohitrao@chromium.org
ios-bugs@chromium.org
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Switch context menu from User Actions to Histograms

Project Member Reported by gambard@chromium.org, Nov 28 2016 
iOS still use UserActions for the context menu actions even if they are deprecated: https://codereview.chromium.org/1305893003
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01d0304a40a5a7e0bb1da9a1d5fd68b8cd802c0d

commit 01d0304a40a5a7e0bb1da9a1d5fd68b8cd802c0d
Author: gambard <gambard@chromium.org>
Date: Mon Nov 28 18:16:49 2016

Add iOS ContextMenu histogram

Chrome on iOS uses the deprecated User Action "MobileContextMenu..." as part of
the upstreaming, it should use the new histogram "ContextMenuOption".
This CL adds the histograms needed by Chrome on iOS.

BUG= 669028 

Review-Url: https://codereview.chromium.org/2537453002
Cr-Commit-Position: refs/heads/master@{#434693}

[modify] https://crrev.com/01d0304a40a5a7e0bb1da9a1d5fd68b8cd802c0d/tools/metrics/histograms/histograms.xml
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 12 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/ac9bbf66524193024559d8b5f3c6b114a69546d6

commit ac9bbf66524193024559d8b5f3c6b114a69546d6
Author: gambard <gambard@google.com>
Date: Mon Dec 12 08:50:48 2016

Comment 3 by gambard@chromium.org, Dec 12 2016

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 12 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/863c215bb493f7eded2fb48f4bea71448850bfda

commit 863c215bb493f7eded2fb48f4bea71448850bfda
Author: gambard <gambard@google.com>
Date: Mon Dec 12 09:31:30 2016
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 12 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/09de543b8451ef38fbe30dad5e43d0439909bc6f

commit 09de543b8451ef38fbe30dad5e43d0439909bc6f
Author: gambard <gambard@google.com>
Date: Mon Dec 12 16:00:37 2016
►

Sign in to add a comment