Difference between x64 and ia32: syntax error message |
|||||
Issue description
# Minimized program:
1073741824O0
# Compared default with ia32
# Flags of default:
--abort_on_stack_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --es-staging --random-seed -1237101700
# Flags of ia32:
--abort_on_stack_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --es-staging --random-seed -1237101700
Difference:
- /usr/local/google/home/machenbach/v8/clusterfuzz-data/fuzzers/workdir/output33_ia32/fuzz-02493.js.minimized:1: SyntaxError: Unexpected identifier
+ /usr/local/google/home/machenbach/v8/clusterfuzz-data/fuzzers/workdir/output33_ia32/fuzz-02493.js.minimized:1: SyntaxError: Invalid or unexpected token
### Start of configuration default:
/usr/local/google/home/machenbach/v8/clusterfuzz-data/fuzzers/workdir/output33_ia32/fuzz-02493.js.minimized:1: SyntaxError: Unexpected identifier
1073741824O0
^^
SyntaxError: Unexpected identifier
### End of configuration default
### Start of configuration ia32:
/usr/local/google/home/machenbach/v8/clusterfuzz-data/fuzzers/workdir/output33_ia32/fuzz-02493.js.minimized:1: SyntaxError: Invalid or unexpected token
1073741824O0
^^^^^^^^^^
SyntaxError: Invalid or unexpected token
### End of configuration ia32
,
Nov 28 2016
,
Nov 28 2016
Can reproduce. I think this a (minor) bug in the scanner, which - for performance reasons - takes a slightly different path depending on whether it finds a SMI or not. This seems to be not quite correct w/ respect to error handling. On 32b, this probably gets scanned as Token::ILLEGAL. On 64b, where the part before the 'O' fits into a SMI, it's probably scanned as Token::SMI + Token::IDENTIFIER. I need to figure out which case is correct - probably 32b. But in either case this should scan as the same token sequence on all platforms.
,
Nov 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/c44008b01f69785f4487c46afb15f971290baf5a commit c44008b01f69785f4487c46afb15f971290baf5a Author: vogelheim <vogelheim@chromium.org> Date: Tue Nov 29 15:05:43 2016 Ensure consistent error handling on 32b/64b platforms. BUG= chromium:669017 Review-Url: https://codereview.chromium.org/2536783003 Cr-Commit-Position: refs/heads/master@{#41364} [modify] https://crrev.com/c44008b01f69785f4487c46afb15f971290baf5a/src/parsing/scanner.cc [add] https://crrev.com/c44008b01f69785f4487c46afb15f971290baf5a/test/message/regress/regress-crbug-669017.js [add] https://crrev.com/c44008b01f69785f4487c46afb15f971290baf5a/test/message/regress/regress-crbug-669017.out
,
Nov 29 2016
,
Dec 13 2016
,
Jan 11 2017
Issue 679881 has been merged into this issue.
,
Jan 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/c4a35ed7e831448e1fd2a2ca1f79d5fefae0655e commit c4a35ed7e831448e1fd2a2ca1f79d5fefae0655e Author: machenbach <machenbach@chromium.org> Date: Mon Jan 16 09:01:51 2017 [foozzie] Remove suppressions for fixed bugs BUG= chromium:663750 , chromium:662907 , chromium:663340 , chromium:666308 , chromium:669017 NOTRY=true TBR=jarin@chromium.org, bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2632153002 Cr-Commit-Position: refs/heads/master@{#42356} [modify] https://crrev.com/c4a35ed7e831448e1fd2a2ca1f79d5fefae0655e/tools/foozzie/v8_suppressions.js [modify] https://crrev.com/c4a35ed7e831448e1fd2a2ca1f79d5fefae0655e/tools/foozzie/v8_suppressions.py |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by hablich@chromium.org
, Nov 28 2016Components: -Blink>JavaScript Blink>JavaScript>Runtime
Status: Available (was: Untriaged)