New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 669003 link

Starred by 3 users
Status: Verified
Owner:
steve...@chromium.org
Closed: Jan 2017
Cc:
tommycli@chromium.org
ajha@chromium.org
█ kavvaru@chromium.org
█ brajkumar@chromium.org
█ durga.behera@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Regression : Profile Icon is not seen properly in chrome://settings/accounts

Project Member Reported by mmanchala@chromium.org, Nov 28 2016 
Version: 57.0.2933.0/9028.0.0 dev- channel Candy,Daisy and paine
OS: Chrome

Pre-condition : Enable 'Material Design settings' Flag from chrome://flags

What steps will reproduce the problem?
(1)Sign into User -> Go to chrome://settings/accounts page
(2)Now observe Profile Icon under 'Restrict sign-in to the following users' (Please refer Video)

Exoected: Profile Icon should be seen properly in chrome://settings/accounts page
Actual: Instead Profile Icon is not seen properly 

This is Regression Issue as same is working fine in chrome://settings page
Actual_ImageIcon.jpg
59.3 KB View Download
Actual_Icon.webm
1.4 MB View Download

Comment 1 by steve...@chromium.org, Dec 29 2016

Owner: steve...@chromium.org
Status: Started (was: Untriaged)
I can reproduce this by logging in with chrome://md-settings/accounts open. If I navigate from the main settings page it does not reproduce. i suspect we are not requesting the profile images correctly during load.

Comment 2 by steve...@chromium.org, Dec 29 2016

Cc: tommycli@chromium.org
Actually, the JS is fine, we just need to call content::URLDataSource::Add(profile, new chromeos::options::UserImageSource()) in the handler.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d10629b867e1399c2339f078ac3d16f0b402248d

commit d10629b867e1399c2339f078ac3d16f0b402248d
Author: stevenjb <stevenjb@chromium.org>
Date: Tue Jan 03 19:33:27 2017

MD Settings: users: Register UserImageSource in handler

BUG= 669003 

Review-Url: https://codereview.chromium.org/2607883002
Cr-Commit-Position: refs/heads/master@{#441182}

[modify] https://crrev.com/d10629b867e1399c2339f078ac3d16f0b402248d/chrome/browser/ui/webui/settings/profile_info_handler.cc

Comment 4 by steve...@chromium.org, Jan 9 2017

Status: Fixed (was: Started)

Comment 5 by sdantul...@chromium.org, Jan 21 2017

Status: Verified (was: Fixed)
Verified on ChromeOS 9199.0.0, 57.0.2984.0
►

Sign in to add a comment