New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 668991 link

Starred by 2 users
Status: Duplicate
Owner:
█ spqc...@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Cc:
█ spqc...@chromium.org
nyerramilli@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
█ shrike@chromium.org
mac-bugs-priority@chromium.org
est...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression :Text of avatar icon is seen in white color after 'Yorkie Puppy' theme is applied.

Reported by dmascare...@etouch.net, Nov 28 2016 
Chrome Version:57.0.2935.0 (Official Build) dfc8980ac3e308b549ea828547dfd3982eb34602-refs/heads/master@{#434592} (64-bit)
OS: Mac(10.12.1,10.11.6)

Pre-condition: Sign into chrome with valid credential or create 2 user.

Test url:
https://chrome.google.com/webstore/detail/yorkie-puppy/llopkobagcnfklhbcbklkpojhfceonlo?utm_source=chrome-ntp-icon

What steps will reproduce the problem?
1. Launch chrome,navigate to above test url and click on 'Add to chrome' button 
2. Observe text avatar icon.

Actual : Text of avatar icon is seen in white color.
Expected : Text of avatar icon should appear in black color.

This is a regression issue broken in ‘M-55’, below is the Manual Regression info:
Good build:55.0.2882.0
Bad build:55.0.2883.6

Note: Issue is not seen on Windows and Linux OS.
Text.png
203 KB View Download

Comment 1 by msrchandra@chromium.org, Nov 28 2016

Labels: hasbisect-per-revision
Owner: spqc...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 55.0.2882.0 (Revision: 423378).
Bad build: 55.0.2883.6 (Revision: 423768).

You are probably looking for a change made after 423059 (known good), but no later than 423060 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/96a59f8297eaff8ff8f70f35ec489d7f47e0e6c8..28f2ba5dd2bd96becc57e5caf9447e7ce65db96b

@spqchan -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Thank You.

Comment 2 by ranjitkan@chromium.org, Nov 30 2016

Cc: ranjitkan@chromium.org
@spqchan: Gentle Ping, Issue is marked with M55 milestone and it is approaching stable soon. Request you to please take a look into it and provide an update.

Thanks.!

Comment 3 by ranjitkan@chromium.org, Dec 5 2016

Labels: ReleaseBlock-Stable
Adding release block label, so that issue gets prioritised.

Please undo or remove if not the case.

Comment 4 by spqc...@chromium.org, Dec 5 2016

Labels: -ReleaseBlock-Stable
Status: WontFix (was: Assigned)
It's working as expected.

Comment 5 by shrike@chromium.org, Dec 5 2016

Cc: spqc...@chromium.org shrike@chromium.org
Owner: bettes@chromium.org
Status: Assigned (was: WontFix)
Per  Issue 646060  the avatar button text now follows the bookmark bar text color. That certainly works for the examples presented in that issue but not for the case above. The problem is there's no guarantee what the window background will be - in general text color is set to look good against the tabstrip/toolbar background, but the avatar button doesn't fill itself with the toolbar background, so you can get a mismatch as in this case.

bettes@ - any ideas.

Comment 6 by bettes@chromium.org, Dec 5 2016

Owner: spqc...@chromium.org
I don't have any good solutions for this. As stated, "there's no guarantee what the window background will be" so it's my hope that we can at least accommodate the group of themes that use readable bookmark bar text colors. 

Re: Yorkie Puppy, the bookmark bar text color is peach colored, not white. If the avatar button text followed  crbug.com/646060 , this wouldn't be an issue?
Screen Shot 2016-12-05 at 2.17.03 PM.png
209 KB View Download

Comment 7 by spqc...@chromium.org, Dec 5 2016

Mergedinto: 644004
Status: Duplicate (was: Assigned)
►

Sign in to add a comment