New issue
Advanced search Search tips

Issue 668960 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

VEA unittest: VideoFrameQualityValidator should catch bottom green corruption

Project Member Reported by wuchengli@chromium.org, Nov 28 2016

Issue description

https://chromium-review.googlesource.com/#/c/409812/ introduced a regression that the bottom of the encoded video had green lines. But VideoFrameQualityValidator in VEA unittest didn't catch it. We should fix this.
 

Comment 1 by kcwu@chromium.org, Nov 28 2016

Idea: for "green pixels" special case, maybe we can scan all decoded pixels and report failure if the number of "pure greeen" pixels is larger than certain threshold.

Pro: This check is easy to implement, could be added to every tests, and doesn't require golden image.
Con: this may false alarm but I think it is acceptable because "pure greeen" pixels should be rare in practice.

Owner: hywu@chromium.org
Status: Assigned (was: Available)
PTAL. This is not urgent.

Comment 3 by hywu@chromium.org, Dec 8 2016

Status: WontFix (was: Assigned)
VEA unittest did catch this issue. Check below for the failure in matrix.
https://wmatrix.googleplex.com/testrun/video?test_ids=380298105

Sign in to add a comment