Issue metadata
Sign in to add a comment
|
V8 windows bots have random compile errors with image size exceeds maximum allowable size |
||||||||||||||||||||||
Issue descriptionSee e.g.: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug%20builder/builds/13738 https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/17586 https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20debug/builds/13709 https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20debug/builds/13711 FAILED: cctest.exe cctest.exe.pdb ... LINK : fatal error LNK1248: image size (80000000) exceeds maximum allowable size (80000000) We're still on MSVS2013 if that's the cause I will push to get that switched to 2015 asap. Is there a band-aid in the mean time?
,
Nov 28 2016
@jochen: Wasn't also cctest supposed to be shared library or is that still blocked on something? If it were shared, we could shard the dlls.
,
Nov 28 2016
As a shot in the dark, I'll land a landmine to rule out an orphan dll that gets added as suggested in issue 560522 .
,
Nov 28 2016
no, cctest is the last remaining full binary :-/
,
Nov 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/e96076ee4293352fc899cd89a1ba653e60021a44 commit e96076ee4293352fc899cd89a1ba653e60021a44 Author: machenbach <machenbach@chromium.org> Date: Mon Nov 28 08:23:02 2016 [build] Landmine for flaky win compile problems. BUG= chromium:668958 TBR=jochen@chromium.org Review-Url: https://codereview.chromium.org/2531183002 Cr-Commit-Position: refs/heads/master@{#41296} [modify] https://crrev.com/e96076ee4293352fc899cd89a1ba653e60021a44/gypfiles/get_landmines.py
,
Nov 28 2016
Didn't happen anymore after landmine. So maybe it was a stray dll...
,
Nov 28 2016
Now the problem started appearing again on a random CL: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20debug/builds/13739
,
Nov 29 2016
Not sure if the MSVS2015 switch will help here, but we better get it done to rule it out. Marking as blocking.
,
Dec 5 2016
It's not totally clear *what* file is exceeding the 2 GB limit. My guess is it is the .ilk file (used for incremental linking) in which case VS 2015 will help a lot because the limit is raised to 4 GB. If that's not the problem then it might be the .pdb file. .pdb files are reused and due to fragmentation and *mumble* *mumble* *who* *knows* they can grow significantly over a repeated series of non-clobber builds. This was causing build flakes that were addressed by deleting the .pdb before every link. This doesn't waste significant time and means that the PDBs are always as small as possible. See this CL: https://codereview.chromium.org/2519803003 If it's not one of those then ??? but knowing which file was hitting the problem would be nice.
,
Dec 5 2016
Thanks for the pointers! So far it didn't happen again. I'll close this for now again and keep it in my archive. If it happens again, I'll take a look for further action. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by machenb...@chromium.org
, Nov 28 2016