New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 668953 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:[Devtools]Unable to navigate to other tabs like Audit, Profile,etc after clicking on 'New Snippet'.

Reported by jshan...@etouch.net, Nov 28 2016

Issue description

Chrome Version: 57.0.2934.0 (Official Build) c90cb5357fcdc1c4ceccd2c9284c7f6ff4214371-refs/heads/master@{#434580}-32/64 bit
OS : Mac(10.11.6, 10.12.1, 10.12), Windows(7,8,8.1,10), Linux (14.04 LTS)

Steps:
1. Launch Chrome, open devtools on NTP and go to Source section
2. Click on Chevron icon(>>) beside 'Content scripts', select 'Snippets' and click on 'New Snippet'
3. Now click on Chevron icon(>>) of Devtools window and select any other tab like Audit, Profile,etc and observe.

Actual: Unable to navigate to other tabs like Audit, Profile,etc after clicking on 'New Snippet'.

Expected: Should be able to navigate to other tabs like Audit, Profile,etc after clicking on 'New Snippet'.

This is a regression issue broken in ‘M-56’, below is the Manual Regression range and will soon update other info.

Good build : 56.0.2888.0
Bad build : 56.0.2889.0
 
Actual_video.mp4
474 KB View Download
Expected_video.mp4
443 KB View Download
Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: pfeldman@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 56.0.2888.0 (Revision: 424625).
Bad build: 56.0.2889.0 (Revision: 424926).

You are probably looking for a change made after 424894 (known good), but no later than 424895 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/9d82356b6496bb090bd743be75774a9c4b9918e3..2cbfc042012e00bc5863caa8c55de9d25f71d5e3

@pfeldman -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
Adding RB Label as this is a recent Regression. Please remove if not required.

Thank You.
Owner: einbinder@chromium.org
The problem is that snippet name has editable focus that commits upon focus lost.
Labels: -ReleaseBlock-Stable
Cc: rbasuvula@chromium.org
Just for update, Still able to reproduce the issue on Ubuntu 14.04 using latest chrome canary version 57.0.2956.0.

einbinder@ Could you please look into this issue.

Thanks!
Still able to reproduce the issue on win10 using latest chrome canary version 57.0.2969.0

einbinder@, Could you please take a look
Still able to reproduce the issue on Win-10 using latest chrome canary version #57.0.2976.0

einbinder@ - Gentle Ping....!!

Could you please have a look into this issue.

Thanks...!!

Just to update, still able to reproduce the issue on Win-10 using latest canary version #57.0.2983.0.

einbinder@ - Gentle Ping....!!

Could you please have a look into this issue.

Thanks...!!
Just to update, still able to reproduce the issue on Win-10 using latest canary version #58.0.2989.0.

einbinder@ - Gentle Ping....!!

Could you please have a look into this issue.

Thanks...!!
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8a423fa01eb5fce1b106b1f51dc76cd8586c4f6

commit a8a423fa01eb5fce1b106b1f51dc76cd8586c4f6
Author: Joel Einbinder <einbinder@chromium.org>
Date: Sat Nov 11 02:00:02 2017

DevTools: Don't reveal UISourceCode on simple rename

Bug:  668953 
Change-Id: I33337f5297c5e17c24540355799d14079401cdfb
Reviewed-on: https://chromium-review.googlesource.com/761261
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515790}
[modify] https://crrev.com/a8a423fa01eb5fce1b106b1f51dc76cd8586c4f6/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js

Comment 10 by vku...@etouch.net, Nov 13 2017

Rechecked again and above issue is still reproducible on latest canary version i.e. 64.0.3267.0(Official Build)

Please refer attached screencast
Actual_Canary.mp4
543 KB View Download
Yep, sorry it is not fully fixed yet. The above patch was 1 of 2.
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45830a40b45c593d76c0a8276a02c8e1d8b56eea

commit 45830a40b45c593d76c0a8276a02c8e1d8b56eea
Author: Joel Einbinder <einbinder@chromium.org>
Date: Tue Nov 14 03:09:41 2017

DevTools: Stop NavigatorView from stealing focus on rename

Bug:  668953 
Change-Id: I924f1ec6148c71d484ae574d4e1e556ab62f14f5
Reviewed-on: https://chromium-review.googlesource.com/767073
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516161}
[modify] https://crrev.com/45830a40b45c593d76c0a8276a02c8e1d8b56eea/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js

Status: Fixed (was: Assigned)

Comment 14 by vku...@etouch.net, Nov 15 2017

Labels: TE-Verified-M64 TE-Verified-64.0.3269.0
Rechecked again and above issue is still reproducible on latest canary version i.e. 64.0.3269.0(Official Build)

Please refer attached screencast
Actual_Ntp.mp4
633 KB View Download

Comment 15 by vku...@etouch.net, Nov 15 2017

Rechecked above issue on all os i.e Mac(10.12.6,10.13.2), Windows(7,8,8.1,10), Linux (14.04 LTS) and the issue is fixed on latest canary version i.e. 64.0.3269.0(Official Build)

Please refer attached screencast

Actual_Ntp.mp4
633 KB View Download

Sign in to add a comment