New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 668933 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression

Blocked on:
issue 633007



Sign in to add a comment

Failed steps failed compile for win/mac/linux beta in official.desktop.continuous

Project Member Reported by ranjitkan@chromium.org, Nov 28 2016

Issue description

Link to Builder:
================
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20beta/builds/5382

Link to Log File:
=================
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20beta/builds/5382/steps/compile/logs/stdio

Error from the Log:
===================
FAILED: gin_unittests.exe gin_unittests.exe.pdb 
C:/b/depot_tools/python276_bin/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False link.exe /nologo /OUT:./gin_unittests.exe /PDB:./gin_unittests.exe.pdb @./gin_unittests.exe.rsp
c:\b\build\slave\win_beta\build\src\v8\src\utils.h(193) : fatal error C1001: An internal error has occurred in the compiler.
(compiler file 'f:\dd\vctools\compiler\utc\src\p2\main.c', line 255)
 To work around this problem, try simplifying or changing the program near the locations listed above.
Please choose the Technical Support command on the Visual C++ 
 Help menu, or open the Technical Support help file for more information

Unable to find a possible culprit, request someone to please take a look into it it.
 
Labels: Needs-triage
Labels: -Needs-triage
Owner: kochi@chromium.org
Status: Assigned (was: Untriaged)
Summary: Failed steps failed compile for win/mac/linux beta in official.desktop.continuous (was: Failed steps failed compile for win beta in official.desktop.continuous)
We have continuous failures on Win Beta, MAc Beta and Linux Beta with a different Log:

Link to Builder:
===============
Windows:
********
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20beta/builds/5383
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20beta/builds/5384

Mac:
****
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac%20beta/builds/5461
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac%20beta/builds/5462

Linux:
******
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/precise64%20beta/builds/4637
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/precise64%20beta/builds/4638

Link to Log File:
=================
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20beta/builds/5383/steps/compile/logs/stdio
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac%20beta/builds/5461/steps/compile/logs/stdio
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/precise64%20beta/builds/4637/steps/compile/logs/stdio

Error from the Log:
===================
FAILED: obj/third_party/WebKit/Source/core/css/css_2/SelectorChecker.obj 
ninja -t msvc -e environment.x64 -- "C:\b\depot_tools\win_toolchain\vs_files\d5dc33b15d1b2c086f2f6632e2fd15882f80dbd3\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/third_party/WebKit/Source/core/css/css_2/SelectorChecker.obj.rsp /c ../../third_party/WebKit/Source/core/css/SelectorChecker.cpp /Foobj/third_party/WebKit/Source/core/css/css_2/SelectorChecker.obj /Fd"obj/third_party/WebKit/Source/core/css/css_2_cc.pdb"
c:\b\build\slave\win_beta\build\src\third_party\webkit\source\core\css\selectorchecker.cpp(450): error C2196: case value '5' already used

Suspecting the below change could be the possible culprit, @ kochi: Assigning to you, kindly request you to please take a look into it.

Change URL: https://chromium.googlesource.com/chromium/src/+/136e6bae2344ec661fb566a1740ad1ef4570351d

Note: The first reported build failure was observed only on Windows, Second failure updated in this comment is seen on Windows, mac and linux OS with the same log file.

Updating the summary as well.

Thanks.!

Comment 3 by kochi@chromium.org, Nov 28 2016

Taking a look.  SelectorChecker.cpp change is mine.

Comment 4 by kochi@chromium.org, Nov 28 2016

Blockedon: 633007
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 28 2016

Labels: merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c81a6afca093ccd23046188ee231bba4b3f4c84

commit 5c81a6afca093ccd23046188ee231bba4b3f4c84
Author: kochi <kochi@chromium.org>
Date: Mon Nov 28 10:16:32 2016

Fix build on 2924 branch

3 Merges for  crbug.com/633007  on M56 branch (2924) had a glich
that caused compile error.

This fixes the compilation error.

TBR=tkent@chromium.org
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
BUG= 633007 ,  668933 

Review-Url: https://codereview.chromium.org/2533743002
Cr-Commit-Position: refs/branch-heads/2924@{#110}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/5c81a6afca093ccd23046188ee231bba4b3f4c84/third_party/WebKit/Source/core/css/SelectorChecker.cpp

Comment 6 by kochi@chromium.org, Nov 28 2016

I just committed the fix for SelectorChecker.cpp breakage, but not sure
about the original one (internal compiler error).

Comment 7 Deleted

Cc: ymalik@chromium.org sa...@chromium.org mek@chromium.org magjed@chromium.org
I see similar failure on win beta for official.desktop.continuous.

Link to Builder:
===============
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20beta/builds/5388

Link to Log File:
=================
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20beta/builds/5388/steps/compile/logs/stdio

Error from the Log:
===================
FAILED: mojo_js_integration_tests.exe mojo_js_integration_tests.exe.pdb 
C:/b/depot_tools/python276_bin/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False link.exe /nologo /OUT:./mojo_js_integration_tests.exe /PDB:./mojo_js_integration_tests.exe.pdb @./mojo_js_integration_tests.exe.rsp
c:\b\build\slave\win_beta\build\src\v8\src\heap\heap.h(487) : fatal error C1001: An internal error has occurred in the compiler.
(compiler file 'f:\dd\vctools\compiler\utc\src\p2\main.c', line 255)
 To work around this problem, try simplifying or changing the program near the locations listed above.
Please choose the Technical Support command on the Visual C++ 
 Help menu, or open the Technical Support help file for more information

CC ing today chromium sheriffs, could you please take a look on original issue and update #7?

Comment 9 by mmoss@google.com, Nov 28 2016

Status: Fixed (was: Assigned)
Build 5389 passed, so seems unrelated, possibly some builder flakiness.
Status: Assigned (was: Verified)
Re-opening this bug as  Win Beta build failed.
Build Url:
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20beta/builds/5418
Log:
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20beta/builds/5418/steps/compile/logs/stdio

Error:
FAILED: mojo_js_unittests.exe mojo_js_unittests.exe.pdb 
C:/b/depot_tools/python276_bin/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False link.exe /nologo /OUT:./mojo_js_unittests.exe /PDB:./mojo_js_unittests.exe.pdb 

Comment 12 by kochi@chromium.org, Nov 30 2016

Owner: ----
Status: Available (was: Assigned)
My CL doesn't have anything to this failure.
Status: Verified (was: Available)
Latest beta builds compiled successfully. Marking the issue as verified again. 

Log displayed in comment #11 seems to different as that in comment# 2 which was actually fixed in this bug. Will raise a new issue if seen fresh instances of the issue reported in comment#11.

Thanks.!

Comment 14 Deleted

Sign in to add a comment