Issue metadata
Sign in to add a comment
|
MacViews: LocationIconView shows up as two separate elements to VoiceOver |
||||||||||||||||||||||
Issue descriptionVersion: At least since e222406a7ee930c64e5401a3e5099acc137c743e OS: macOS What steps will reproduce the problem? (1) With a mac_views_browser=true build, navigate to google.com (2) Focus the Omnibox URL. (3) Press Cmd+F5 to turn on VoiceOver. The VO cursor (looks like a black rectangle) should get drawn around the Omnibox URL text. (4) Press Ctrl+Left to move the VO cursor to the left. It will focus on the "Secure" text. (5) Press Ctrl+Left again. It will focus on the lock icon. What is the expected result? That the icon + 'Secure' string is one element together, since it is a clickable (and focusable) target. Also see Issue 668928 . What happens instead? It shows up as two elements to VoiceOver, neither of which are clickable by VO. Hovering over it with the Accessibility Inspector shows something similar (an image and a label), but it should probably be shown as a button with a click action.
,
Dec 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d053e7da4da085c320a6a821377f429523afd63 commit 2d053e7da4da085c320a6a821377f429523afd63 Author: patricialor <patricialor@chromium.org> Date: Wed Dec 07 02:04:29 2016 Views: Add a11y information for IconLabelBubbleView and LocationIconView. IconLabelBubbleView is a View for displaying an icon + label; LocationIconView specifically is the icon + text shown on the left on the Omnibox URL (typically when a site is deemed to be secure). Neither of these classes have any accessibility information set on them, despite LocationIconView being a focusable and clickable target. This change adds a11y information to both. BUG= 668930 Review-Url: https://codereview.chromium.org/2530353002 Cr-Commit-Position: refs/heads/master@{#436832} [modify] https://crrev.com/2d053e7da4da085c320a6a821377f429523afd63/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc [modify] https://crrev.com/2d053e7da4da085c320a6a821377f429523afd63/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h [modify] https://crrev.com/2d053e7da4da085c320a6a821377f429523afd63/chrome/browser/ui/views/location_bar/location_icon_view.cc [modify] https://crrev.com/2d053e7da4da085c320a6a821377f429523afd63/chrome/browser/ui/views/location_bar/location_icon_view.h
,
Dec 12 2016
,
Dec 12 2016
Yep, fixed :) |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by patricia...@chromium.org
, Nov 28 2016