New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 668923 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

Add More Clank Omnibox Location Metrics

Project Member Reported by pdyson@chromium.org, Nov 28 2016

Issue description

1) Add an UMA histogram to count the location requests from omnibox queries for each combination of Location Source, M+ Chrome App permission and Chrome domain omnibox permission. For cases where a location could be sent further divide the counts into whether the location was sent or not.

2) Add histograms for the duration between the obtaining of location and the use of location for omnibox queries. One set of histograms records the time since the location was first obtained. There is a histogram for each combination of Location Source and whether a location was sent. A second set of histograms records the time since the location was most recently obtained. There is a histogram for each of the Location Sources.


 

Comment 1 by pdyson@chromium.org, Nov 28 2016

Cc: kcaratt...@chromium.org
Labels: Team-Security-UX
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 13 2016

Labels: M-57
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b6572e3c0aba3d558e173440bd644b2e4b9bd04

commit 5b6572e3c0aba3d558e173440bd644b2e4b9bd04
Author: pdyson <pdyson@chromium.org>
Date: Wed Jan 04 05:12:04 2017

Add histograms for location timings for Android omnibox queries.

Add histograms for the duration between the obtaining of location and the use of
location for omnibox queries. One set of histograms records the time since the
location was first obtained. There is a histogram for each combination of
Location Source and whether a location was sent. A second set of histograms
records the time since the location was most recently obtained. There is a
histogram for each of the Location Sources.

BUG= 668923 

Review-Url: https://codereview.chromium.org/2576633002
Cr-Commit-Position: refs/heads/master@{#441323}

[modify] https://crrev.com/5b6572e3c0aba3d558e173440bd644b2e4b9bd04/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java
[modify] https://crrev.com/5b6572e3c0aba3d558e173440bd644b2e4b9bd04/tools/metrics/histograms/histograms.xml

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e21b84f9d52d63c3a5e4d89d8316534669c756af

commit e21b84f9d52d63c3a5e4d89d8316534669c756af
Author: pdyson <pdyson@chromium.org>
Date: Sat Jan 07 01:49:43 2017

Remove incognito data from the Geolocation.Header.* histograms.

Also, for Geolocation.Header.PermissionState separate out the unsuitable url and not-https cases in the histogram.

BUG= 668923 

Review-Url: https://codereview.chromium.org/2594443002
Cr-Commit-Position: refs/heads/master@{#442134}

[modify] https://crrev.com/e21b84f9d52d63c3a5e4d89d8316534669c756af/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java
[modify] https://crrev.com/e21b84f9d52d63c3a5e4d89d8316534669c756af/tools/metrics/histograms/histograms.xml

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9257a44a111510a6f5121e398b17b6426e93a514

commit 9257a44a111510a6f5121e398b17b6426e93a514
Author: pdyson <pdyson@chromium.org>
Date: Mon Jan 09 23:39:46 2017

Add missing "." in Geolocation.Header.LocationAge* histograms.

BUG= 668923 

Review-Url: https://codereview.chromium.org/2620633003
Cr-Commit-Position: refs/heads/master@{#442405}

[modify] https://crrev.com/9257a44a111510a6f5121e398b17b6426e93a514/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0637efffc148042848a1b1977668e42c2a73e5b2

commit 0637efffc148042848a1b1977668e42c2a73e5b2
Author: pdyson <pdyson@chromium.org>
Date: Tue Jan 10 22:23:21 2017

For Geolocation.Header.TimeListening.* histograms change bucket for no location.

Instead of using the last bucket, use the first bucket when no location is available.

BUG= 668923 

Review-Url: https://codereview.chromium.org/2620813002
Cr-Commit-Position: refs/heads/master@{#442709}

[modify] https://crrev.com/0637efffc148042848a1b1977668e42c2a73e5b2/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java
[modify] https://crrev.com/0637efffc148042848a1b1977668e42c2a73e5b2/tools/metrics/histograms/histograms.xml

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07023fe24b20ec9ac60ed4fc72ef569e19e38b87

commit 07023fe24b20ec9ac60ed4fc72ef569e19e38b87
Author: pdyson <pdyson@chromium.org>
Date: Fri Jan 13 08:18:11 2017

Change the method of getting Location Mode for Geolocation histograms.

Changing to a method that works even when the app permission is not "allowed".

For KitKat and later using getInt with LOCATION_MODE to get the location mode.
Versions pre KitKat do not have this. So for those versions using getString
with LOCATION_PROVIDER_ALLOWED to get the same information.

BUG= 668923 

Review-Url: https://codereview.chromium.org/2621223002
Cr-Commit-Position: refs/heads/master@{#443517}

[modify] https://crrev.com/07023fe24b20ec9ac60ed4fc72ef569e19e38b87/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java

Status: Fixed (was: Started)
The work is completed.

Sign in to add a comment