Add More Clank Omnibox Location Metrics |
||||
Issue description1) Add an UMA histogram to count the location requests from omnibox queries for each combination of Location Source, M+ Chrome App permission and Chrome domain omnibox permission. For cases where a location could be sent further divide the counts into whether the location was sent or not. 2) Add histograms for the duration between the obtaining of location and the use of location for omnibox queries. One set of histograms records the time since the location was first obtained. There is a histogram for each combination of Location Source and whether a location was sent. A second set of histograms records the time since the location was most recently obtained. There is a histogram for each of the Location Sources.
,
Nov 29 2016
,
Dec 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fff2d84dfc1e5b0c38728cf242755e9c2f175013 commit fff2d84dfc1e5b0c38728cf242755e9c2f175013 Author: pdyson <pdyson@chromium.org> Date: Tue Dec 13 23:14:10 2016 Add Geolocation.PermissionState histogram. The GeolocationHeader.PermissionState histogram counts the location requests for each combination of Location Source, M+ Chrome App permission and Chrome domain omnibox permission. For cases where a location could be sent it further divides the counts into whether the location was sent or not. BUG= 668923 Review-Url: https://codereview.chromium.org/2533523002 Cr-Commit-Position: refs/heads/master@{#438329} [modify] https://crrev.com/fff2d84dfc1e5b0c38728cf242755e9c2f175013/chrome/android/java/src/org/chromium/chrome/browser/ChromeActionModeCallback.java [modify] https://crrev.com/fff2d84dfc1e5b0c38728cf242755e9c2f175013/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java [modify] https://crrev.com/fff2d84dfc1e5b0c38728cf242755e9c2f175013/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java [modify] https://crrev.com/fff2d84dfc1e5b0c38728cf242755e9c2f175013/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeaderTest.java [modify] https://crrev.com/fff2d84dfc1e5b0c38728cf242755e9c2f175013/tools/metrics/histograms/histograms.xml
,
Dec 13 2016
,
Jan 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b6572e3c0aba3d558e173440bd644b2e4b9bd04 commit 5b6572e3c0aba3d558e173440bd644b2e4b9bd04 Author: pdyson <pdyson@chromium.org> Date: Wed Jan 04 05:12:04 2017 Add histograms for location timings for Android omnibox queries. Add histograms for the duration between the obtaining of location and the use of location for omnibox queries. One set of histograms records the time since the location was first obtained. There is a histogram for each combination of Location Source and whether a location was sent. A second set of histograms records the time since the location was most recently obtained. There is a histogram for each of the Location Sources. BUG= 668923 Review-Url: https://codereview.chromium.org/2576633002 Cr-Commit-Position: refs/heads/master@{#441323} [modify] https://crrev.com/5b6572e3c0aba3d558e173440bd644b2e4b9bd04/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java [modify] https://crrev.com/5b6572e3c0aba3d558e173440bd644b2e4b9bd04/tools/metrics/histograms/histograms.xml
,
Jan 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e21b84f9d52d63c3a5e4d89d8316534669c756af commit e21b84f9d52d63c3a5e4d89d8316534669c756af Author: pdyson <pdyson@chromium.org> Date: Sat Jan 07 01:49:43 2017 Remove incognito data from the Geolocation.Header.* histograms. Also, for Geolocation.Header.PermissionState separate out the unsuitable url and not-https cases in the histogram. BUG= 668923 Review-Url: https://codereview.chromium.org/2594443002 Cr-Commit-Position: refs/heads/master@{#442134} [modify] https://crrev.com/e21b84f9d52d63c3a5e4d89d8316534669c756af/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java [modify] https://crrev.com/e21b84f9d52d63c3a5e4d89d8316534669c756af/tools/metrics/histograms/histograms.xml
,
Jan 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9257a44a111510a6f5121e398b17b6426e93a514 commit 9257a44a111510a6f5121e398b17b6426e93a514 Author: pdyson <pdyson@chromium.org> Date: Mon Jan 09 23:39:46 2017 Add missing "." in Geolocation.Header.LocationAge* histograms. BUG= 668923 Review-Url: https://codereview.chromium.org/2620633003 Cr-Commit-Position: refs/heads/master@{#442405} [modify] https://crrev.com/9257a44a111510a6f5121e398b17b6426e93a514/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java
,
Jan 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0637efffc148042848a1b1977668e42c2a73e5b2 commit 0637efffc148042848a1b1977668e42c2a73e5b2 Author: pdyson <pdyson@chromium.org> Date: Tue Jan 10 22:23:21 2017 For Geolocation.Header.TimeListening.* histograms change bucket for no location. Instead of using the last bucket, use the first bucket when no location is available. BUG= 668923 Review-Url: https://codereview.chromium.org/2620813002 Cr-Commit-Position: refs/heads/master@{#442709} [modify] https://crrev.com/0637efffc148042848a1b1977668e42c2a73e5b2/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java [modify] https://crrev.com/0637efffc148042848a1b1977668e42c2a73e5b2/tools/metrics/histograms/histograms.xml
,
Jan 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/07023fe24b20ec9ac60ed4fc72ef569e19e38b87 commit 07023fe24b20ec9ac60ed4fc72ef569e19e38b87 Author: pdyson <pdyson@chromium.org> Date: Fri Jan 13 08:18:11 2017 Change the method of getting Location Mode for Geolocation histograms. Changing to a method that works even when the app permission is not "allowed". For KitKat and later using getInt with LOCATION_MODE to get the location mode. Versions pre KitKat do not have this. So for those versions using getString with LOCATION_PROVIDER_ALLOWED to get the same information. BUG= 668923 Review-Url: https://codereview.chromium.org/2621223002 Cr-Commit-Position: refs/heads/master@{#443517} [modify] https://crrev.com/07023fe24b20ec9ac60ed4fc72ef569e19e38b87/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java
,
Jan 30 2017
The work is completed. |
||||
►
Sign in to add a comment |
||||
Comment 1 by pdyson@chromium.org
, Nov 28 2016