DelegatedFrameHost should implement MojoCompositorFrameSink, RendererCompositorFrameSink should implement MojoCompositorFrameSinkClient |
||||||||||||||
Issue descriptionAs an incremental step to introducing a single "CompositorFrameSinkSupport" class, DelegatedFrameHost should implement MojoCompositorFrameSink, RendererCompositorFrameSink should implement MojoCompositorFrameSinkClient. "compositor_frame_sink_id" can go away because it's really the "connection_id" and that's implicit in the mojo MessagePipe.
,
Dec 1 2016
,
Dec 3 2016
Now that CompositorFrameSinkSupport has landed, it might make sense to go in the opposite direction: Use CompositorFrameSinkSupport first, then transition to mojo.
,
Jan 22 2017
,
Jan 23 2017
,
Jan 26 2017
,
Feb 6 2017
,
Feb 6 2017
I should add some more detail on the intended goal here as it isn't clear from the bug description. Ultimately, DelegatedFrameHost, will go away, and be replaced by components/display_compositor/gpu_offscreen_compositor_frame_sink.{cc|h} and friends but we need to make sure we have the right CompositorFrameSink and DisplayCompositor API to accommodate all the functionality in there.
Some currently missing functionality includes"
1. Copy requests
2. Frame eviction
3. CompositorLock
All of these are currently being actively worked on. Once complete, it ought to be trivial to use CompositorFrameSinkSupport in DelegatedFrameHost and ultimately (separately) replace DelegatedFrameHost with GpuOffscreenCompositorFrameSink
,
Feb 6 2017
Now that there is GpuCompositorFrameSink. And renderer will submit frame data into GPU process directly. Why DelegatedFrameHost is required?
,
Feb 6 2017
Chrome running in Mus+Ash uses GpuCompositorFrameSink, but Chrome outside of Mus+Ash uses DelegatedFrameHost. GpuCompositorFrameSink is incomplete and Mus+Ash is still behind a flag and so it's not used it production. In order to validate the new API, and verify correctness and mojo serialization performance in isolation from the rest of the Mus+Ash changes, I am proposing here that we refactor DelegatedFrameHost to look like GpuCompositorFrameSink, add additional functionality to GpuCompositorFrameSink as need be, and then ultimately replace DelegatedFrameHost with GpuCompositorFrameSink on all platforms.
,
Feb 25 2017
,
Apr 19 2017
,
May 3 2017
,
May 23 2017
,
Jun 12 2017
RendererCompositorFrameSink is gone. DelegatedFrameHost is being replaced by code that will run out of process/thread from the browser process, rather than implement a CompositorFrameSink.
,
Jun 13 2017
,
Feb 26 2018
,
Feb 26 2018
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by fsam...@chromium.org
, Nov 28 2016