Implement WebBluetooth descriptor.readValue()
https://codereview.chromium.org/2634773002
Let's use https://codereview.chromium.org/2637343002
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2fe05521add5347b1024ca582045447cc469325 commit a2fe05521add5347b1024ca582045447cc469325 Author: dougt <dougt@chromium.org> Date: Fri Jan 27 05:35:30 2017 Implement WebBluetooth descriptor.readValue() A GATT Descriptor provides further information about a characteristic's value. For each characteristic there may be many descriptors as defined by https://webbluetoothcg.github.io/web-bluetooth/#bluetoothremotegattdescriptor. In Bug 660699 , we added support for accessing descriptors from characteristics. In this CL, we add support for reading the value of the descriptor. BUG= 668837 R=scheib Review-Url: https://codereview.chromium.org/2637343002 Cr-Commit-Position: refs/heads/master@{#446603} [modify] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/content/browser/bad_message.h [modify] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/content/browser/bluetooth/bluetooth_metrics.cc [modify] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/content/browser/bluetooth/bluetooth_metrics.h [modify] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/content/browser/bluetooth/web_bluetooth_service_impl.cc [modify] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/content/browser/bluetooth/web_bluetooth_service_impl.h [modify] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc [modify] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-descriptor-is-blocklisted.html [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-descriptor-is-removed.html [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-device-goes-out-of-range.html [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-device-disconnects-before.html [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-device-disconnects-during-error.html [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-device-disconnects-during-success.html [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-device-reconnects-during-error.html [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-device-reconnects-during-success.html [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-disconnect-called-before.html [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-disconnect-called-during-error.html [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-disconnect-called-during-success.html [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-fails.html [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-garbage-collection-ran-during-error.html [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-garbage-collection-ran-during-success.html [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-reconnect-during-error.html [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-reconnect-during-success.html [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-service-is-removed.html [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/read-succeeds.html [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/read-updates-value.html [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/descriptor-is-blocklisted.js [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/descriptor-is-removed.js [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/device-goes-out-of-range.js [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/io-op-device-disconnects-before.js [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/io-op-device-disconnects-during-error.js [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/io-op-device-disconnects-during-success.js [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/io-op-device-reconnects-during-error.js [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/io-op-device-reconnects-during-success.js [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/io-op-disconnect-called-before.js [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/io-op-disconnect-called-during-error.js [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/io-op-disconnect-called-during-success.js [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/io-op-fails.js [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/io-op-garbage-collection-ran-during-error.js [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/io-op-garbage-collection-ran-during-success.js [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/io-op-reconnect-during-error.js [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/io-op-reconnect-during-success.js [add] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/service-is-removed.js [modify] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp [modify] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h [modify] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp [modify] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp [modify] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.cpp [modify] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.h [modify] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp [modify] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp [modify] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.cpp [modify] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.h [modify] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom [modify] https://crrev.com/a2fe05521add5347b1024ca582045447cc469325/tools/metrics/histograms/histograms.xml
Comment 1 by rbyers@chromium.org
, Nov 28 2016