New issue
Advanced search Search tips

Issue 668835 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Missing "Exit Fullscreen" Option in Fullscreen mode while viewing pdfs

Reported by giffordc...@gmail.com, Nov 26 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.99 Safari/537.36

Steps to reproduce the problem:
1. Open a pdf with the internal viewer
2. Click on the full screen button in the Chrome menu
3. Right click or long press to view context menu

What is the expected behavior?
As per  issue 594868 , there should be a menu item for "Exit fullscreen"

What went wrong?
The "Exit Fullscreen" menu item is missing.

Did this work before? N/A 

Chrome version: 54.0.2840.99  Channel: stable
OS Version: 10.0
Flash Version: Shockwave Flash 23.0 r0
 
Components: -UI UI>Browser>FullScreen
Labels: Needs-Triage-M54 M-54
Labels: -M-54 hasbisect-per-revision M-55 OS-Linux OS-Mac
Owner: sadrul@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 10, Mac 10.12 and Ubuntu 14.04 using chrome reported version #54.0.2840.99 but the same is not reproducible in the latest canary #57.0.2936.0.

Reverse Bisect Information:
=====================
Good build: 55.0.2873.0  Revision(421052)
Bad Build : 55.0.2872.0  Revision(420859)

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/eba3cbe288ece8495c50a5793b4164bb328d7096..5b860bd1502a646db283473be4d68d275d51a002

From the above change log possible CL that fixed this issue:

Review-Url: https://codereview.chromium.org/2366623002

sadrul@ - Could you please check and merge the fix to M55 if it is a valid candidate.

Thanks...!!

Comment 3 by sadrul@chromium.org, Nov 30 2016

Cc: dsinclair@chromium.org
Owner: thestig@chromium.org
That CL is not related.

Since pdf is involved -> thestig@/dsinclair@, although the issue maybe with fullscreen instead?
Status: Fixed (was: Assigned)
I already fixed this in r420961 without filing a bug for it in the first place. Please wait for Chrome 55 or newer.

The change log URL in comment 2 is wrong, it should have been https://chromium.googlesource.com/chromium/src/+log/55.0.2872.0..55.0.2873.0?pretty=fuller&n=10000 where you would have easily found my fix.

Sign in to add a comment