Problem with standard library on mac: std::inplace_merge is not stable
Reported by
dyaros...@yandex-team.ru,
Nov 26 2016
|
|||||||||
Issue description
The version of clang that I'm using seems to have a bug in the implementation. (of course there is a p
The standard requires std::inplace_merge to be stable, however the result of the attached example is:
[{1,0}, {2,1}, {2,0}, {3,0}, {4,0}, ]
When it should be:
[{1,0}, {2,0}, {2,1}, {3,0}, {4,0}, ]
,
Nov 27 2016
Bug in llvm: https://llvm.org/bugs/show_bug.cgi?id=31166#c1
,
Nov 27 2016
,
Nov 29 2016
mac triage: Does this bug affect chromium? i.e., does someone in chromium need to own getting it fixed / applying a workaround / etc?
,
Nov 29 2016
I did a quick grep over our sources and haven't found the usage of this algorithm (it's not very known and does not have lots of use cases). However, maybe we should do something.
,
Dec 7 2016
Thank you for providing more feedback. Adding requester "ellyjones@chromium.org" for another review and adding "Needs-Review" label for tracking. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 7 2016
thakis@, do you think we should do anything about this?
,
Dec 7 2016
We ship libc++ headers with clang, so once this is fixed upstream, we'll pick up the fix quickly. So if this is causing problems for anyone, they should get this fixed upstream.
,
Mar 13 2017
Cleaning up "Needs-Review" label as we are not using this label for triage anymore. Ref bug for this cleanup 684919
,
Apr 11 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 11 2018
@jdoerrie actually fixed it in libc++ https://reviews.llvm.org/D32788 in August last year. Does anyone know whether we have this updated on all relevant platforms?
,
Apr 11 2018
Looks like third_party/llvm-build/Release+Asserts/include/c++/v1/algorithm (used on mac) and buildtools/third_party/libc++/trunk/include/algorithm (used on linux) have the fix. I don't have the android sdk on my laptop, and on android we're still using ndk libc++ instead of the one in buildtools ( bug 767901 tracks switching). Can someone check the ndk's libc++?
,
Apr 12 2018
I'm not quite sure if I'm looking in the right place, but https://android.googlesource.com/platform/external/libcxx/+/ndk/include/algorithm#753 does not have my fix yet. The last change to include/algorithm was https://android.googlesource.com/platform/external/libcxx/+/0d6a92ed81471b5c69572873e2e38c8ad78575ed, which is the last commit to include/algorithm before my fix: https://github.com/llvm-mirror/libcxx/commit/25a78dcd773ce509469a2b892adbeac0c230cdb9#diff-2fe689a5b4ef8c00d7e2149538b0153b
,
Apr 16 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by dyaros...@yandex-team.ru
, Nov 26 2016