New issue
Advanced search Search tips

Issue 668771 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

CVox+Shift+H on Chrome OS toggles high contrast mode instead of previous heading

Reported by nimerjaber1@gmail.com, Nov 26 2016

Issue description

Mode: force_next
Version: 57.0.2926.0
Reproduction Steps: 
1. google.com
2. Search for Coke.
3. CVox+H to jump to the next heading... repeat a couple of times.
4. CVox+Shift+H to jump back a heading.
Expected: CVox will jump back a heading.
Actual: CVox announces that high contrast mode has been enabled.
 

Comment 1 by chaok@google.com, Dec 5 2016

Cc: lpalmaro@chromium.org
Labels: -Pri-2 phase4 Pri-1
Owner: dtseng@chromium.org
Search+Shift+H keybinding seems to be mapped to 2 events:
1. previous heading if cvox2 is enabled
2. toggles high-contrast mode regardless of cvox2 state

When cvox2 user envokes this command, high-contrast mode is toggled, and previous heading is focused/uttered. I'd argue that cvox2 keybindings should take priority when it's enabled and OS commands should require pass through key.
Owner: dmazz...@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa04240e9ca5c26709789a3ebfb5ed522a1d4355

commit fa04240e9ca5c26709789a3ebfb5ed522a1d4355
Author: dtseng <dtseng@chromium.org>
Date: Tue Dec 06 18:36:13 2016

Ensure spoken feedback keyboard hooks prevent re-injection of key up events

Due to the way we handle keyboard events, we need to explicitly handle prevention of both key down and key up events in js.

If we do not, accelerators that happen to trigger via release e.g. the high contrast shortcut, will activate.

BUG= 668771 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2552013003
Cr-Commit-Position: refs/heads/master@{#436653}

[modify] https://crrev.com/fa04240e9ca5c26709789a3ebfb5ed522a1d4355/chrome/browser/resources/chromeos/chromevox/cvox2/background/keyboard_handler.js

Labels: Merge-Request-56
Owner: dtseng@chromium.org
Status: fixed (was: Unconfirmed)

Comment 5 by dimu@chromium.org, Dec 7 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 6 by sheriffbot@chromium.org, Dec 12 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 12 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5406e90c70e3030c25a654c5c056cf74f820bfef

commit 5406e90c70e3030c25a654c5c056cf74f820bfef
Author: David Tseng <dtseng@chromium.org>
Date: Mon Dec 12 18:48:19 2016

Merge to m56: Ensure spoken feedback keyboard hooks prevent re-injection of key up events

Due to the way we handle keyboard events, we need to explicitly handle prevention of both key down and key up events in js.

If we do not, accelerators that happen to trigger via release e.g. the high contrast shortcut, will activate.

BUG= 668771 
TBR=dtseng@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2552013003
Cr-Commit-Position: refs/heads/master@{#436653}
(cherry picked from commit fa04240e9ca5c26709789a3ebfb5ed522a1d4355)

Review-Url: https://codereview.chromium.org/2566253002 .
Cr-Commit-Position: refs/branch-heads/2924@{#462}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/5406e90c70e3030c25a654c5c056cf74f820bfef/chrome/browser/resources/chromeos/chromevox/cvox2/background/keyboard_handler.js

Status: Verified (was: Fixed)
verified on 57.0.2957.0

Sign in to add a comment