New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 668741 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 632199



Sign in to add a comment

Use a Java pref for TOS accepted tracking on Android

Project Member Reported by asvitk...@chromium.org, Nov 25 2016

Issue description

Use a Java pref for TOS accepted tracking on Android.

This will allow showing the FRE before native is initialized, which is necessary for crbug.com/632199.

Filing a separate bug for this because we may want to merge this change to an earlier milestone.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03e06cc174fe2cbba5fab1291442e470e5e94b09

commit 03e06cc174fe2cbba5fab1291442e470e5e94b09
Author: asvitkine <asvitkine@chromium.org>
Date: Wed Nov 30 16:23:59 2016

Add TOS-accepted Java pref on Android.

This will support being able to show the first page of the
FRE without native code being initialized yet, so that we
could fetch a variations seed while it's showing, which I'm
working on under crbug.com/632199

This change adds a Java-level pref for TOS-accepted, so it
can be checked before native is initialized. Also makes the
code sync the existing native pref to the Java pref for users
migrating from old versions. (We may want to merge this CL
back ahead of the main FRE de-nativization work so that users
can migrate their prefs ahead of time.)

BUG= 668741 

Review-Url: https://codereview.chromium.org/2531743003
Cr-Commit-Position: refs/heads/master@{#435283}

[modify] https://crrev.com/03e06cc174fe2cbba5fab1291442e470e5e94b09/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunGlueImpl.java
[modify] https://crrev.com/03e06cc174fe2cbba5fab1291442e470e5e94b09/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java

Status: Fixed (was: Started)
Labels: M-57
This landed in M57.
Labels: M-56 Merge-Request-56
Asking to merge this because this fixes Finch not working when Backup & Restore happens - which is needed for crbug.com/669543 - see details there.

Project Member

Comment 5 by sheriffbot@chromium.org, Jan 9 2017

Labels: -Merge-Request-56 Hotlist-Merge-Approved Merge-Approved-56
Your change meets the bar and is auto-approved for M56. Please go ahead and merge the CL manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 9 2017

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4fc556210b701b9da0c446212f753c707723655

commit e4fc556210b701b9da0c446212f753c707723655
Author: Alexei Svitkine <asvitkine@chromium.org>
Date: Mon Jan 09 20:23:06 2017

Add TOS-accepted Java pref on Android.

This will support being able to show the first page of the
FRE without native code being initialized yet, so that we
could fetch a variations seed while it's showing, which I'm
working on under crbug.com/632199

This change adds a Java-level pref for TOS-accepted, so it
can be checked before native is initialized. Also makes the
code sync the existing native pref to the Java pref for users
migrating from old versions. (We may want to merge this CL
back ahead of the main FRE de-nativization work so that users
can migrate their prefs ahead of time.)

BUG= 668741 

Review-Url: https://codereview.chromium.org/2531743003
Cr-Commit-Position: refs/heads/master@{#435283}
(cherry picked from commit 03e06cc174fe2cbba5fab1291442e470e5e94b09)

Review-Url: https://codereview.chromium.org/2623643002 .
Cr-Commit-Position: refs/branch-heads/2924@{#705}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/e4fc556210b701b9da0c446212f753c707723655/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunGlueImpl.java
[modify] https://crrev.com/e4fc556210b701b9da0c446212f753c707723655/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java

Sign in to add a comment