alert boxes inaccessible if window is mostly off-screen
Reported by
thesager...@gmail.com,
Nov 25 2016
|
|||||
Issue descriptionChrome Version : 54.0.2840.99 (Official Build) m (64-bit) URLs (if applicable) : https://www.google.com/webhp?sourceid=chrome-instant&ion=1&espv=2&ie=UTF-8#q=five%20minute%20timer What steps will reproduce the problem? (1) In Windows 10, drag a Chrome browser window so that the window is mostly off-screen. (2) Navigate to a page that opens an alert box when closed. (3) Close the page What is the expected result? The page displays an alert box that the user can interact with. What happens instead? The window becomes immobile due to the alert box, with the alert box hidden and unreachable by the user.
,
Nov 28 2016
,
Nov 28 2016
The JavaScript dialog implementation for onbeforeunload on Views uses MODAL_TYPE_SYSTEM, so this is a Views issue. Scott, do you know a Views person who could look at this?
,
Nov 28 2016
Maybe Allen or Rob?
,
Nov 30 2016
A system modal dialog? That's a bit of overkill, no? Is that by design?
,
Nov 30 2016
That's what we have today. JavaScript dialogs have to be that way because of renderer blocking (although I'm doing work in auto-dismissing dialogs to help alleviate the pain), and I'm not sure if strictly speaking onbeforeunload dialogs have to work that way, but they do today.
,
Nov 30 2016
The dialog's position at least should be forced onto the desktop.
,
Dec 1 2016
CL opened for review: https://codereview.chromium.org/2549543002/
,
Dec 16 2016
,
Dec 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51116b9a03e97df9962af7b22e0f3661dbd6efb3 commit 51116b9a03e97df9962af7b22e0f3661dbd6efb3 Author: kylixrd <kylixrd@chromium.org> Date: Fri Dec 16 16:48:10 2016 Clamp dialog bounds to be fully visible on the nearest display If a displayed modal dialog is partially or entirely off-screen, the user may be unable to interact with it or even be aware of its presence. This change ensures that the dialog is moved to the nearest display so that it is fully visible to the user. BUG= 668734 Review-Url: https://codereview.chromium.org/2549543002 Cr-Commit-Position: refs/heads/master@{#439127} [modify] https://crrev.com/51116b9a03e97df9962af7b22e0f3661dbd6efb3/components/constrained_window/BUILD.gn [modify] https://crrev.com/51116b9a03e97df9962af7b22e0f3661dbd6efb3/components/constrained_window/DEPS [modify] https://crrev.com/51116b9a03e97df9962af7b22e0f3661dbd6efb3/components/constrained_window/constrained_window_views.cc [modify] https://crrev.com/51116b9a03e97df9962af7b22e0f3661dbd6efb3/components/constrained_window/constrained_window_views_unittest.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ajha@chromium.org
, Nov 28 2016