Allow setting net/ flags for NavigationHandle |
|||||
Issue descriptionFor NoStatePrefetch we want all redirects to be sent to the network stack with net::LOAD_PREFETCH. In Pre-PlzNavigate as soon as WebContentsImpl::RenderFrameCreated() is called, the PrerenderMsg_SetIsPrerendering tells the renderer that the latter would need to set the flag during navigation. With PlzNavigate the requests are made from the browser without a way to override net flags. The way to override it would be in a new NavigationThrottle's WillStartRequest() to do something like: navigation_handle->SetNetFlags(new::LOAD_PREFETCH)
,
Nov 28 2016
Just occurred to me that URLRequest->priority() also needs to be overridden for NoStatePrefetch navigations. When the user-initiated navigation appears for the same URL/whatever, and the prefetch has not finished, we don't need to update the priority, but will probably want to cancel the low-priority navigation. My understanding is that it should be done with the NavigationThrottle.
,
Dec 9 2016
As per discussion with clamy@, I'm going to try passing the load flags in ChromeNavigationUIData.
,
Dec 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8579b7d7bd148269648d2e5cf469a57e524fcfa commit f8579b7d7bd148269648d2e5cf469a57e524fcfa Author: droger <droger@chromium.org> Date: Tue Dec 13 12:26:55 2016 [PlzNavigate] Wire page visibility info to navigation requests BUG= 668714 TBR=jochen CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2572453002 Cr-Commit-Position: refs/heads/master@{#438142} [modify] https://crrev.com/f8579b7d7bd148269648d2e5cf469a57e524fcfa/content/browser/DEPS [modify] https://crrev.com/f8579b7d7bd148269648d2e5cf469a57e524fcfa/content/browser/frame_host/navigation_request.cc [modify] https://crrev.com/f8579b7d7bd148269648d2e5cf469a57e524fcfa/content/browser/frame_host/navigation_request_info.cc [modify] https://crrev.com/f8579b7d7bd148269648d2e5cf469a57e524fcfa/content/browser/frame_host/navigation_request_info.h [modify] https://crrev.com/f8579b7d7bd148269648d2e5cf469a57e524fcfa/content/browser/loader/navigation_url_loader_unittest.cc [modify] https://crrev.com/f8579b7d7bd148269648d2e5cf469a57e524fcfa/content/browser/loader/resource_dispatcher_host_impl.cc [modify] https://crrev.com/f8579b7d7bd148269648d2e5cf469a57e524fcfa/content/browser/loader/resource_dispatcher_host_unittest.cc
,
Dec 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78a01d19d3321e75787d5d77a0e4e7006d1269c9 commit 78a01d19d3321e75787d5d77a0e4e7006d1269c9 Author: droger <droger@chromium.org> Date: Thu Dec 15 17:12:32 2016 [PlzNavigate] Use WebContentsGetter in PrerenderResourceThrottle BUG= 668714 , 673771 Review-Url: https://codereview.chromium.org/2576443002 Cr-Commit-Position: refs/heads/master@{#438854} [modify] https://crrev.com/78a01d19d3321e75787d5d77a0e4e7006d1269c9/chrome/browser/prerender/prerender_resource_throttle.cc [modify] https://crrev.com/78a01d19d3321e75787d5d77a0e4e7006d1269c9/chrome/browser/prerender/prerender_resource_throttle.h
,
Dec 16 2016
This is fixed. The test still pass, but now without cheating.
,
Dec 22 2016
The bug is marked as fixed, but when I run NoStatePrefetchBrowserTest.PrefetchLoadFlag & NoStatePrefetchBrowserTest.Prefetch301LoadFlags with PlzNavigate enabled, the load flags are still not set. Is this normal?
,
Dec 22 2016
right, let's keep it open, as the browser-side-navigation.linux.browser_tests.filter mentions this bug
,
Dec 22 2016
There is a proposed fix which droger@ did not send to me yet: https://codereview.chromium.org/2566163002/
,
Dec 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/188ee52fe018eb15ea8489956c1be4431cde2384 commit 188ee52fe018eb15ea8489956c1be4431cde2384 Author: pasko <pasko@chromium.org> Date: Fri Dec 23 17:43:41 2016 [PlzNavigate] Add load flags for prefetch navigations This is a straightforward rebase of: https://codereview.chromium.org/2566163002/ BUG= 668714 Review-Url: https://codereview.chromium.org/2602573002 Cr-Commit-Position: refs/heads/master@{#440645} [modify] https://crrev.com/188ee52fe018eb15ea8489956c1be4431cde2384/chrome/browser/prerender/prerender_resource_throttle.cc [modify] https://crrev.com/188ee52fe018eb15ea8489956c1be4431cde2384/chrome/browser/prerender/prerender_resource_throttle.h [modify] https://crrev.com/188ee52fe018eb15ea8489956c1be4431cde2384/testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter
,
Jan 2 2017
,
Jan 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2cdce4467fb89b77f62b3b042b5cdfd19739f13 commit c2cdce4467fb89b77f62b3b042b5cdfd19739f13 Author: pasko <pasko@chromium.org> Date: Mon Jan 23 13:18:41 2017 Prerender: Add thread checks to PrerenderResourceThrottle These are small followup changes for: https://codereview.chromium.org/2602573002/ Adds DCHECK_CURRENTLY_ON() to the methods of the class as requested in the previous codereview. Also fixes a typo. BUG= 668714 Review-Url: https://codereview.chromium.org/2605503002 Cr-Commit-Position: refs/heads/master@{#445371} [modify] https://crrev.com/c2cdce4467fb89b77f62b3b042b5cdfd19739f13/chrome/browser/prerender/prerender_resource_throttle.cc [modify] https://crrev.com/c2cdce4467fb89b77f62b3b042b5cdfd19739f13/chrome/browser/prerender/prerender_resource_throttle.h |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by pasko@chromium.org
, Nov 25 2016