DCHECK in SavePackage::StartSave
Reported by
yuriy...@gmail.com,
Nov 25 2016
|
||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.116 YaBrowser/16.10.0.2564 Safari/537.36 Steps to reproduce the problem: 1. Open a web page (i.e. ftp://dlink.ru/pub/Router/DIR-300/Firmware/dir300_release_note.txt ) 2. Press Ctrl+S many times repeatedly 3. Execution stops on SavePackage::StartSave DCHECK(canceled()); and crashes debug build here. What is the expected behavior? Sometimes there is a delay between pressing save shortcut and the dialog should appear, so pressing Ctrl+S again can be natural. What went wrong? Failed DCHECK stops browser execution. Crashed report ID: no How much crashed? Whole browser Is it a problem with a plugin? No Did this work before? No Chrome version: 53.0.2785.116 Channel: dev OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: Shockwave Flash 23.0 r0 In release version it seems the issue doesn't have any consequences. But maybe it worth to investigate it and fix for debug builds.
,
Nov 29 2016
Could you please provide the crash id from chrome://crashes.
,
Nov 30 2016
,
Dec 2 2016
Sorry, I've messed up with steps. Here the correct one: 1. Open not-html page, as text at ftp://dlink.ru/pub/Router/DIR-300/Firmware/dir300_release_note.txt 2. Press Ctrl+S, in dialog choose any name and replace file if you had it saved. 3. Press Ctrl+S after dialog just disappear. crash id: e87be8ee-f554-4755-b538-1cdd9eefde51 .
,
Dec 5 2016
Tested the issue on windows 7 & 10 using chrome stable M55 #55.0.2883.75 and didn't see any crash while saving the given URL using ctrl+S many times. Tested in reported version also . Attached screencast for reference. @yuriy709 -- Could you please check the screencast and let us know if we had missed out any steps to reproduce and also check in the latest stable if you can still reproduce the issue. Thanks!
,
Dec 7 2016
I don't know if there is application that captures and shows key pressed, I pressed Ctrl+S as soon as I confirmed override in save dialog. As this issues caused by DCHECK you must run either debug builds or with DCHECK's enabled. My build was based on stable branch, here the lastest commits: commit 543a3be1be43bf23fbca2140ad90d18ee7ec6655 Author: djkurtz <djkurtz@chromium.org> Date: Wed Nov 30 06:17:34 2016 -0800 commit de09bb7918768dcb4d73b1183c3ab7c1526696bb Author: ryansturm <ryansturm@chromium.org> Date: Wed Nov 30 06:16:34 2016 -0800 commit 2ccb52078094f6e0af7384ace1e4f14237a193b0 Author: alexilin <alexilin@chromium.org> Date: Wed Nov 30 06:13:41 2016 -0800 commit e42c5acc8c61a87e6a72352d2428b3f477bd73c1 Author: ryansturm <ryansturm@chromium.org> Date: Wed Nov 30 06:10:22 2016 -0800
,
Dec 14 2016
Thank you for providing more feedback. Adding requester "jmukthavaram@chromium.org" for another review and adding "Needs-Review" label for tracking. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 20 2016
Per C#7, issue is specific to debug build and works fine on release build.
,
Feb 13 2018
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by davidben@chromium.org
, Nov 28 2016