Incorrect parameters for WebRTC echo detector |
||||||
Issue descriptionVersion: M56 OS: All The parameters used in the echo detector in M56 are wrong, and they cause the echo detector to not work. Additionally there is an issue with early spikes in the detected echo likelihood. These two small WebRTC CLs fix these issues: https://codereview.webrtc.org/2506643002/ and https://codereview.webrtc.org/2503843004/
,
Nov 26 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Nov 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/cdf05deecdbe26d1867ae53a5f9d12235bb37d1b commit cdf05deecdbe26d1867ae53a5f9d12235bb37d1b Author: ivoc <ivoc@webrtc.org> Date: Mon Nov 28 15:01:31 2016 Update the alpha value in the echo detector. BUG= webrtc:6525 , chromium:668704 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.webrtc.org/2506643002 Cr-Commit-Position: refs/heads/master@{#15136} (cherry picked from commit 765edc34257a439bb3d9acc7d4c6aaf205b4e11f) Review-Url: https://codereview.webrtc.org/2536553003 Cr-Commit-Position: refs/branch-heads/56@{#3} Cr-Branched-From: 613152af11d6e9a4d046af3c48a7be7642dfcc68-refs/heads/master@{#15101} [modify] https://crrev.com/cdf05deecdbe26d1867ae53a5f9d12235bb37d1b/webrtc/modules/audio_processing/echo_detector/mean_variance_estimator.cc [modify] https://crrev.com/cdf05deecdbe26d1867ae53a5f9d12235bb37d1b/webrtc/modules/audio_processing/echo_detector/mean_variance_estimator_unittest.cc [modify] https://crrev.com/cdf05deecdbe26d1867ae53a5f9d12235bb37d1b/webrtc/modules/audio_processing/echo_detector/normalized_covariance_estimator.cc [modify] https://crrev.com/cdf05deecdbe26d1867ae53a5f9d12235bb37d1b/webrtc/modules/audio_processing/residual_echo_detector_unittest.cc
,
Nov 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/6700a43664850d7ed99cd164bc281f557330e244 commit 6700a43664850d7ed99cd164bc281f557330e244 Author: ivoc <ivoc@webrtc.org> Date: Mon Nov 28 15:49:58 2016 Add a reliability term to the echo detector. This will ensure that the estimated likelihood starts at a low value and prevents initial spikes. BUG= webrtc:6525 , chromium:668704 TBR=henrik.lundin@webrtc.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.webrtc.org/2503843004 Cr-Commit-Position: refs/heads/master@{#15131} (cherry picked from commit fbb374d8ed961f055d9ec71a25e0bb77991e6ec3) Review-Url: https://codereview.webrtc.org/2535833002 Cr-Commit-Position: refs/branch-heads/56@{#4} Cr-Branched-From: 613152af11d6e9a4d046af3c48a7be7642dfcc68-refs/heads/master@{#15101} [modify] https://crrev.com/6700a43664850d7ed99cd164bc281f557330e244/webrtc/modules/audio_processing/residual_echo_detector.cc [modify] https://crrev.com/6700a43664850d7ed99cd164bc281f557330e244/webrtc/modules/audio_processing/residual_echo_detector.h [modify] https://crrev.com/6700a43664850d7ed99cd164bc281f557330e244/webrtc/modules/audio_processing/residual_echo_detector_unittest.cc
,
Nov 30 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 4 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 5 2016
,
Dec 5 2016
,
Jan 12 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ivoc@chromium.org
, Nov 25 2016