New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 668680 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

"Providers/FileManagerBrowserTest.Test/3" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Nov 25 2016

Issue description

"Providers/FileManagerBrowserTest.Test/3" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyMgsSBUZsYWtlIidQcm92aWRlcnMvRmlsZU1hbmFnZXJCcm93c2VyVGVzdC5UZXN0LzMM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by battre@chromium.org, Nov 29 2016

Cc: oka@chromium.org yoshiki@chromium.org
Owner: mtomasz@chromium.org
Status: Assigned (was: Untriaged)
Assigning to mtomasz who wrote the tests.

Comment 2 by battre@chromium.org, Nov 29 2016

Cc: rdevlin....@chromium.org
[23900:23900:1128/164715:INFO:CONSOLE(0)] "Error in event handler for fileSystemProvider.onGetActionsRequested: ReferenceError: onSucces is not defined
    at chrome-extension://pkplfbidichfdicaijlchgnapepdginl/background.js:52:7", source: chrome-extension://pkplfbidichfdicaijlchgnapepdginl/_generated_background_page.html (0)
[23900:23900:1128/164716:WARNING:merge_session_throttling_utils.cc(138)] Loading content for a profile without session restore?
[23900:23900:1128/164716:WARNING:merge_session_throttling_utils.cc(138)] Loading content for a profile without session restore?
[23900:23900:1128/164716:INFO:CONSOLE(0)] "[SUCCESS] requestMountSourceFile", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/_generated_background_page.html (0)
[23900:23900:1128/164716:FATAL:extension_function.cc(468)] Check failed: !browser_client || browser_client->IsShuttingDown() || did_respond() || ignore_all_did_respond_for_testing_do_not_use. test.sendMessage
#0 0x0000032c3c2e base::debug::StackTrace::StackTrace()
#1 0x0000032db00a logging::LogMessage::~LogMessage()
#2 0x000002ddcf56 UIThreadExtensionFunction::~UIThreadExtensionFunction()
#3 0x000002eed133 extensions::TestSendMessageFunction::~TestSendMessageFunction()
#4 0x000001381e15 file_manager::(anonymous namespace)::FileManagerTestListener::~FileManagerTestListener()
#5 0x000001381b59 file_manager::FileManagerBrowserTestBase::RunTestMessageLoop()
#6 0x000001381585 file_manager::FileManagerBrowserTestBase::StartTest()
#7 0x0000033824a7 InProcessBrowserTest::RunTestOnMainThreadLoop()
#8 0x00000393b578 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#9 0x0000033bffe7 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#10 0x0000033bef81 ChromeBrowserMainParts::PreMainMessageLoopRun()
#11 0x0000017cd150 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#12 0x0000028d0085 content::BrowserMainLoop::PreMainMessageLoopRun()
#13 0x000002c78cf6 content::StartupTaskRunner::RunAllTasksNow()
#14 0x0000028ce677 content::BrowserMainLoop::CreateStartupTasks()
#15 0x0000028d2f27 content::BrowserMainRunnerImpl::Initialize()
#16 0x0000028cbb98 content::BrowserMain()
#17 0x000003260023 content::ContentMainRunnerImpl::Run()
#18 0x00000325eaa0 content::ContentMain()
#19 0x00000393aed0 content::BrowserTestBase::SetUp()
#20 0x000003380b1b InProcessBrowserTest::SetUp()
#21 0x000004095d98 testing::Test::Run()
#22 0x000004096ca0 testing::TestInfo::Run()
#23 0x000004097137 testing::TestCase::Run()
#24 0x00000409e427 testing::internal::UnitTestImpl::RunAllTests()
#25 0x00000409e03a testing::UnitTest::Run()
#26 0x00000338f251 base::TestSuite::Run()
#27 0x0000032b7d1b ChromeTestSuiteRunner::RunTestSuite()
#28 0x000003966d71 content::LaunchTests()
#29 0x0000032b6271 main
#30 0x7fb7265f37ed __libc_start_main
#31 0x000000650c41 <unknown>

Comment 3 by battre@chromium.org, Nov 29 2016

Labels: -Sheriff-Chromium
I think that this is the location that complains about the "ReferenceError: onSuccess is not defined"
https://cs.chromium.org/chromium/src/ui/file_manager/integration_tests/testing_provider/background.js?sq=package:chromium&l=50-53

This is where the fileSystemProvider.onGetActionsRequested handler is called:
https://cs.chromium.org/chromium/src/chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js?q=getActionsRequestedSuccess&sq=package:chromium&l=199-219&dr=C

The strange thing is that I don't see how onSuccess (the second parameter of the callback) could ever be undefined.

Tomasz, can you please take care of fixing or disabling the test? I am not sure how to disable this without butchering the entire test infrastructure.

Thanks.
Status: Started (was: Assigned)
There is an obvious typo - onSucces should be onSuccess.
But the typo is unlikely to cause this flakiness.
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b2e64fbc2af36b1fa878fcd5d0310efc70c3fc9

commit 2b2e64fbc2af36b1fa878fcd5d0310efc70c3fc9
Author: mtomasz <mtomasz@chromium.org>
Date: Thu Dec 08 07:31:25 2016

Fix typo in a Files app tests.

TEST=Providers/FileManagerBrowserTest.Test/3
BUG= 668680 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2546343005
Cr-Commit-Position: refs/heads/master@{#437205}

[modify] https://crrev.com/2b2e64fbc2af36b1fa878fcd5d0310efc70c3fc9/ui/file_manager/integration_tests/testing_provider/background.js

Status: Available (was: Started)
This is not fixed yet. The CL above fixes a minor issue, but it's unlikely to fix the flakiness.
Cc: mtomasz@chromium.org
Labels: from-mtomasz
Owner: fukino@chromium.org

Comment 9 by kbr@chromium.org, Apr 5 2018

Blockedon: 829310

Comment 10 by noel@chromium.org, Apr 17 2018

Cc: noel@chromium.org
Just saw this
 
Providers/FileManagerBrowserTest.Test/1 PASSED and this CHECK at exit.

https://ci.chromium.org/buildbot/tryserver.chromium.chromiumos/linux-chromeos-rel/103902

[8498:8498:0417/084833.664403:INFO:CONSOLE(0)] "[SUCCESS] requestMountMultipleMounts", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/_generated_background_page.html (0)
[8498:8498:0417/084833.673582:FATAL:extension_function.cc(504)] Check failed: !browser_client || browser_client->IsShuttingDown() || did_respond() || ignore_all_did_respond_for_testing_do_not_use. test.sendMessage
#0 0x00000441f15c base::debug::StackTrace::StackTrace()

Comment 11 by noel@chromium.org, Apr 19 2018

Cc: fukino@chromium.org
Labels: Needs-Feedback
Owner: rdevlin....@chromium.org
FTR, This was code was added to the extensions system in

  https://codereview.chromium.org/2017113002

If not entirely sure what to do here.  This check does cause intermittent flakes in the FileManagerBrowserTests test suite.  Any test . can be hit by this.  The result is our tests all get disabled over time by gardeners because they are 1) unsure about what to do, much like me, and 2) must disable by policy in 30 mins.

Help needed: rdevlin.cronin any tips appreciated.

Comment 12 by noel@chromium.org, Apr 19 2018

Components: Platform>Apps>FileManager

Comment 13 by noel@chromium.org, Apr 19 2018

Blockedon: -829310
Not blocked on  issue 829310 , different flake / crash / error there.

Comment 14 by noel@chromium.org, Apr 19 2018

FileDisplay/FileManagerBrowserTest.Test/1
  evidence that other FileManagerBrowserTests can get hit in recent builds

Build:
https://ci.chromium.org/buildbot/tryserver.chromium.chromiumos/linux-chromeos-rel/105448

Log:
https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.chromiumos%2Flinux-chromeos-rel%2F105448%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests__with_patch_%2F0%2Fstdout

Gory log detail:

[ RUN      ] FileDisplay/FileManagerBrowserTest.Test/1
[25264:25306:0419/005521.839231:ERROR:account_manager.cc(37)] Failed to read tokens file
[25264:25264:0419/005521.845053:WARNING:user_policy_manager_factory_chromeos.cc(198)] No policy loaded for known non-enterprise user
[25264:25264:0419/005521.858204:WARNING:user_session_manager.cc(1084)] Attempting to save user password for non enterprise user.
[25264:25264:0419/005521.884936:WARNING:extension.cc(761)] Failed to load extension.  Manifest JSON: {"default_locale":"en","description":"Chrome OS Mobile Activation Resources","incognito":"split","key":"MIGdMA0GCSqGSIb3DQEBAQUAA4GLADCBhwKBgQDITTAJ8zmgRjcmCRIAUbzlrSSzoWPBRY/kaBP3mxZ8nlCMljhQLDDKClnyGK6+krYq8/LayF4r0PR7g0Q27lwvw+asg1BFN+AL+suJqe4jJzxBK3GaMBRsBCCcwpAQw4F82zI9Hk0e6EqfrDq4ePNgv+PsI2MDbOuk3b1vS5oBjQIBIw==","name":"Mobile Activation","permissions":[],"version":"1.0"}
[25264:25264:0419/005521.884978:ERROR:component_loader.cc(256)] The 'manifest_version' key must be present and set to 2 (without quotes). See developer.chrome.com/extensions/manifestVersion.html for details.
[25264:25264:0419/005521.919072:WARNING:extension.cc(761)] Failed to load extension.  Manifest JSON: {"default_locale":"en","description":"Chrome OS Mobile Activation Resources","incognito":"split","key":"MIGdMA0GCSqGSIb3DQEBAQUAA4GLADCBhwKBgQDITTAJ8zmgRjcmCRIAUbzlrSSzoWPBRY/kaBP3mxZ8nlCMljhQLDDKClnyGK6+krYq8/LayF4r0PR7g0Q27lwvw+asg1BFN+AL+suJqe4jJzxBK3GaMBRsBCCcwpAQw4F82zI9Hk0e6EqfrDq4ePNgv+PsI2MDbOuk3b1vS5oBjQIBIw==","name":"Mobile Activation","permissions":[],"version":"1.0"}
[25264:25264:0419/005521.919109:ERROR:component_loader.cc(256)] The 'manifest_version' key must be present and set to 2 (without quotes). See developer.chrome.com/extensions/manifestVersion.html for details.
[25264:25264:0419/005521.929589:ERROR:cros_settings_provider.cc(30)] Ignoring the guest request to change: cros.system.timezone
[25264:25264:0419/005522.000685:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type.
[25264:25264:0419/005522.005757:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type.
[25264:25264:0419/005522.016436:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type.
[25264:25264:0419/005522.016598:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type.
[25264:25264:0419/005522.253113:WARNING:extension.cc(761)] Failed to load extension.  Manifest JSON: {"default_locale":"en","description":"Chrome OS Mobile Activation Resources","incognito":"split","key":"MIGdMA0GCSqGSIb3DQEBAQUAA4GLADCBhwKBgQDITTAJ8zmgRjcmCRIAUbzlrSSzoWPBRY/kaBP3mxZ8nlCMljhQLDDKClnyGK6+krYq8/LayF4r0PR7g0Q27lwvw+asg1BFN+AL+suJqe4jJzxBK3GaMBRsBCCcwpAQw4F82zI9Hk0e6EqfrDq4ePNgv+PsI2MDbOuk3b1vS5oBjQIBIw==","name":"Mobile Activation","permissions":[],"version":"1.0"}
[25264:25264:0419/005522.253304:ERROR:component_loader.cc(256)] The 'manifest_version' key must be present and set to 2 (without quotes). See developer.chrome.com/extensions/manifestVersion.html for details.
[25264:25264:0419/005522.324267:INFO:file_manager_browsertest_base.cc(581)] FileManagerBrowserTest::StartTest file_manager_test_manifest.json
[1,2508662656:07:55:23.910250] Native Client module will be loaded at base address 0x000046ac00000000
[1,2508662656:07:55:28.178183] Native Client module will be loaded at base address 0x00003acb00000000
[1,2508662656:07:55:28.473228] Native Client module will be loaded at base address 0x000062f200000000
ALSA lib confmisc.c:768:(parse_card) cannot find card '0'
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default
[25264:25330:0419/005528.498021:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory
ALSA lib confmisc.c:768:(parse_card) cannot find card '0'
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name
ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default
[25264:25330:0419/005528.498203:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory
[25264:25330:0419/005528.498284:ERROR:audio_output_resampler.cc(396)] Unable to open audio device in high latency mode.  Falling back to fake audio output.
[25264:25264:0419/005528.983763:FATAL:extension_function.cc(504)] Check failed: !browser_client || browser_client->IsShuttingDown() || did_respond() || ignore_all_did_respond_for_testing_do_not_use. test.sendMessage
#0 0x00000442078c base::debug::StackTrace::StackTrace()
#1 0x00000443b6ab logging::LogMessage::~LogMessage()
#2 0x000003284df4 UIThreadExtensionFunction::~UIThreadExtensionFunction()
#3 0x000003411888 extensions::TestSendMessageFunction::~TestSendMessageFunction()
#4 0x0000014aa105 file_manager::(anonymous namespace)::FileManagerTestListener::~FileManagerTestListener()
#5 0x0000014aa06a file_manager::FileManagerBrowserTestBase::RunTestMessageLoop()
#6 0x0000014a97f4 file_manager::FileManagerBrowserTestBase::StartTest()
#7 0x000004a6f4cf content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#8 0x00000457cb5f ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#9 0x00000457b8fa ChromeBrowserMainParts::PreMainMessageLoopRun()
#10 0x000001ab9ad1 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#11 0x000002ba02e1 content::BrowserMainLoop::PreMainMessageLoopRun()
#12 0x000002fd0c95 content::StartupTaskRunner::RunAllTasksNow()
#13 0x000002b9ed62 content::BrowserMainLoop::CreateStartupTasks()
#14 0x000002ba2c03 content::BrowserMainRunnerImpl::Initialize()
#15 0x000002b9c872 content::BrowserMain()
#16 0x0000043d119d content::ContentMainRunnerImpl::Run()
#17 0x000006504a42 service_manager::Main()
#18 0x0000043cee14 content::ContentMain()
#19 0x000004a6f083 content::BrowserTestBase::SetUp()
#20 0x0000045348e3 InProcessBrowserTest::SetUp()
#21 0x000001f34c7d testing::Test::Run()
#22 0x000001f35860 testing::TestInfo::Run()
#23 0x000001f35d67 testing::TestCase::Run()
#24 0x000001f41277 testing::internal::UnitTestImpl::RunAllTests()
#25 0x000001f40dfe testing::UnitTest::Run()
#26 0x000004548bc2 base::TestSuite::Run()
#27 0x000004414245 ChromeTestSuiteRunner::RunTestSuite()
#28 0x000004a90547 content::LaunchTests()
#29 0x000004414704 LaunchChromeTests()
#30 0x0000044141de main
#31 0x7fbff93d1f45 __libc_start_main
#32 0x0000005e487a _start
[942/1029] FileDisplay/FileManagerBrowserTest.Test/1 (CRASHED)

Status: Assigned (was: Available)

Comment 17 by noel@chromium.org, Apr 22 2018

Labels: OS-Chrome

Comment 18 by noel@chromium.org, Apr 24 2018

ASAN build, AudioPlayerBrowserTest.ChangeVolumeLevel in build

https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_chromeos_asan_rel_ng/15567

[16492:16492:0423/152424.323715:FATAL:extension_function.cc(504)] Check failed: !browser_client || browser_client->IsShuttingDown() || did_respond() || ignore_all_did_respond_for_testing_do_not_use. test.sendMessage
Owner: mtomasz@chromium.org
That check is hit when an ExtensionFunction is created and destroyed, but never responds (and also isn't destroyed during e.g. shutdown).  This almost always indicates a bug in the API (or the test), since ExtensionFunctions *should* respond to their callers to indicate success or failure.

In this particular case, the API method is the test.sendMessage function, which sends a message to the browser and optionally waits for a response (e.g., using ExtensionTestMessageListener).

I'm not an owner of the file manager code, so back to mtomasz to dive into this and figure out why the test is sending messages but not responses.  mtomasz@, lemme know if there's more I can do to help.

Comment 20 by noel@chromium.org, Apr 28 2018

Seen in Delete/FileManagerBrowserTest.Test/0 [1], for the record.

[1] http://build.chromium.org/p/tryserver.chromium.chromiumos/builders/linux-chromeos-rel/builds/112328

Comment 21 by noel@chromium.org, Apr 28 2018

Cc: -noel@chromium.org
Owner: noel@chromium.org

Comment 22 by noel@chromium.org, Apr 28 2018

Labels: -from-mtomasz -Needs-Feedback
Reproduced in DEBUG given a few runs:

xvfb-run -s "-screen 0 1024x1024x24" ./out/Debug/browser_tests \
   --gtest_filter="Providers/FileManagerBrowserTest*" --gtest_repeat=20

Note: Google Test filter = Providers/FileManagerBrowserTest.Test/1
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from Providers/FileManagerBrowserTest
[ RUN      ] Providers/FileManagerBrowserTest.Test/1
[93832:93832:0428/013947.287588:ERROR:zygote_host_impl_linux.cc(111)] SUID sandbox binary is missing. Won't be able to adjust OOM scores.
[93832:93857:0428/013953.558954:ERROR:account_manager.cc(36)] Failed to read tokens file
[93832:93832:0428/013953.577612:WARNING:user_policy_manager_factory_chromeos.cc(198)] No policy loaded for known non-enterprise user
[93832:93832:0428/013953.649426:WARNING:user_session_manager.cc(1086)] Attempting to save user password for non enterprise user.
[93832:93832:0428/013955.213228:INFO:file_manager_browsertest_base.cc(614)] FileManagerBrowserTest::StartTest requestMountMultipleMounts
chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/file_manager/background.js (424)
[93832:93832:0428/013957.526191:INFO:CONSOLE(4995)] "Requesting volume list.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (4995)
[93832:93832:0428/013957.528542:INFO:CONSOLE(1169)] "Cache database creating or upgrading.", source: chrome-extension://pmfjbimdmchhbnneeidfognadeopoehp/background_scripts.js (1169)
[93832:93832:0428/013957.604186:INFO:CONSOLE(4327)] "Waiting for the result of openMainWindow", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (4327)
[93832:93832:0428/013957.628431:INFO:CONSOLE(4997)] "Volume list fetched with: 2 items.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (4997)
[93832:93832:0428/013957.629151:INFO:CONSOLE(5007)] "Initializing volume: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5007)
[93832:93832:0428/013957.629624:INFO:CONSOLE(5410)] "Requesting file system.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5410)
[93832:93832:0428/013957.646523:INFO:CONSOLE(5007)] "Initializing volume: drive:drive-user", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5007)
[93832:93832:0428/013957.647233:INFO:CONSOLE(5410)] "Requesting file system.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5410)
[1,4116966720:15:39:57.794972] Native Client module will be loaded at base address 0x000017bd00000000
[93832:93832:0428/013958.154232:INFO:CONSOLE(5458)] "File system obtained: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5458)
[93832:93832:0428/013958.162276:INFO:CONSOLE(5011)] "Initialized volume: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5011)
[93832:93832:0428/013958.206353:INFO:CONSOLE(5458)] "File system obtained: drive:drive-user", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5458)
[93832:93832:0428/013958.211995:INFO:CONSOLE(5011)] "Initialized volume: drive:drive-user", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5011)
[93832:93832:0428/013958.215573:INFO:CONSOLE(5015)] "Initialized all volumes.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5015)
[93832:93832:0428/013958.274379:INFO:CONSOLE(4324)] "Received the result of openMainWindow", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (4324)
Still waiting for the following processes to finish:
	./out/Debug/browser_tests --gtest_also_run_disabled_tests --gtest_filter=Providers/FileManagerBrowserTest.Test/1 --single_process --test-launcher-output=/tmp/.org.chromium.Chromium.69VK7R/resultsGgen8s/test_results.xml --user-data-dir=/tmp/.org.chromium.Chromium.69VK7R/dAy6bjr
[93832:93832:0428/013959.030181:INFO:CONSOLE(0)] "Styling master document from stylesheets defined in HTML Imports is deprecated. Please refer to https://goo.gl/EGXzpw for possible migration paths.", source:  (0)
[93832:93832:0428/014002.434568:INFO:CONSOLE(162)] "at /file_manager/background.js:315:27: The number of file is 0. Not changed.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (162)
[93832:93832:0428/014004.078043:INFO:CONSOLE(5410)] "Requesting file system.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5410)
[93832:93832:0428/014004.173216:INFO:CONSOLE(0)] "Name specified, but not requested.", source: chrome-extension://pkplfbidichfdicaijlchgnapepdginl/_generated_background_page.html (0)
[93832:93832:0428/014004.230427:INFO:CONSOLE(5458)] "File system obtained: provided:pkplfbidichfdicaijlchgnapepdginl:test-fs-1:user", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5458)
[93832:93832:0428/014004.584772:INFO:CONSOLE(30093)] "File watchers not supported for: filesystem:chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/external/pkplfbidichfdicaijlchgnapepdginl%3Atest-fs-1%3Auser/", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/foreground/js/main_scripts.js (30093)
[93832:93832:0428/014005.107791:INFO:CONSOLE(0)] "[SUCCESS] [requestMountMultipleMounts]", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/_generated_background_page.html (0)
[93832:93832:0428/014005.109099:INFO:file_manager_browsertest_base.cc(226)] PASSED: 
[93832:93832:0428/014005.125870:INFO:file_manager_browsertest_base.cc(243)] LATE_MAIL: worker-initialized
[93832:93832:0428/014005.126683:FATAL:extension_function.cc(504)] Check failed: !browser_client || browser_client->IsShuttingDown() || did_respond() || ignore_all_did_respond_for_testing_do_not_use. test.sendMessage
#0 0x7fdc81ea2b8d base::debug::StackTrace::StackTrace()
#1 0x7fdc81bd2eac base::debug::StackTrace::StackTrace()
#2 0x7fdc81c3f38d logging::LogMessage::~LogMessage()
#3 0x00000433855d UIThreadExtensionFunction::~UIThreadExtensionFunction()
#4 0x00000492a693 extensions::TestSendMessageFunction::~TestSendMessageFunction()
#5 0x00000492a6b9 extensions::TestSendMessageFunction::~TestSendMessageFunction()
#6 0x000004339951 content::BrowserThread::DeleteOnThread<>::Destruct<>()
#7 0x000004338815 UIThreadExtensionFunction::Destruct()
#8 0x000004333136 ExtensionFunctionDeleteTraits::Destruct()
#9 0x000001bc5e7c base::RefCountedThreadSafe<>::Release()
#10 0x000001bc5e39 scoped_refptr<>::Release()
#11 0x000001bc520a scoped_refptr<>::~scoped_refptr()
#12 0x000002646063 file_manager::(anonymous namespace)::FileManagerTestListener::Message::~Message()
#13 0x00000264d6cb base::internal::VectorBuffer<>::DestructRange<>()
#14 0x00000264d8ab base::circular_deque<>::DestructRange()
#15 0x00000264d831 base::circular_deque<>::~circular_deque()
#16 0x0000026460c3 file_manager::(anonymous namespace)::FileManagerTestListener::~FileManagerTestListener()
#17 0x000002645c01 file_manager::FileManagerBrowserTestBase::RunTestMessageLoop()
#18 0x000002644dcd file_manager::FileManagerBrowserTestBase::StartTest()
#19 0x00000262b984 file_manager::FileManagerBrowserTest_Test_Test::RunTestOnMainThread()
#20 0x000007348c9c content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#21 0x0000009e66cd _ZN4base8internal13FunctorTraitsIM25RenderViewContextMenuBaseFvvEvE6InvokeIS4_P21RenderViewContextMenuJEEEvT_OT0_DpOT1_
#22 0x0000009e6614 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIM25RenderViewContextMenuBaseFvvEJP21RenderViewContextMenuEEEvOT_DpOT0_
#23 0x00000734af65 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE
#24 0x00000734aeac _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#25 0x0000009d889d _ZNKR4base17RepeatingCallbackIFvvEE3RunEv
#26 0x00000630e3c8 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#27 0x00000630c59e ChromeBrowserMainParts::PreMainMessageLoopRun()
#28 0x0000031cb27d chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#29 0x7fdc7884f4ac content::BrowserMainLoop::PreMainMessageLoopRun()
#30 0x7fdc775bb53d _ZN4base8internal13FunctorTraitsIMN7content12ChildProcessEFvvEvE6InvokeIS5_PS3_JEEEvT_OT0_DpOT1_
#31 0x7fdc775bb484 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN7content12ChildProcessEFvvEJPS5_EEEvOT_DpOT0_
#32 0x7fdc78854db5 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEiOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE
#33 0x7fdc78854cfc _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE
#34 0x7fdc774c464d _ZNKR4base17RepeatingCallbackIFvvEE3RunEv
#35 0x7fdc7960069d content::StartupTaskRunner::RunAllTasksNow()
#36 0x7fdc7884b5ff content::BrowserMainLoop::CreateStartupTasks()
#37 0x7fdc78857013 content::BrowserMainRunnerImpl::Initialize()
#38 0x7fdc78843a3e content::BrowserMain()
#39 0x7fdc7a7808fe content::RunNamedProcessTypeMain()
#40 0x7fdc7a783fda content::ContentMainRunnerImpl::Run()
#41 0x7fdc7a777785 content::ContentServiceManagerMainDelegate::RunEmbedderProcess()
#42 0x7fdc73c44583 service_manager::Main()
#43 0x7fdc7a77d8db content::ContentMain()
#44 0x000007348238 content::BrowserTestBase::SetUp()
#45 0x000006214313 InProcessBrowserTest::SetUp()
#46 0x0000020f538e ExtensionBrowserTest::SetUp()
#47 0x00000264395c file_manager::FileManagerBrowserTestBase::SetUp()
#48 0x0000009630ee _ZN7testing8internal12InvokeHelperIRKNSt3__16vectorIPN12user_manager4UserENS2_9allocatorIS6_EEEENS2_5tupleIJEEEE12InvokeMethodIN8chromeos15MockUserManagerEMSH_KFSB_vEEESB_PT_T0_RKSD_
#49 0x000003cf4f12 testing::internal::HandleExceptionsInMethodIfSupported<>()
#50 0x000003cd8e04 testing::Test::Run()
#51 0x000003cd983d testing::TestInfo::Run()
#52 0x000003cda2ec testing::TestCase::Run()
#53 0x000003cec4f7 testing::internal::UnitTestImpl::RunAllTests()
#54 0x000003cfe42e testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#55 0x000003cf6512 testing::internal::HandleExceptionsInMethodIfSupported<>()
#56 0x000003cec155 testing::UnitTest::Run()
#57 0x00000624ba91 RUN_ALL_TESTS()
#58 0x0000062484eb base::TestSuite::Run()
#59 0x0000061232db ChromeTestSuiteRunner::RunTestSuite()
#60 0x0000061233c3 ChromeTestLauncherDelegate::RunTestSuite()
#61 0x0000073c2cf6 content::LaunchTests()

[0428/014006.485686:ERROR:kill_posix.cc(83)] Unable to terminate process group 93832: No such process (3)
[2/4] Providers/FileManagerBrowserTest.Test/1 (CRASHED)

Added LOGs to the FileManagerBrowserTest helper class FileManagerTestListener to record when the test PASS or FAIL chrome.test message appears.  Then also LOG-ed if any test.sendMessage appeared after the PASS/FAIL message.


[93832:93832:0428/014005.107791:INFO:CONSOLE(0)] "[SUCCESS] [requestMountMultipleMounts]", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/_generated_background_page.html (0)
[93832:93832:0428/014005.109099:INFO:file_manager_browsertest_base.cc(226)] PASSED: 
[93832:93832:0428/014005.125870:INFO:file_manager_browsertest_base.cc(243)] LATE_MAIL: worker-initialized
[93832:93832:0428/014005.126683:FATAL:extension_function.cc(504)] Check failed: !browser_client || browser_client->IsShuttingDown() || did_respond() || ignore_all_did_respond_for_testing_do_not_use. test.sendMessage

Seems a test.sendMessage about 'worker-initialized' sometimes appears after the test PASSED/FAILED.  Dubbed "LATE MAIL", that message is never responded to and causes the CHECK stop as surmised in #19.
Project Member

Comment 23 by bugdroid1@chromium.org, Apr 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a59359507e747e61c620610cd4c9fb110ecba5ac

commit a59359507e747e61c620610cd4c9fb110ecba5ac
Author: Noel Gordon <noel@chromium.org>
Date: Sat Apr 28 10:26:03 2018

Update FileManagerBrowserTestBase to avoid unprocessed messages

base::RunLoop::QuitCurrentWhenIdle() can spin the run loop a few times
before it exits, sufficient to allow any chrome.test.SendMessage calls
arriving _after the test PASS or FAIL messages_ to be queued.

Such messages will not be processed once the message processing sees a
PASS or FAIL message, causing a CHECK in the extensions system code at
exit to remind us that unprocessed test.SendMessage's need a reply.

Fix: use modern base::RunLoop/Closure methods. Add |test_complete_| to
record when test PASS or FAIL messages arrive. Add a CHECK stop to the
test.SendMessage reader code to verify they are never received after a
PASS or FAIL message.

Tbr: mtomasz, slangley
Bug:  668680 
Change-Id: I09cae80870d0471b214253beb2f05e8914fee0aa
Reviewed-on: https://chromium-review.googlesource.com/1034174
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554647}
[modify] https://crrev.com/a59359507e747e61c620610cd4c9fb110ecba5ac/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc

Project Member

Comment 24 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b5f26b679e52c823e474356723d22f24167cb81

commit 3b5f26b679e52c823e474356723d22f24167cb81
Author: Noel Gordon <noel@chromium.org>
Date: Mon Apr 30 02:18:02 2018

Run Providers/FileManagerBrowser test all bots

Persistent flake cause affecting all FileManager browser tests is fixed
by  issue 831074   issue 804413   issue 829310 .

Intermittent flake cause affecting Providers and other FileManger tests
is fixed by crrev.com/554647.

Run the Providers test all bots to help confirm  issue 668680  is gone.

Bug:  668680 ,836254
Change-Id: Ib2eb38cddd454ae0671929da201c70a157f29308
Reviewed-on: https://chromium-review.googlesource.com/1034418
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554688}
[modify] https://crrev.com/3b5f26b679e52c823e474356723d22f24167cb81/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Project Member

Comment 25 by bugdroid1@chromium.org, May 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2eb933a03a798f1bab382dce94cdb38b4a0d6b0b

commit 2eb933a03a798f1bab382dce94cdb38b4a0d6b0b
Author: Noel Gordon <noel@chromium.org>
Date: Tue May 01 22:42:39 2018

Rename command installProviderExtension to launchProviderExtension

crrev.com/555016 changed the C++ browser-test-side code to use the name
LaunchExtension(), rather than InstallExtension(). Change the test code
JS command similarly, use launchProviderExtension.

Also make launchProviderExtension a separate getSetupSteps step because
chrome test.sendMessage always has a reply. We should await it and then
do the next step: setup that next step to call setupAndWaitUntilReady()
as before.

Covered by existing tests: Provider/FileManagerBrowserTest/Test.*

Bug:  833834 , 668680 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0cffa47ae94e46699fd1e92d69dea946686d6ad1
Reviewed-on: https://chromium-review.googlesource.com/1036747
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555205}
[modify] https://crrev.com/2eb933a03a798f1bab382dce94cdb38b4a0d6b0b/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/2eb933a03a798f1bab382dce94cdb38b4a0d6b0b/ui/file_manager/integration_tests/file_manager/providers.js

Comment 26 by noel@chromium.org, May 7 2018

Status: Fixed (was: Assigned)
And... Check failed: !browser_client || browser_client->IsShuttingDown() seems to be gone from the bots, for the last week.


Sign in to add a comment