New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 668632 link

Starred by 1 user
Status: Fixed
Owner:
█ ivoc@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

WebRTC Echo likelihood stat does not propagate to chrome://webrtc-internals page

Project Member Reported by ivoc@chromium.org, Nov 25 2016 
Version: M56
OS: All

What steps will reproduce the problem?
(1) Start a WebRTC call
(2) Look at chrome://webrtc-internals page
(3) Look at Echo likelihood graph

The detected echo likelihood should be shown in the graph, instead it is always zero.

Comment 2 by ivoc@chromium.org, Nov 29 2016

Labels: Merge-Request-56
Status: Fixed (was: Started)

Comment 3 by dimu@chromium.org, Nov 29 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 29 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57b8a38ee2f0baca006d9799508a2dfce55bb3d3

commit 57b8a38ee2f0baca006d9799508a2dfce55bb3d3
Author: Guido Urdaneta <guidou@chromium.org>
Date: Tue Nov 29 13:52:53 2016

Use the new statics interface to get APM stats from WebRTC

This also includes the new residual echo likelihood stat.

BUG= chromium:668632 , webrtc:6525 

Review-Url: https://codereview.chromium.org/2527193002
Cr-Commit-Position: refs/heads/master@{#434493}
(cherry picked from commit b5bc4a4e2967f50790fb378c14d1af668b350448)

Review URL: https://codereview.chromium.org/2540703002 .

Cr-Commit-Position: refs/branch-heads/2924@{#152}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/57b8a38ee2f0baca006d9799508a2dfce55bb3d3/content/renderer/media/media_stream_audio_processor.cc
[modify] https://crrev.com/57b8a38ee2f0baca006d9799508a2dfce55bb3d3/content/renderer/media/media_stream_audio_processor_options.cc
[modify] https://crrev.com/57b8a38ee2f0baca006d9799508a2dfce55bb3d3/content/renderer/media/media_stream_audio_processor_options.h

Comment 5 by anatolid@chromium.org, Jan 12 2017

Labels: M-57
►

Sign in to add a comment