New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 668624 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocking:
issue 626103



Sign in to add a comment

Deploy Git Numberer validator to WebRTC

Project Member Reported by tandrii@chromium.org, Nov 25 2016

Issue description

go/git-numberer will guard against commits with wrong footers
 
Blocking: 626103
Cc: ehmaldonado@chromium.org kjellander@chromium.org

Comment 3 by benhenry@google.com, Nov 28 2016

Labels: Pri-2

Comment 4 by aga...@chromium.org, Nov 29 2016

Labels: Milestone-Fishfood
Status: Started (was: Assigned)
With the help of this primitive tester https://chromium-review.googlesource.com/415305, I pushed all refs with younger than 3 month old commit at their HEADs with *validator enabled*. I think it's fine to add it to production.
PSA to webrtc-eng sent http://g/webrtc-eng/UYSz8iiv87o/XGXrP0s_AgAJ
For WebRTC admins: to disable validation quickly, add
 refs/*
to disable "Disable validation on refs" in https://chromium-review.googlesource.com/#/admin/projects/external/webrtc
(see screenshot attachment). 
Screenshot from 2016-12-01 15:47:52.png
8.3 KB View Download
manual git cl land whitespace https://codereview.webrtc.org/2547553002
Temporary made myself a committer.
Enabled validation on refs/head/master and refs/branch-heads/*
https://chromium.googlesource.com/external/webrtc/+/fd5e77acfd42b7d86e43363d98c2c247a2084b26%5E%21/#F0

Landed manually with git cl -> ok.
Landed with CQ -> OK.
git-drover on branch-heads/56 -> OK.

Removed myself from committers -> on CIA and in Gerrit.
Status: Fixed (was: Started)
I consider this a success so far :) 

Sign in to add a comment