New issue
Advanced search Search tips

Issue 668622 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocking:
issue 613288
issue 626103



Sign in to add a comment

Deploy Git Numberer validator to Chromium

Project Member Reported by tandrii@chromium.org, Nov 25 2016

Issue description

go/git-numberer will guard against commits with wrong footers

FOR GIT ADMINS WHO NEED TO QUCKLY REVERT THIS:
 * **you must be a git admin. If not, contact mdb/chrome-git-admins group**
 * go to https://chromium-review.googlesource.com/#/admin/projects/chromium/src
 * find section "git numberer" and sub-section "Disable validation on refs" (see screenshot)
 * add "refs/*" (without quotation marks)
 * don't forget to click "Save" below.

 
Screenshot from 2016-12-02 14:47:39.png
7.5 KB View Download
Blocking: 626103

Comment 2 by benhenry@google.com, Nov 28 2016

Labels: Pri-2
Status: Started (was: Assigned)
The tests on https://chromium.googlesource.com/playground/gnumbd-src have finished with success (https://chromium-review.googlesource.com/415305 PS#5).

I'll enable this on chromium repo in ~15 minutes.
Description: Show this description
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1aac82a6affbf0a0f2c3281cba9324b101ec8fd

commit e1aac82a6affbf0a0f2c3281cba9324b101ec8fd
Author: tandrii <tandrii@chromium.org>
Date: Fri Dec 02 14:03:47 2016

Whitespace through CQ.

BUG= 668622 
TBR=machenbach@chromium.org
NOTRY=True
NOPRESUBMIT=True

Review-Url: https://codereview.chromium.org/2550513004
Cr-Commit-Position: refs/heads/master@{#435931}

[modify] https://crrev.com/e1aac82a6affbf0a0f2c3281cba9324b101ec8fd/build/whitespace_file.txt

Status: Fixed (was: Started)
Things seem OK. If this has caused trouble, please look at the top of this issue for how to revert.
Blocking: 613288

Sign in to add a comment