Correction:
Good Build: 57.0.2929.0
Bad Build: 57.0.2931.0

Deleted: Actual_sync.mp4 2.2 MB

	Actual_sync.mp4 2.2 MB View Download

Deleted: Exp_sync.mp4 3.0 MB

	Exp_sync.mp4 3.0 MB View Download

Using the per-revision bisect providing the bisect results,
Good build: 57.0.2929.0 (Revision: 434071).
Bad build: 57.0.2931.0 (Revision: 434310).

You are probably looking for a change made after 434286 (known good), but no later than 434287 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/cbe6717b654cfd51f6eec2e12b90a91eb5186775..ff9fc46a4fdfb7c2975c867d8459e3cebe2e32fb

@zmin -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
Adding RB Label as this is a recent Regression. Please remove if not required.

Thank You.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0233a4c8e8eaa98fd46de68f975286b438751211

commit 0233a4c8e8eaa98fd46de68f975286b438751211
Author: zmin <zmin@chromium.org>
Date: Mon Nov 28 16:48:07 2016

Fix the bug which is login dialog won't close after the second sign-in to chrome with different account on the same profile.

This is the follow up of CLs:
1) https://chromium.googlesource.com/chromium/src/+/ff9fc46a4fdfb7c2975c867d8459e3cebe2e32fb
and
2) https://chromium.googlesource.com/chromium/src/+/5db87096a32b73bd2aaca04710152de495ba50ea

The javascript message that close sign in dialog will be sent regardless before. However, after the refactor in the second CL above, it's only sent once the profile_path is not empty. It didn't cause any issue because the JS message will be sent again in the OnClientOAuthSuccess()

However, the OnClientOAuthSuccess' JS message will only be sent while force sign in is enabled after the first CL landed which is used to solve  crbug.com/667227 . It means that if the profile_path is empty (second sign in with different account in the same profile), the sign in dialog will never be closed.

Moving the profile_path empty check into UnlockProfileAndHideLoginUI() so that the javascript message will be sent no matter the profile_path is empty or not.

BUG= 668619 

Review-Url: https://codereview.chromium.org/2528183002
Cr-Commit-Position: refs/heads/master@{#434668}

[modify] https://crrev.com/0233a4c8e8eaa98fd46de68f975286b438751211/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

Verified the fix on Canary(57.0.2936.0).

msrchandra@ Can you also verify it and make sure there is no other new issue? I can request a M56 merge later.

zmin -- Checked the issue on Latest Canary# 57.0.2936.0 on Windows and Mac and is working as intended.
Sign In confirmation pop-up is seen for second user sign.
Adding TE-Verified labels accordingly.
Thank You.

This issue is caused by the CL in  crbug.com/667227 . And it will break the sign in process in M56 once the CL(crrev.com/434287) in  crbug.com/667227  has been merged into M56. So the fix here should be merged into M56 with crrev.com/434287 together.

Your change meets the bar and is auto-approved for M56 (branch: 2924)

Please merge your change to M56 (branch: 2924) ASAP so that we could take it for next Dev Release.

If there is no pending work after merging the CL please remove Merge-Approved-56 label and add merge-merged-2924.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6500dfd08d8152e3d4ea0207d17b0111291489f1

commit 6500dfd08d8152e3d4ea0207d17b0111291489f1
Author: Patrick Monette <pmonette@chromium.org>
Date: Wed Nov 30 23:53:58 2016

Fix the bug which is login dialog won't close after the second sign-in to chrome with different account on the same profile.

This is the follow up of CLs:
1) https://chromium.googlesource.com/chromium/src/+/ff9fc46a4fdfb7c2975c867d8459e3cebe2e32fb
and
2) https://chromium.googlesource.com/chromium/src/+/5db87096a32b73bd2aaca04710152de495ba50ea

The javascript message that close sign in dialog will be sent regardless before. However, after the refactor in the second CL above, it's only sent once the profile_path is not empty. It didn't cause any issue because the JS message will be sent again in the OnClientOAuthSuccess()

However, the OnClientOAuthSuccess' JS message will only be sent while force sign in is enabled after the first CL landed which is used to solve  crbug.com/667227 . It means that if the profile_path is empty (second sign in with different account in the same profile), the sign in dialog will never be closed.

Moving the profile_path empty check into UnlockProfileAndHideLoginUI() so that the javascript message will be sent no matter the profile_path is empty or not.

BUG= 668619 

Review-Url: https://codereview.chromium.org/2528183002
Cr-Commit-Position: refs/heads/master@{#434668}
(cherry picked from commit 0233a4c8e8eaa98fd46de68f975286b438751211)

Review URL: https://codereview.chromium.org/2543843002 .

Cr-Commit-Position: refs/branch-heads/2924@{#229}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/6500dfd08d8152e3d4ea0207d17b0111291489f1/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc