New issue
Advanced search Search tips

Issue 668618 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

<marquee> element attempts to use NaNpx in animation

Project Member Reported by alancutter@chromium.org, Nov 25 2016

Issue description

The patch that adds warnings when keyframes use invalid CSS values in element.animate() has revealed that the code in animations/element-animate-keyframe-value-warning.html causes NaN to be used in keyframe values.
We should fix that.
 
Forgot to link patch: https://codereview.chromium.org/2524303002
Owner: adithyas@chromium.org
This will be fixed by: https://codereview.chromium.org/2549443003/
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a95f76a0318a32bf5bf1153fb291402806c298d1

commit a95f76a0318a32bf5bf1153fb291402806c298d1
Author: adithyas <adithyas@chromium.org>
Date: Tue Dec 06 17:41:43 2016

Move <marquee> implementation to HTMLMarqueeElement.cpp

- Moves HTMLMarqueeElement off Blink-in-JS

- Reimplements HTMLMarqueeElement in C++: implementation matches
  HTMLMarqueeElement.js and uses standard DOM API wherever possible

- Removes HTMLMarqueeElement.js

BUG= 669656 , 668618 

Review-Url: https://codereview.chromium.org/2549443003
Cr-Commit-Position: refs/heads/master@{#436628}

[modify] https://crrev.com/a95f76a0318a32bf5bf1153fb291402806c298d1/content/child/blink_platform_impl.cc
[add] https://crrev.com/a95f76a0318a32bf5bf1153fb291402806c298d1/third_party/WebKit/LayoutTests/fast/html/marquee-bgcolor-expected.html
[add] https://crrev.com/a95f76a0318a32bf5bf1153fb291402806c298d1/third_party/WebKit/LayoutTests/fast/html/marquee-bgcolor.html
[add] https://crrev.com/a95f76a0318a32bf5bf1153fb291402806c298d1/third_party/WebKit/LayoutTests/fast/html/marquee-vspace-hspace-expected.html
[add] https://crrev.com/a95f76a0318a32bf5bf1153fb291402806c298d1/third_party/WebKit/LayoutTests/fast/html/marquee-vspace-hspace.html
[modify] https://crrev.com/a95f76a0318a32bf5bf1153fb291402806c298d1/third_party/WebKit/LayoutTests/fast/inline/inline-marquee-crash-expected.txt
[modify] https://crrev.com/a95f76a0318a32bf5bf1153fb291402806c298d1/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/a95f76a0318a32bf5bf1153fb291402806c298d1/third_party/WebKit/Source/core/html/HTMLMarqueeElement.cpp
[modify] https://crrev.com/a95f76a0318a32bf5bf1153fb291402806c298d1/third_party/WebKit/Source/core/html/HTMLMarqueeElement.h
[modify] https://crrev.com/a95f76a0318a32bf5bf1153fb291402806c298d1/third_party/WebKit/Source/core/html/HTMLMarqueeElement.idl
[delete] https://crrev.com/63ab6f6ed3bf7d00ee21705949a3b143ad245240/third_party/WebKit/Source/core/html/HTMLMarqueeElement.js
[modify] https://crrev.com/a95f76a0318a32bf5bf1153fb291402806c298d1/third_party/WebKit/public/blink_resources.grd

Status: Fixed (was: Assigned)

Sign in to add a comment