New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 668607 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 523461



Sign in to add a comment

Uprev rsyslog to latest from gentoo

Project Member Reported by djkurtz@chromium.org, Nov 25 2016

Issue description

We are currently using version rsyslog 5.8.11, from 2012.  The 5.8.11 version
lives in chromiumos-overlay, since it contains a custom imuxsock-shrink patch.
This patch was accepted upstream in 2014:
 https://github.com/rsyslog/rsyslog/pull/93

This version has at least one known, relatively frequent crash, tracked in  issue 523461 :
"rsyslog imuxsock.so readSocket - pthread_mutex_lock.c:66 crashes"

At this point, the recommended approach to fix this is to just update to a
more recent version of the package. 

The latest version from upstream gentoo is rsyslog-8.22.0, and contains the
imxsock-shrink patch.  So, moving The latest version will also allow moving
back to a pure rsyslog in portage-stable.

Actions:
 (1) uprev rsyslog dependency ebuilds, modify as necessary to build
 (2) uprev rsyslog ebuild, modify as necessary to build
 (3) modify existing rsyslog configuration as needed for version 8
 (4) verify no regressions
    (a) kernel logging to /var/log/messages
    (b) "logger" logs to /var/log/messages
    (c) shill logs to /var/log/net.log
    (c) tlsdate logs to /var/log/tlsdate.log
 
Blocking: 523461
https://chromium-review.googlesource.com/414792
  app-admin/rsyslog: upgrade package and its dependencies to latest to upstream
https://chromium-review.googlesource.com/414749
  init: rsyslog: Do not start in compatibilty 4 mode
https://chromium-review.googlesource.com/414827
  app-admin/rsyslog: Remove package

Comment 3 by derat@chromium.org, Nov 25 2016

Cc: -derat@chromium.org
(Not sure why I was cc-ed; I've never touched anything related to rsyslog as far as I can remember.)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/68a6faa337e40fd3d4395f7474ae6ea8f62e799d

commit 68a6faa337e40fd3d4395f7474ae6ea8f62e799d
Author: Daniel Kurtz <djkurtz@chromium.org>
Date: Wed Nov 30 09:01:59 2016

app-admin/rsyslog: Remove package and update PKG_INSTALL_MASK for 8.22.0

We are upgrading to stock rsyslog-8.22.0, which lives in portage-stable
repository, so we can remove this copy in chromiumos-overlay.

CQ-DEPEND=CL:414792
BUG= chromium:668607 
TEST=emerge-${B} -pvq rsyslog
 => Shows we will build app-admin/rsyslog-8.22.0
TEST=equery-${B} files rsyslog
 => Shows unwanted .conf and .so files are masked
TEST=On device, rsyslog logs kernel, network and logger messages properly

Change-Id: I2f8d473929d23dbfe38fbd264c1abbcb26751716
Reviewed-on: https://chromium-review.googlesource.com/414827
Commit-Ready: Daniel Kurtz <djkurtz@chromium.org>
Tested-by: Daniel Kurtz <djkurtz@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[delete] https://crrev.com/582a0d8a8673f1cf76d6ba6206b00d5cf97ee012/app-admin/rsyslog/files/5-stable/rsyslog.confd
[delete] https://crrev.com/582a0d8a8673f1cf76d6ba6206b00d5cf97ee012/app-admin/rsyslog/rsyslog-5.8.11-r1.ebuild
[delete] https://crrev.com/582a0d8a8673f1cf76d6ba6206b00d5cf97ee012/app-admin/rsyslog/metadata.xml
[delete] https://crrev.com/582a0d8a8673f1cf76d6ba6206b00d5cf97ee012/app-admin/rsyslog/files/5-stable/rsyslog-gentoo.conf
[delete] https://crrev.com/582a0d8a8673f1cf76d6ba6206b00d5cf97ee012/app-admin/rsyslog/rsyslog-5.8.11.ebuild
[delete] https://crrev.com/582a0d8a8673f1cf76d6ba6206b00d5cf97ee012/app-admin/rsyslog/files/5-stable/rsyslog.logrotate
[modify] https://crrev.com/68a6faa337e40fd3d4395f7474ae6ea8f62e799d/chromeos/config/env/app-admin/rsyslog
[delete] https://crrev.com/582a0d8a8673f1cf76d6ba6206b00d5cf97ee012/app-admin/rsyslog/files/5-stable/rsyslog.initd
[delete] https://crrev.com/582a0d8a8673f1cf76d6ba6206b00d5cf97ee012/app-admin/rsyslog/files/5-stable/rsyslog-imuxsock-shrink.patch
[delete] https://crrev.com/582a0d8a8673f1cf76d6ba6206b00d5cf97ee012/app-admin/rsyslog/Manifest

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/f261d506f93b9eb6f10335d63773b900c29d2971

commit f261d506f93b9eb6f10335d63773b900c29d2971
Author: Daniel Kurtz <djkurtz@chromium.org>
Date: Wed Nov 30 08:49:27 2016

app-admin/rsyslog: upgrade package and its dependencies to latest to upstream

rsyslog-8.22.0 requires:
">=dev-libs/libestr-0.1.9"
">=dev-libs/liblogging-1.0.1:=[stdlog]"
">=dev-libs/libfastjson-0.99.2:="

The following changes were made to rsyslog, libfastjson and libestr:
 * EAPI changed from 6 to 5
 * KEYWORDS changed to "*"

Chrome OS uses its own configuration (rsyslog.chromeos), but we allow
combining it with other .conf in rsyslog.d/ (see [0]).

Unfortunately 50-default.conf has settings conflicts with settings
rsyslog.chromeos, so we will explicitly add it to the PKG_INSTALL_MASK in
chromiumos-overlay:chromeos/config/env/app-admin/rsyslog.

[0] https://chromium-review.googlesource.com/#/c/250874/

BUG= chromium:668607 
TEST=emerge-${B} rsyslog
TEST=boot system, inspect /var/log/messages
TEST=logger hello
 => /var/log/messages shows:
 2016-11-24T19:07:40.605738-08:00 NOTICE root[5903]: hello

Change-Id: I2f8d473929d23dbfe38fbd264c1abbcb26751716
Reviewed-on: https://chromium-review.googlesource.com/414792
Commit-Ready: Daniel Kurtz <djkurtz@chromium.org>
Tested-by: Daniel Kurtz <djkurtz@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/f261d506f93b9eb6f10335d63773b900c29d2971/app-admin/rsyslog/files/8-stable/README.gentoo
[add] https://crrev.com/f261d506f93b9eb6f10335d63773b900c29d2971/dev-libs/libestr/libestr-0.1.10.ebuild
[add] https://crrev.com/f261d506f93b9eb6f10335d63773b900c29d2971/dev-libs/liblogging/liblogging-1.0.5.ebuild
[add] https://crrev.com/f261d506f93b9eb6f10335d63773b900c29d2971/dev-libs/libestr/Manifest
[add] https://crrev.com/f261d506f93b9eb6f10335d63773b900c29d2971/dev-libs/libfastjson/libfastjson-0.99.4.ebuild
[add] https://crrev.com/f261d506f93b9eb6f10335d63773b900c29d2971/dev-libs/liblogging/Manifest
[add] https://crrev.com/f261d506f93b9eb6f10335d63773b900c29d2971/dev-libs/libestr/metadata.xml
[add] https://crrev.com/f261d506f93b9eb6f10335d63773b900c29d2971/app-admin/rsyslog/rsyslog-8.22.0.ebuild
[add] https://crrev.com/f261d506f93b9eb6f10335d63773b900c29d2971/dev-libs/liblogging/metadata.xml
[add] https://crrev.com/f261d506f93b9eb6f10335d63773b900c29d2971/app-admin/rsyslog/files/8-stable/rsyslog.conf
[add] https://crrev.com/f261d506f93b9eb6f10335d63773b900c29d2971/app-admin/rsyslog/metadata.xml
[add] https://crrev.com/f261d506f93b9eb6f10335d63773b900c29d2971/dev-libs/libfastjson/metadata.xml
[add] https://crrev.com/f261d506f93b9eb6f10335d63773b900c29d2971/app-admin/rsyslog/files/8-stable/rsyslog.logrotate
[add] https://crrev.com/f261d506f93b9eb6f10335d63773b900c29d2971/app-admin/rsyslog/files/8-stable/rsyslog.confd-r1
[add] https://crrev.com/f261d506f93b9eb6f10335d63773b900c29d2971/app-admin/rsyslog/files/8-stable/50-default.conf
[add] https://crrev.com/f261d506f93b9eb6f10335d63773b900c29d2971/dev-libs/libfastjson/Manifest
[add] https://crrev.com/f261d506f93b9eb6f10335d63773b900c29d2971/app-admin/rsyslog/files/8-stable/rsyslog.initd-r1
[add] https://crrev.com/f261d506f93b9eb6f10335d63773b900c29d2971/app-admin/rsyslog/Manifest

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/4fd4997c2bc9f84c623f1110f6e537505315c5ea

commit 4fd4997c2bc9f84c623f1110f6e537505315c5ea
Author: Daniel Kurtz <djkurtz@chromium.org>
Date: Fri Nov 25 06:22:00 2016

init: rsyslog: Do not start in compatibilty 4 mode

rsyslog v6 disabled "Compatibility mode" (specified via -c option):
http://www.rsyslog.com/doc/v8-stable/compatibility/v6compatibility.html

rsyslog v8 completely removed the '-c' option, and prints usage instead:
http://www.rsyslog.com/doc/v8-stable/compatibility/v8compatibility.html

So, remove '-c' option such that rsyslogd can start.

CQ-DEPEND=CL:414792
BUG= chromium:668607 
TEST=boot system, inspect /var/log/messages
TEST=logger hello
 => /var/log/messages shows:
 2016-11-24T19:07:40.605738-08:00 NOTICE root[5903]: hello

Change-Id: I97d860adec8d522a14f2e69632754a8a7c65f711
Reviewed-on: https://chromium-review.googlesource.com/414749
Commit-Ready: Daniel Kurtz <djkurtz@chromium.org>
Tested-by: Daniel Kurtz <djkurtz@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/4fd4997c2bc9f84c623f1110f6e537505315c5ea/init/syslog.conf

Status: Fixed (was: Started)

Comment 8 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 9 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 10 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c6f2f234e172b0fa2c100be5cd959deef6975c51

commit c6f2f234e172b0fa2c100be5cd959deef6975c51
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Jun 22 14:53:35 2017

rsyslog: disable gcrypt usage

We don't encrypt any log files, so drop support for it.

BUG= chromium:668607 
TEST=precq passes

Change-Id: I3c4533d4d8b2f9d5295b730ade9234b97d6c0339
Reviewed-on: https://chromium-review.googlesource.com/544596
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>

[modify] https://crrev.com/c6f2f234e172b0fa2c100be5cd959deef6975c51/profiles/targets/chromeos/package.use

Labels: VerifyIn-61

Comment 13 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment