New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 668594 link

Starred by 11 users
Status: Verified
Owner:
treib@chromium.org
Closed: Nov 2016
Cc:
█ rookrishna@chromium.org
nyerramilli@chromium.org
kkaluri@chromium.org
█ tdander...@chromium.org
█ msrchandra@chromium.org
treib@chromium.org
dhadd...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary inside border is seen in omnibox.

Reported by dmascare...@etouch.net, Nov 25 2016 
Chrome Version:57.0.2931.0 (Official Build) 5059e49d0a21c1c311653c1613de16b27aefc963-refs/heads/master@{#434310}
OS: Windows 10

What steps will reproduce the problem?
1. Launch chrome,Open Ntp and observe omnibox.

Actual:Unnecessary inside border is seen in omnibox.
Expected: Inside border should not be seen

This is regression issue, broken in 'M 57' and below is manual bisect info:
Good build:57.0.2929.3
Bad build:57.0.2931.0

Will soon update the other info

Comment 1 by msrchandra@chromium.org, Nov 25 2016

Labels: hasbisect-per-revision
Owner: treib@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 57.0.2929.3 (Revision: 434071).
Bad build: 57.0.2931.0 (Revision: 434310).

You are probably looking for a change made after 434155 (known good), but no later than 434156 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspectas some perf builds mightget missing due to failure.
 https://chromium.googlesource.com/chromium/src/+log/ff60cfffbf14d2419494ffc5fcf544f84dd05aa9..1ca95c7cfa0a17fec86196cd8d37d24c2f1c65d7

@treib -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Thank You.

Comment 2 by treib@chromium.org, Nov 25 2016 

Yep, that's probably mine. I'll take a look.

Comment 3 by treib@chromium.org, Nov 25 2016

Status: Started (was: Assigned)

Comment 4 by tkonch...@chromium.org, Nov 25 2016

Labels: ReleaseBlock-Beta
Adding RB label as this is a recent regression

Comment 5 by msrchandra@chromium.org, Nov 25 2016 

Just to update, this issue is specific to Windows only.
Note: Not reproducible on Mac and the build# 56.0.2931.0 is not available on Linux.

Comment 6 by dmascare...@etouch.net, Nov 25 2016 

Note: Above issue is not seen on Mac Pro (10.11.6, 10.12.1)

Comment 7 by willg...@gmail.com, Nov 26 2016 

I see this behavior in Chrome OS running version 57.0.2931.0
Screenshot 2016-11-26 at 1.18.57 PM.png
11.1 KB View Download

Comment 8 by elawrence@chromium.org, Nov 28 2016 

https://codereview.chromium.org/2510373003/diff/100001/chrome/browser/ui/views/location_bar/location_bar_view.cc

CL removed the following lines, which appear likely to be related:
	
     omnibox_view_->SetBorder(	
         views::CreateEmptyBorder(0, 0, 0, omnibox_view_margin));

Comment 9 by elawrence@chromium.org, Nov 28 2016

Cc: treib@chromium.org
 Issue 669074  has been merged into this issue.

Comment 10 by treib@chromium.org, Nov 28 2016 

Yes, CL with the fix is already in review: https://codereview.chromium.org/2527983003/

Comment 11 by tdander...@chromium.org, Nov 29 2016

Cc: rookrishna@chromium.org dhadd...@chromium.org tdander...@chromium.org
 Issue 669313  has been merged into this issue.

Comment 12 by pkasting@chromium.org, Nov 29 2016 

 Issue 669553  has been merged into this issue.

Comment 13 by derat@chromium.org, Nov 29 2016

Labels: OS-Chrome

Comment 15 by sahitya....@techmahindra.com, Nov 30 2016

Labels: OS-Linux
Able to repro on linux 57.0.2936.4 dev.

Comment 16 by treib@chromium.org, Nov 30 2016

Status: Fixed (was: Started)

Comment 17 by treib@chromium.org, Nov 30 2016

Cc: kkaluri@chromium.org
 Issue 668743  has been merged into this issue.

Comment 18 by rookrishna@chromium.org, Dec 5 2016

Status: Verified (was: Fixed)
Verified on 57.0.2941.0/9051.0.0

Comment 19 by keta...@chromium.org, Jan 30 2017 

Has this change been merged to M57 yet?

Comment 20 by elawrence@chromium.org, Jan 30 2017 

Commit 4117edd7... initially landed in 57.0.2937.0
►

Sign in to add a comment