New issue
Advanced search Search tips

Issue 668588 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

CSS Independent Transform Properties: support rotate: <axes> <angle>

Project Member Reported by ericwilligers@chromium.org, Nov 25 2016

Issue description

Blink currently supports (behind a flag)
rotate: <angle> <number>{3}?

The specification is different:-
https://drafts.csswg.org/css-transforms-2/#individual-transforms
rotate: <number>{3}? <angle>

 
The relevant spec change:

commit 92a1dfbe8d1b26e04cabe427886ea6a004309575
Author: Tab Atkins <jackalmage@gmail.com>
Date:   Mon Jun 27 15:29:31 2016 -0700

    [css-transforms-2] Swap order of numbers/angle in 'rotate' to match the rotate3d() function.


Project Member

Comment 2 by bugdroid1@chromium.org, Nov 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33e698665b51f06bf2e2ff2bfb01dc21c3c80bcc

commit 33e698665b51f06bf2e2ff2bfb01dc21c3c80bcc
Author: ericwilligers <ericwilligers@chromium.org>
Date: Sat Nov 26 01:48:48 2016

CSS Independent Transform Properties: support rotate: <axes> <angle>

For consistency with a recent spec update, support
rotate: <number>{3}? <angle>

https://drafts.csswg.org/css-transforms-2/#individual-transforms

BUG= 668588 

Review-Url: https://codereview.chromium.org/2531753002
Cr-Commit-Position: refs/heads/master@{#434562}

[modify] https://crrev.com/33e698665b51f06bf2e2ff2bfb01dc21c3c80bcc/third_party/WebKit/LayoutTests/animations/composition/rotate-composition.html
[modify] https://crrev.com/33e698665b51f06bf2e2ff2bfb01dc21c3c80bcc/third_party/WebKit/LayoutTests/animations/interpolation/rotate-interpolation.html
[modify] https://crrev.com/33e698665b51f06bf2e2ff2bfb01dc21c3c80bcc/third_party/WebKit/LayoutTests/animations/resources/composited-animations-data/rotate-zero-degrees.js
[modify] https://crrev.com/33e698665b51f06bf2e2ff2bfb01dc21c3c80bcc/third_party/WebKit/LayoutTests/animations/rotate-transform-equivalent.html
[modify] https://crrev.com/33e698665b51f06bf2e2ff2bfb01dc21c3c80bcc/third_party/WebKit/LayoutTests/transforms/rotate-parsing.html
[modify] https://crrev.com/33e698665b51f06bf2e2ff2bfb01dc21c3c80bcc/third_party/WebKit/LayoutTests/transforms/rotate.html
[modify] https://crrev.com/33e698665b51f06bf2e2ff2bfb01dc21c3c80bcc/third_party/WebKit/LayoutTests/transforms/transform-properties-mixed.html
[modify] https://crrev.com/33e698665b51f06bf2e2ff2bfb01dc21c3c80bcc/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/33e698665b51f06bf2e2ff2bfb01dc21c3c80bcc/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/33e698665b51f06bf2e2ff2bfb01dc21c3c80bcc/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

Status: Fixed (was: Started)

Sign in to add a comment